A local-first personal finance app
:bug: fix budget tooltip showing if panel is not collapsed (#2887)
Matiss Janis Aboltins96964224f4b7
diff --git a/packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx b/packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsxindex d74c0d999f..b4d8f704df 100644--- a/packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx+++ b/packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx@@ -200,6 +200,7 @@ export function BudgetSummary({ month }: BudgetSummaryProps) {prevMonthName={prevMonthName}month={month}onBudgetAction={onBudgetAction}+ isCollapsed/></View>) : (diff --git a/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx b/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsxindex f63f9c18e8..538cb59d30 100644--- a/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx+++ b/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx@@ -19,6 +19,7 @@ type ToBudgetProps = {prevMonthName: string;style?: CSSProperties;amountStyle?: CSSProperties;+ isCollapsed?: boolean;};export function ToBudget({month,@@ -26,6 +27,7 @@ export function ToBudget({onBudgetAction,style,amountStyle,+ isCollapsed = false,}: ToBudgetProps) {const [menuOpen, setMenuOpen] = useState<string | null>(null);const triggerRef = useRef(null);@@ -34,6 +36,7 @@ export function ToBudget({value: 0,});const availableValue = parseInt(sheetValue);+ const isMenuOpen = Boolean(menuOpen);return (<>@@ -43,13 +46,14 @@ export function ToBudget({prevMonthName={prevMonthName}style={style}amountStyle={amountStyle}+ isTotalsListTooltipDisabled={!isCollapsed || isMenuOpen}/></View><PopovertriggerRef={triggerRef}placement="bottom"- isOpen={!!menuOpen}+ isOpen={isMenuOpen}onOpenChange={() => setMenuOpen(null)}style={{ width: 200 }}>diff --git a/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx b/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsxindex 693fb3a57f..c9cd0e8431 100644--- a/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx+++ b/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx@@ -20,6 +20,7 @@ type ToBudgetAmountProps = {style?: CSSProperties;amountStyle?: CSSProperties;onClick: () => void;+ isTotalsListTooltipDisabled?: boolean;};export function ToBudgetAmount({@@ -27,6 +28,7 @@ export function ToBudgetAmount({style,amountStyle,onClick,+ isTotalsListTooltipDisabled = false,}: ToBudgetAmountProps) {const sheetName = useSheetName(rolloverBudget.toBudget);const sheetValue = useSheetValue({@@ -52,7 +54,8 @@ export function ToBudgetAmount({/>}placement="bottom"- triggerProps={{ delay: 0 }}+ offset={3}+ triggerProps={{ isDisabled: isTotalsListTooltipDisabled }}><PrivacyFilter blurIntensity={7}><Blockdiff --git a/upcoming-release-notes/2887.md b/upcoming-release-notes/2887.mdnew file mode 100644index 0000000000..add739aed4--- /dev/null+++ b/upcoming-release-notes/2887.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [MatissJanis]+---++Fix budget tooltip showing on hover if the panel is not collapsed (the tooltip should show only if panel is collapsed).