Skip to content

A local-first personal finance app

Change Done Reconciling button text - fixes #6196 (#6220)

Juulz975bb3b692d4
diff --git a/packages/desktop-client/src/components/accounts/Reconcile.test.tsx b/packages/desktop-client/src/components/accounts/Reconcile.test.tsx
index a7e8afcdc0..e2ae95b5a0 100644
--- a/packages/desktop-client/src/components/accounts/Reconcile.test.tsx
+++ b/packages/desktop-client/src/components/accounts/Reconcile.test.tsx
@@ -57,7 +57,7 @@ describe('ReconcilingMessage math & UI', () => {
).not.toBeInTheDocument();
// Done button triggers callback
- await userEvent.click(screen.getByText('Done reconciling'));
+ await userEvent.click(screen.getByText('Lock transactions'));
expect(onDone).toHaveBeenCalledTimes(1);
});
diff --git a/packages/desktop-client/src/components/accounts/Reconcile.tsx b/packages/desktop-client/src/components/accounts/Reconcile.tsx
index 10dc527593..168bd0a949 100644
--- a/packages/desktop-client/src/components/accounts/Reconcile.tsx
+++ b/packages/desktop-client/src/components/accounts/Reconcile.tsx
@@ -105,7 +105,9 @@ export function ReconcilingMessage({
)}
<View style={{ marginLeft: 15 }}>
<Button variant="primary" onPress={onDone}>
- <Trans>Done reconciling</Trans>
+ {targetDiff === 0
+ ? t('Lock transactions')
+ : t('Exit reconciliation')}
</Button>
</View>
{targetDiff !== 0 && (
diff --git a/upcoming-release-notes/6220.md b/upcoming-release-notes/6220.md
new file mode 100644
index 0000000000..002b2e280f
--- /dev/null
+++ b/upcoming-release-notes/6220.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [Juulz, matt-fidd]
+---
+
+Changes and clarifies wording of "Done reconciling" button to "Lock transactions" when _All reconciled!_ or "Exit reconciliation if leaving unbalanced.