Skip to content

A local-first personal finance app

Fix react-hooks/exhaustive-deps error on useProperFocus.tsx (#4259)

Joel Jeremy Marqueza0859458985c
diff --git a/eslint.config.mjs b/eslint.config.mjs
index c7cac6e8af..8b92b42f6e 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -796,7 +796,6 @@ export default [
'packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx',
// 'packages/desktop-client/src/hooks/useAccounts.ts',
'packages/desktop-client/src/hooks/useCategories.ts',
- 'packages/desktop-client/src/hooks/useProperFocus.tsx',
],
rules: {
diff --git a/packages/desktop-client/src/hooks/useProperFocus.tsx b/packages/desktop-client/src/hooks/useProperFocus.tsx
index dba487bdce..7c0fc5c7a7 100644
--- a/packages/desktop-client/src/hooks/useProperFocus.tsx
+++ b/packages/desktop-client/src/hooks/useProperFocus.tsx
@@ -98,5 +98,5 @@ export function useProperFocus(
}
prevShouldFocus.current = shouldFocus;
- }, [shouldFocus]);
+ }, [context, ref, shouldFocus]);
}
diff --git a/upcoming-release-notes/4259.md b/upcoming-release-notes/4259.md
new file mode 100644
index 0000000000..4eaa1c5683
--- /dev/null
+++ b/upcoming-release-notes/4259.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [joel-jeremy]
+---
+
+Fix react-hooks/exhaustive-deps error on useProperFocus.tsx