Skip to content

A local-first personal finance app

:bug: fix condition "notes contains (nothing)" throwing error (#3943)

Matiss Janis Aboltinsa2892270d239
diff --git a/packages/loot-core/src/server/accounts/transaction-rules.ts b/packages/loot-core/src/server/accounts/transaction-rules.ts
index 2c2569a5fc..cfa534ef7c 100644
--- a/packages/loot-core/src/server/accounts/transaction-rules.ts
+++ b/packages/loot-core/src/server/accounts/transaction-rules.ts
@@ -291,7 +291,11 @@ export async function runRules(trans) {
return await finalizeTransactionForRules(finalTrans);
}
-function conditionSpecialCases(cond: Condition): Condition {
+function conditionSpecialCases(cond: Condition | null): Condition | null {
+ if (!cond) {
+ return cond;
+ }
+
//special cases that require multiple conditions
if (cond.op === 'is' && cond.field === 'category' && cond.value === null) {
return new Condition(
diff --git a/upcoming-release-notes/3943.md b/upcoming-release-notes/3943.md
new file mode 100644
index 0000000000..988e0ac840
--- /dev/null
+++ b/upcoming-release-notes/3943.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatissJanis]
+---
+
+Fix rule creation throwing error for "notes contains (nothing)" condition.