A local-first personal finance app
Skip Enable Banking PSU headers for local IPs (#8032)
Nustinuaa29d9d81b5b5
diff --git a/packages/sync-server/src/app-enablebanking/app-enablebanking.ts b/packages/sync-server/src/app-enablebanking/app-enablebanking.tsindex ee2b37b9f5..bcf01efffd 100644--- a/packages/sync-server/src/app-enablebanking/app-enablebanking.ts+++ b/packages/sync-server/src/app-enablebanking/app-enablebanking.ts@@ -9,6 +9,7 @@ import {requestLoggerMiddleware,validateSessionMiddleware,} from '#util/middlewares';+import { isBlockedIp } from '#util/ssrf';import type {EnableBankingSession,@@ -39,9 +40,21 @@ function extractPsuHeaders(req: Request): PsuHeaders {? req.headers['user-agent']: undefined;- const headers: PsuHeaders = {};- if (ip) headers['Psu-Ip-Address'] = ip;- if (ua) headers['Psu-User-Agent'] = ua;+ if (!ip || isBlockedIp(ip)) {+ debug('Skipping PSU headers because PSU IP is local/private');+ return {};+ }++ const headers: PsuHeaders = {+ 'Psu-Ip-Address': ip,+ };++ if (ua) {+ headers['Psu-User-Agent'] = ua;+ }++ debug('Using PSU headers for public PSU IP');+return headers;}diff --git a/packages/sync-server/src/app-enablebanking/tests/poll-auth.spec.ts b/packages/sync-server/src/app-enablebanking/tests/poll-auth.spec.tsindex 1635930671..cb8c909b3b 100644--- a/packages/sync-server/src/app-enablebanking/tests/poll-auth.spec.ts+++ b/packages/sync-server/src/app-enablebanking/tests/poll-auth.spec.ts@@ -530,16 +530,13 @@ describe('Enable Banking Express routes', () => {await request(app).post('/transactions')- .set('X-Forwarded-For', '203.0.113.42, 10.0.0.1')+ .set('X-Forwarded-For', '8.8.8.8, 10.0.0.1').set('User-Agent', 'TestBrowser/1.0').send({ accountId: 'uid-1', startDate: '2026-01-01' });// Both the balance and transaction fetch calls should include PSU headersfor (const call of mockFetch.mock.calls) {- expect(call[1].headers).toHaveProperty(- 'Psu-Ip-Address',- '203.0.113.42',- );+ expect(call[1].headers).toHaveProperty('Psu-Ip-Address', '8.8.8.8');expect(call[1].headers).toHaveProperty('Psu-User-Agent','TestBrowser/1.0',diff --git a/upcoming-release-notes/8032.md b/upcoming-release-notes/8032.mdnew file mode 100644index 0000000000..1f809964c7--- /dev/null+++ b/upcoming-release-notes/8032.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [Nustinua]+---++Skip Enable Banking PSU headers when the detected client IP is local or private.