Skip to content

A local-first personal finance app

Add GoCardless banks to the bank factory test suite. (#367)

Robert Dyeraa22e6951dd9
diff --git a/src/app-gocardless/bank-factory.js b/src/app-gocardless/bank-factory.js
index 45947c78d4..c39e03ad2d 100644
--- a/src/app-gocardless/bank-factory.js
+++ b/src/app-gocardless/bank-factory.js
@@ -15,7 +15,7 @@ import SparNordSpNoDK22 from './banks/sparnord-spnodk22.js';
import SpkMarburgBiedenkopfHeladef1mar from './banks/spk-marburg-biedenkopf-heladef1mar.js';
import SpkKarlsruhekarsde66 from './banks/spk-karlsruhe-karsde66.js';
-const banks = [
+export const banks = [
AmericanExpressAesudef1,
BankinterBkbkesmm,
Belfius,
diff --git a/src/app-gocardless/tests/bank-factory.spec.js b/src/app-gocardless/tests/bank-factory.spec.js
index 5dc50bc8fb..61dec1ddbf 100644
--- a/src/app-gocardless/tests/bank-factory.spec.js
+++ b/src/app-gocardless/tests/bank-factory.spec.js
@@ -1,50 +1,20 @@
import BankFactory from '../bank-factory.js';
-import MbankRetailBrexplpw from '../banks/mbank-retail-brexplpw.js';
-import SandboxfinanceSfin0000 from '../banks/sandboxfinance-sfin0000.js';
-import IngPlIngbplpw from '../banks/ing-pl-ingbplpw.js';
+import { banks } from '../bank-factory.js';
import IntegrationBank from '../banks/integration-bank.js';
-import Belfius from '../banks/belfius_gkccbebb.js';
-import SpkMarburgBiedenkopfHeladef1mar from '../banks/spk-marburg-biedenkopf-heladef1mar.js';
describe('BankFactory', () => {
- it('should return MbankRetailBrexplpw when institutionId is mbank-retail-brexplpw', () => {
- const institutionId = MbankRetailBrexplpw.institutionIds[0];
- const result = BankFactory(institutionId);
+ it.each(banks.flatMap((bank) => bank.institutionIds))(
+ `should return same institutionId`,
+ (institutionId) => {
+ const result = BankFactory(institutionId);
- expect(result.institutionIds).toContain(institutionId);
- });
-
- it('should return SandboxfinanceSfin0000 when institutionId is sandboxfinance-sfin0000', () => {
- const institutionId = SandboxfinanceSfin0000.institutionIds[0];
- const result = BankFactory(institutionId);
-
- expect(result.institutionIds).toContain(institutionId);
- });
-
- it('should return IngPlIngbplpw when institutionId is ing-pl-ingbplpw', () => {
- const institutionId = IngPlIngbplpw.institutionIds[0];
- const result = BankFactory(institutionId);
-
- expect(result.institutionIds).toContain(institutionId);
- });
-
- it('should return SpkMarburgBiedenkopfHeladef1mar when institutionId is SPK_MARBURG_BIEDENKOPF_HELADEF1MAR', () => {
- const institutionId = SpkMarburgBiedenkopfHeladef1mar.institutionIds[0];
- const result = BankFactory(institutionId);
-
- expect(result.institutionIds).toContain(institutionId);
- });
-
- it('should return Belfius when institutionId is BELFIUS_GKCCBEBB', () => {
- const institutionId = Belfius.institutionIds[0];
- const result = BankFactory(institutionId);
-
- expect(result.institutionIds).toContain(institutionId);
- });
+ expect(result.institutionIds).toContain(institutionId);
+ },
+ );
it('should return IntegrationBank when institutionId is not found', () => {
const institutionId = IntegrationBank.institutionIds[0];
- const result = BankFactory(institutionId);
+ const result = BankFactory('fake-id-not-found');
expect(result.institutionIds).toContain(institutionId);
});
diff --git a/upcoming-release-notes/367.md b/upcoming-release-notes/367.md
new file mode 100644
index 0000000000..39e4201592
--- /dev/null
+++ b/upcoming-release-notes/367.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [psybers]
+---
+
+Add GoCardless banks to the bank factory test suite.