Skip to content

A local-first personal finance app

When resetting SimpleFIN credentials, parse error and error_code if response body exists (#8068)

Kevinabeeca67deda
diff --git a/packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts b/packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts
index 2879626069..934176c5de 100644
--- a/packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts
+++ b/packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts
@@ -77,11 +77,11 @@ async function ensureSuccessResponse(
response: SecretSetResponse,
fallbackMessage: string,
) {
- if (response.error_code) {
+ if (response?.error_code) {
throw new Error(response.reason || response.error_code);
}
- if (response.error) {
+ if (response?.error) {
throw new Error(response.reason || response.error || fallbackMessage);
}
}
diff --git a/upcoming-release-notes/8068.md b/upcoming-release-notes/8068.md
new file mode 100644
index 0000000000..2c60900d76
--- /dev/null
+++ b/upcoming-release-notes/8068.md
@@ -0,0 +1,6 @@
+---
+category: Bugfixes
+authors: [KevinIsMyName]
+---
+
+Fix SimpleFIN credential reset not resetting accessKey after resetting token.