A local-first personal finance app
[AI] Document user enumeration trade-off on /admin/users endpoint (#8270)
Matiss Janis Aboltinsac572b5e5f30
diff --git a/packages/sync-server/src/app-admin.js b/packages/sync-server/src/app-admin.jsindex e45ac0866e..f606cb72f3 100644--- a/packages/sync-server/src/app-admin.js+++ b/packages/sync-server/src/app-admin.js@@ -26,6 +26,13 @@ app.get('/owner-created/', (req, res) => {}});+// NOTE: This endpoint intentionally has no isAdmin check, which allows user+// enumeration by any authenticated user. This is a known, accepted trade-off+// (wont-fix). Actual's multi-user/OpenID feature is intended for friends &+// family setups, not SaaS, so the attack surface is low. The endpoint is also+// used in the budget ownership transfer flow, where neither the current nor the+// target user is necessarily an admin — adding isAdmin would break that flow+// without a substantial refactor.app.get('/users/', validateSessionMiddleware, (req, res) => {const users = UserService.getAllUsers();res.json(diff --git a/upcoming-release-notes/document-admin-users-user-enumeration.md b/upcoming-release-notes/document-admin-users-user-enumeration.mdnew file mode 100644index 0000000000..2a64bbcc73--- /dev/null+++ b/upcoming-release-notes/document-admin-users-user-enumeration.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Document the accepted user-enumeration trade-off on the sync server `/admin/users` endpoint.