Skip to content

A local-first personal finance app

:bug: (autocomplete) delay when switching from Select to CreatableSelect (#836)

Matiss Janis Aboltinsad9a4067a8a7
diff --git a/packages/desktop-client/src/components/autocomplete/NewPayeeAutocomplete.js b/packages/desktop-client/src/components/autocomplete/NewPayeeAutocomplete.js
index 930b138e66..fbf06ae8d9 100644
--- a/packages/desktop-client/src/components/autocomplete/NewPayeeAutocomplete.js
+++ b/packages/desktop-client/src/components/autocomplete/NewPayeeAutocomplete.js
@@ -56,7 +56,6 @@ export default function PayeeAutocomplete({
showMakeTransfer = true,
showManagePayees = false,
defaultFocusTransferPayees = false,
- isCreatable = false,
onSelect,
onManagePayees,
...props
@@ -78,7 +77,6 @@ export default function PayeeAutocomplete({
const dispatch = useDispatch();
- const useCreatableComponent = isCreatable && focusTransferPayees === false;
const [inputValue, setInputValue] = useState();
return (
@@ -89,6 +87,7 @@ export default function PayeeAutocomplete({
? allOptions.filter(item => value.includes(item.value))
: allOptions.find(item => item.value === value)
}
+ isValidNewOption={input => input && !focusTransferPayees}
isMulti={multi}
inputValue={inputValue}
onInputChange={setInputValue}
@@ -107,7 +106,6 @@ export default function PayeeAutocomplete({
// This is actually a new option, so create it
onSelect(await dispatch(createPayee(selectedValue)));
}}
- isCreatable={useCreatableComponent}
createOptionPosition="first"
formatCreateLabel={inputValue => (
<View
diff --git a/upcoming-release-notes/836.md b/upcoming-release-notes/836.md
new file mode 100644
index 0000000000..866acb2bcf
--- /dev/null
+++ b/upcoming-release-notes/836.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatissJanis]
+---
+
+PayeeAutocomplete: fix long delay when clicking on "make transfer"