A local-first personal finance app
:fire: removing unused variables (batch 1) (#2255)
Matiss Janis Aboltinsae3be13aa816
diff --git a/packages/api/methods.js b/packages/api/methods.jsindex 9af541f267..5ca8226c47 100644--- a/packages/api/methods.js+++ b/packages/api/methods.js@@ -79,10 +79,6 @@ export function getTransactions(accountId, startDate, endDate) {return send('api/transactions-get', { accountId, startDate, endDate });}-export function filterTransactions(accountId, text) {- return send('api/transactions-filter', { accountId, text });-}-export function updateTransaction(id, fields) {return send('api/transaction-update', { id, fields });}diff --git a/packages/desktop-client/src/components/modals/ImportTransactions.jsx b/packages/desktop-client/src/components/modals/ImportTransactions.jsxindex db53af0893..53b289d3ff 100644--- a/packages/desktop-client/src/components/modals/ImportTransactions.jsx+++ b/packages/desktop-client/src/components/modals/ImportTransactions.jsx@@ -132,7 +132,7 @@ function getFileType(filepath) {return rawType;}-function ParsedDate({ parseDateFormat, showParsed, dateFormat, date }) {+function ParsedDate({ parseDateFormat, dateFormat, date }) {const parsed =date &&formatDate(@@ -184,29 +184,29 @@ function getInitialMappings(transactions) {}const dateField = key(- fields.find(([name, value]) => name.toLowerCase().includes('date')) ||- fields.find(([name, value]) => value.match(/^\d+[-/]\d+[-/]\d+$/)),+ fields.find(([name]) => name.toLowerCase().includes('date')) ||+ fields.find(([, value]) => value.match(/^\d+[-/]\d+[-/]\d+$/)),);const amountField = key(- fields.find(([name, value]) => name.toLowerCase().includes('amount')) ||- fields.find(([name, value]) => value.match(/^-?[.,\d]+$/)),+ fields.find(([name]) => name.toLowerCase().includes('amount')) ||+ fields.find(([, value]) => value.match(/^-?[.,\d]+$/)),);const categoryField = key(- fields.find(([name, value]) => name.toLowerCase().includes('category')),+ fields.find(([name]) => name.toLowerCase().includes('category')),);const payeeField = key(fields.find(- ([name, value]) =>+ ([name]) =>name !== dateField && name !== amountField && name !== categoryField,),);const notesField = key(fields.find(- ([name, value]) =>+ ([name]) =>name !== dateField &&name !== amountField &&name !== categoryField &&@@ -216,7 +216,7 @@ function getInitialMappings(transactions) {const inOutField = key(fields.find(- ([name, value]) =>+ ([name]) =>name !== dateField &&name !== amountField &&name !== payeeField &&@@ -1019,7 +1019,7 @@ export function ImportTransactions({ modalProps, options }) {</View>);}}- renderItem={({ key, style, item, editing, focusedField }) => (+ renderItem={({ key, style, item }) => (<View key={key} style={style}><Transactiontransaction={item}diff --git a/packages/desktop-client/src/components/reports/CategorySelector.tsx b/packages/desktop-client/src/components/reports/CategorySelector.tsxindex 21688b2484..ef096bd8e7 100644--- a/packages/desktop-client/src/components/reports/CategorySelector.tsx+++ b/packages/desktop-client/src/components/reports/CategorySelector.tsx@@ -151,7 +151,7 @@ export function CategorySelector({<Checkboxid={`form_${categoryGroup.id}`}checked={allCategoriesInGroupSelected}- onChange={e => {+ onChange={() => {const selectedCategoriesExcludingGroupCategories =selectedCategories.filter(selectedCategory =>@@ -189,7 +189,7 @@ export function CategorySelector({paddingLeft: 10,}}>- {categoryGroup.categories.map((category, index) => {+ {categoryGroup.categories.map(category => {const isChecked = selectedCategories.some(selectedCategory => selectedCategory.id === category.id,);@@ -206,7 +206,7 @@ export function CategorySelector({<Checkboxid={`form_${category.id}`}checked={isChecked}- onChange={e => {+ onChange={() => {if (isChecked) {setSelectedCategories(selectedCategories.filter(diff --git a/packages/desktop-client/src/components/rules/RulesHeader.tsx b/packages/desktop-client/src/components/rules/RulesHeader.tsxindex c4dbfacf79..40ac46cf06 100644--- a/packages/desktop-client/src/components/rules/RulesHeader.tsx+++ b/packages/desktop-client/src/components/rules/RulesHeader.tsx@@ -8,7 +8,7 @@ export function RulesHeader() {const dispatchSelected = useSelectedDispatch();return (- <TableHeader version="v2" style={{}}>+ <TableHeader style={{}}><SelectCellexposed={true}focused={false}diff --git a/packages/desktop-client/src/components/schedules/SchedulesTable.tsx b/packages/desktop-client/src/components/schedules/SchedulesTable.tsxindex 0f49c983f2..27606034e1 100644--- a/packages/desktop-client/src/components/schedules/SchedulesTable.tsx+++ b/packages/desktop-client/src/components/schedules/SchedulesTable.tsx@@ -346,7 +346,7 @@ export function SchedulesTable({return (<View style={{ flex: 1, ...tableStyle }}>- <TableHeader height={ROW_HEIGHT} inset={15} version="v2">+ <TableHeader height={ROW_HEIGHT} inset={15}><Field width="flex">Name</Field><Field width="flex">Payee</Field><Field width="flex">Account</Field>@@ -365,7 +365,6 @@ export function SchedulesTable({<TablerowHeight={ROW_HEIGHT}backgroundColor="transparent"- version="v2"style={{ flex: 1, backgroundColor: 'transparent', ...style }}items={items as ScheduleEntity[]}renderItem={renderItem}diff --git a/packages/desktop-client/src/components/select/DateSelect.tsx b/packages/desktop-client/src/components/select/DateSelect.tsxindex 7ac710fb8e..ddc5bfd333 100644--- a/packages/desktop-client/src/components/select/DateSelect.tsx+++ b/packages/desktop-client/src/components/select/DateSelect.tsx@@ -344,7 +344,7 @@ export function DateSelect({{...inputProps}inputRef={inputRef}value={value}- onPointerUp={e => {+ onPointerUp={() => {if (!embedded) {setOpen(true);}diff --git a/packages/desktop-client/src/components/sidebar/Accounts.tsx b/packages/desktop-client/src/components/sidebar/Accounts.tsxindex c77a9ae365..cd20ccb585 100644--- a/packages/desktop-client/src/components/sidebar/Accounts.tsx+++ b/packages/desktop-client/src/components/sidebar/Accounts.tsx@@ -78,7 +78,7 @@ export function Accounts({setIsDragging(drag.state === 'start');}- const makeDropPadding = (i, length) => {+ const makeDropPadding = i => {if (i === 0) {return {paddingTop: isDragging ? 15 : 0,@@ -118,7 +118,7 @@ export function Accounts({query={getBalanceQuery(account)}onDragChange={onDragChange}onDrop={onReorder}- outerStyle={makeDropPadding(i, budgetedAccounts.length)}+ outerStyle={makeDropPadding(i)}/>))}@@ -143,7 +143,7 @@ export function Accounts({query={getBalanceQuery(account)}onDragChange={onDragChange}onDrop={onReorder}- outerStyle={makeDropPadding(i, offbudgetAccounts.length)}+ outerStyle={makeDropPadding(i)}/>))}@@ -157,7 +157,7 @@ export function Accounts({)}{showClosedAccounts &&- closedAccounts.map((account, i) => (+ closedAccounts.map(account => (<Accountkey={account.id}name={account.name}diff --git a/packages/desktop-client/src/components/table.tsx b/packages/desktop-client/src/components/table.tsxindex cca4f889d7..e7b164a84e 100644--- a/packages/desktop-client/src/components/table.tsx+++ b/packages/desktop-client/src/components/table.tsx@@ -740,12 +740,10 @@ export function SheetCell({type TableHeaderProps = ComponentProps<typeof Row> & {headers?: Array<ComponentProps<typeof Cell>>;- version?: string;};export function TableHeader({headers,children,- version,...rowProps}: TableHeaderProps) {return (@@ -853,7 +851,7 @@ type TableWithNavigatorProps = TableProps & {export const TableWithNavigator = forwardRef<TableHandleRef<TableItem>,TableWithNavigatorProps->(({ fields, ...props }, ref) => {+>(({ fields, ...props }) => {const navigator = useTableNavigator(props.items, fields);return <Table {...props} navigator={navigator} />;});@@ -883,7 +881,6 @@ type TableProps<T extends TableItem = TableItem> = {navigator?: ReturnType<typeof useTableNavigator<T>>;listRef?: unknown;onScroll?: () => void;- version?: string;allowPopupsEscape?: boolean;isSelected?: (id: TableItem['id']) => boolean;saveScrollWidth?: (parent, child) => void;@@ -906,7 +903,6 @@ export const Table = forwardRef(style,navigator,onScroll,- version = 'v1',allowPopupsEscape,isSelected,saveScrollWidth,@@ -1045,7 +1041,7 @@ export const Table = forwardRef();}- function onItemsRendered({ overscanStartIndex, overscanStopIndex }) {+ function onItemsRendered({ overscanStopIndex }) {if (loadMore && overscanStopIndex > items.length - 100) {loadMore();}diff --git a/packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx b/packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsxindex bc84956539..4d6f6610a6 100644--- a/packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx+++ b/packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx@@ -36,7 +36,6 @@ function serializeTransaction(transaction, dateFormat) {const TransactionRow = memo(function TransactionRow({transaction,fields,- payees,categories,accounts,selected,@@ -137,7 +136,6 @@ const TransactionRow = memo(function TransactionRow({export function SimpleTransactionsTable({transactions,- schedules,renderEmpty,fields = ['date', 'payee', 'amount'],style,diff --git a/packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx b/packages/desktop-client/src/components/transactions/TransactionsTable.test.jsxindex 56bf5d3cf7..2d1e51c2e9 100644--- a/packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx+++ b/packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx@@ -765,7 +765,7 @@ describe('Transactions', () => {updateProps({ transactions });function expectErrorToNotExist(transactions) {- transactions.forEach((transaction, idx) => {+ transactions.forEach(transaction => {expect(transaction.error).toBeFalsy();});}diff --git a/packages/desktop-client/src/components/util/AmountInput.tsx b/packages/desktop-client/src/components/util/AmountInput.tsxindex 151936a042..fd110d6817 100644--- a/packages/desktop-client/src/components/util/AmountInput.tsx+++ b/packages/desktop-client/src/components/util/AmountInput.tsx@@ -46,7 +46,6 @@ export function AmountInput({textStyle,focused,disabled = false,- ...props}: AmountInputProps) {const format = useFormat();const negative = (initialValue === 0 && zeroSign === '-') || initialValue < 0;diff --git a/packages/desktop-electron/security.js b/packages/desktop-electron/security.jsindex e961bf7e5f..8e8a9934db 100644--- a/packages/desktop-electron/security.js+++ b/packages/desktop-electron/security.js@@ -1,7 +1,7 @@const electron = require('electron');electron.app.on('web-contents-created', function (event, contents) {- contents.on('will-attach-webview', function (event, webPreferences, params) {+ contents.on('will-attach-webview', function (event, webPreferences) {delete webPreferences.preloadURL;delete webPreferences.preload;@@ -15,11 +15,11 @@ electron.app.on('web-contents-created', function (event, contents) {event.preventDefault();});- contents.on('will-navigate', (event, navigationUrl) => {+ contents.on('will-navigate', event => {event.preventDefault();});- contents.on('new-window', (event, navigationUrl) => {+ contents.on('new-window', event => {event.preventDefault();});});diff --git a/packages/desktop-electron/updater.js b/packages/desktop-electron/updater.jsindex 3a9edae4be..5c95e745d1 100644--- a/packages/desktop-electron/updater.js+++ b/packages/desktop-electron/updater.js@@ -43,7 +43,7 @@ function fireEvent(type, args) {lastEvent = type;}-function start(handler) {+function start() {if (updateTimer) {return null;}@@ -53,7 +53,7 @@ function start(handler) {updateTimer = setInterval(() => {if (!isCheckingForUpdates) {- autoUpdater.checkForUpdates().catch(err => {+ autoUpdater.checkForUpdates().catch(() => {// Do nothing with the error (make sure it's not logged to sentry)});}@@ -74,7 +74,7 @@ function stop() {function check() {if (!isDev && !isCheckingForUpdates) {- autoUpdater.checkForUpdates().catch(err => {+ autoUpdater.checkForUpdates().catch(() => {// Do nothing with the error (make sure it's not logged to sentry)});}diff --git a/packages/loot-core/migrations/1632571489012_remove_cache.js b/packages/loot-core/migrations/1632571489012_remove_cache.jsindex bbd3e21384..77fdac7962 100644--- a/packages/loot-core/migrations/1632571489012_remove_cache.js+++ b/packages/loot-core/migrations/1632571489012_remove_cache.js@@ -1,4 +1,4 @@-export default async function runMigration(db, uuid) {+export default async function runMigration(db) {function getValue(node) {return node.expr != null ? node.expr : node.cachedValue;}diff --git a/packages/loot-core/src/client/actions/account.ts b/packages/loot-core/src/client/actions/account.tsindex 8dcdfe599c..3591f96a86 100644--- a/packages/loot-core/src/client/actions/account.ts+++ b/packages/loot-core/src/client/actions/account.ts@@ -200,7 +200,7 @@ export function setLastTransaction(}export function parseTransactions(filepath, options) {- return async (dispatch: Dispatch) => {+ return async () => {return await send('transactions-parse-file', {filepath,options,diff --git a/packages/loot-core/src/client/actions/queries.ts b/packages/loot-core/src/client/actions/queries.tsindex 1cb86185fa..1e2082d124 100644--- a/packages/loot-core/src/client/actions/queries.ts+++ b/packages/loot-core/src/client/actions/queries.ts@@ -221,7 +221,7 @@ export function updateGroup(group) {}export function deleteGroup(id, transferId?) {- return async function (dispatch, getState) {+ return async function (dispatch) {await send('category-group-delete', { id, transferId });await dispatch(getCategories());// See `deleteCategory` for why we need thisdiff --git a/packages/loot-core/src/client/query-helpers.test.ts b/packages/loot-core/src/client/query-helpers.test.tsindex a5ab249d28..81d703b976 100644--- a/packages/loot-core/src/client/query-helpers.test.ts+++ b/packages/loot-core/src/client/query-helpers.test.ts@@ -362,7 +362,7 @@ describe('query helpers', () => {await tracer.expect('server-query', [{ result: { $count: '*' } }]);await tracer.expect('server-query', ['id']);- await tracer.expect('data', data => {});+ await tracer.expect('data', () => {});paged.fetchNext();paged.fetchNext();@@ -370,7 +370,7 @@ describe('query helpers', () => {paged.fetchNext();await tracer.expect('server-query', ['id']);- await tracer.expect('data', data => {});+ await tracer.expect('data', () => {});// Wait a bit and make sure nothing comes throughconst p = Promise.race([tracer.expect('server-query'), wait(200)]);diff --git a/packages/loot-core/src/platform/client/fetch/index.web.ts b/packages/loot-core/src/platform/client/fetch/index.web.tsindex 83fb068843..055871e885 100644--- a/packages/loot-core/src/platform/client/fetch/index.web.ts+++ b/packages/loot-core/src/platform/client/fetch/index.web.ts@@ -134,7 +134,7 @@ export const unlisten: T.Unlisten = function (name) {};async function closeSocket(onClose) {- socketClient.onclose = event => {+ socketClient.onclose = () => {socketClient = null;onClose();};diff --git a/packages/loot-core/src/platform/exceptions/index.browser.ts b/packages/loot-core/src/platform/exceptions/index.browser.tsindex 56ccc5c37b..95adc82959 100644--- a/packages/loot-core/src/platform/exceptions/index.browser.ts+++ b/packages/loot-core/src/platform/exceptions/index.browser.ts@@ -4,4 +4,4 @@ export const captureException: T.CaptureException = function (exc) {console.log('[Exception]', exc);};-export const captureBreadcrumb: T.CaptureBreadcrumb = function (breadcrumb) {};+export const captureBreadcrumb: T.CaptureBreadcrumb = function () {};diff --git a/packages/loot-core/src/platform/exceptions/index.electron.ts b/packages/loot-core/src/platform/exceptions/index.electron.tsindex 56ccc5c37b..95adc82959 100644--- a/packages/loot-core/src/platform/exceptions/index.electron.ts+++ b/packages/loot-core/src/platform/exceptions/index.electron.ts@@ -4,4 +4,4 @@ export const captureException: T.CaptureException = function (exc) {console.log('[Exception]', exc);};-export const captureBreadcrumb: T.CaptureBreadcrumb = function (breadcrumb) {};+export const captureBreadcrumb: T.CaptureBreadcrumb = function () {};diff --git a/packages/loot-core/src/platform/exceptions/index.testing.ts b/packages/loot-core/src/platform/exceptions/index.testing.tsindex 988d67f826..82e6c5422d 100644--- a/packages/loot-core/src/platform/exceptions/index.testing.ts+++ b/packages/loot-core/src/platform/exceptions/index.testing.ts@@ -1,5 +1,5 @@import type * as T from '.';-export const captureException: T.CaptureException = function (exc) {};+export const captureException: T.CaptureException = function () {};-export const captureBreadcrumb: T.CaptureBreadcrumb = function (info) {};+export const captureBreadcrumb: T.CaptureBreadcrumb = function () {};diff --git a/packages/loot-core/src/platform/exceptions/index.web.ts b/packages/loot-core/src/platform/exceptions/index.web.tsindex 56ccc5c37b..95adc82959 100644--- a/packages/loot-core/src/platform/exceptions/index.web.ts+++ b/packages/loot-core/src/platform/exceptions/index.web.ts@@ -4,4 +4,4 @@ export const captureException: T.CaptureException = function (exc) {console.log('[Exception]', exc);};-export const captureBreadcrumb: T.CaptureBreadcrumb = function (breadcrumb) {};+export const captureBreadcrumb: T.CaptureBreadcrumb = function () {};diff --git a/packages/loot-core/src/platform/server/asyncStorage/index.web.ts b/packages/loot-core/src/platform/server/asyncStorage/index.web.tsindex 1243f97b66..c9bc80c7f7 100644--- a/packages/loot-core/src/platform/server/asyncStorage/index.web.ts+++ b/packages/loot-core/src/platform/server/asyncStorage/index.web.ts@@ -34,7 +34,7 @@ export const setItem: T.SetItem = async function (key, value) {new Promise((resolve, reject) => {const req = objectStore.put(value, key);req.onerror = e => reject(e);- req.onsuccess = e => resolve(undefined);+ req.onsuccess = () => resolve(undefined);commit(transaction);});};@@ -48,7 +48,7 @@ export const removeItem: T.RemoveItem = async function (key) {return new Promise((resolve, reject) => {const req = objectStore.delete(key);req.onerror = e => reject(e);- req.onsuccess = e => resolve(undefined);+ req.onsuccess = () => resolve(undefined);commit(transaction);});};@@ -84,7 +84,7 @@ export const multiSet: T.MultiSet = async function (keyValues) {return new Promise((resolve, reject) => {const req = objectStore.put(value, key);req.onerror = e => reject(e);- req.onsuccess = e => resolve(undefined);+ req.onsuccess = () => resolve(undefined);});}),);@@ -104,7 +104,7 @@ export const multiRemove: T.MultiRemove = async function (keys) {return new Promise((resolve, reject) => {const req = objectStore.delete(key);req.onerror = e => reject(e);- req.onsuccess = e => resolve(undefined);+ req.onsuccess = () => resolve(undefined);});}),);diff --git a/packages/loot-core/src/platform/server/connection/index.api.ts b/packages/loot-core/src/platform/server/connection/index.api.tsindex a28c787ae8..1aacd8372f 100644--- a/packages/loot-core/src/platform/server/connection/index.api.ts+++ b/packages/loot-core/src/platform/server/connection/index.api.ts@@ -2,7 +2,7 @@ import type * as T from '.';export const init: T.Init = function () {};-export const send: T.Send = function (type, args) {+export const send: T.Send = function () {// Nothing};diff --git a/packages/loot-core/src/platform/server/fs/index.web.ts b/packages/loot-core/src/platform/server/fs/index.web.tsindex 370a087d2d..06eebb13ad 100644--- a/packages/loot-core/src/platform/server/fs/index.web.ts+++ b/packages/loot-core/src/platform/server/fs/index.web.ts@@ -313,7 +313,7 @@ export const removeDirRecursively = async function (dirpath) {}};-export const getModifiedTime = async function (filepath) {+export const getModifiedTime = async function () {throw new Error('getModifiedTime not supported on the web (only used for backups)',);diff --git a/packages/loot-core/src/platform/server/indexeddb/index.web.ts b/packages/loot-core/src/platform/server/indexeddb/index.web.tsindex 65f2dc7c86..f739654549 100644--- a/packages/loot-core/src/platform/server/indexeddb/index.web.ts+++ b/packages/loot-core/src/platform/server/indexeddb/index.web.ts@@ -34,7 +34,7 @@ function _openDatabase() {openRequest.onblocked = e => console.log('blocked', e);- openRequest.onerror = event => {+ openRequest.onerror = () => {console.log('openRequest error');reject(new Error('indexeddb-failure: Could not open IndexedDB'));};@@ -102,7 +102,7 @@ export const getStore: T.GetStore = function (db, name) {export const get: T.Get = async function (store, key, mapper = x => x) {return new Promise((resolve, reject) => {const req = store.get(key);- req.onsuccess = e => {+ req.onsuccess = () => {resolve(mapper(req.result));};req.onerror = e => reject(e);@@ -112,7 +112,7 @@ export const get: T.Get = async function (store, key, mapper = x => x) {export const set: T.Set = async function (store, item) {return new Promise((resolve, reject) => {const req = store.put(item);- req.onsuccess = e => resolve(undefined);+ req.onsuccess = () => resolve(undefined);req.onerror = e => reject(e);});};@@ -120,7 +120,7 @@ export const set: T.Set = async function (store, item) {export const del: T.Del = async function (store, key) {return new Promise((resolve, reject) => {const req = store.delete(key);- req.onsuccess = e => resolve(undefined);+ req.onsuccess = () => resolve(undefined);req.onerror = e => reject(e);});};diff --git a/packages/loot-core/src/server/__mocks__/post.ts b/packages/loot-core/src/server/__mocks__/post.tsindex 1eb6e4263a..2040820551 100644--- a/packages/loot-core/src/server/__mocks__/post.ts+++ b/packages/loot-core/src/server/__mocks__/post.ts@@ -4,6 +4,6 @@ export {handleRequestBinary as postBinary,} from '../tests/mockSyncServer';-export const get = function (url) {+export const get = function () {throw new Error('get unimplemented');};diff --git a/packages/loot-core/src/server/accounts/rules.test.ts b/packages/loot-core/src/server/accounts/rules.test.tsindex 3238952335..8368131e65 100644--- a/packages/loot-core/src/server/accounts/rules.test.ts+++ b/packages/loot-core/src/server/accounts/rules.test.ts@@ -490,7 +490,7 @@ describe('Rule', () => {];const foundRules = [];- iterateIds(rules, 'description', (rule, value) => {+ iterateIds(rules, 'description', rule => {foundRules.push(rule.getId());});expect(foundRules).toEqual(['first', 'second', 'second', 'third']);diff --git a/packages/loot-core/src/server/accounts/rules.ts b/packages/loot-core/src/server/accounts/rules.tsindex 0a514f7585..96b33b5251 100644--- a/packages/loot-core/src/server/accounts/rules.ts+++ b/packages/loot-core/src/server/accounts/rules.ts@@ -520,7 +520,7 @@ export class Rule {});}- execActions(object) {+ execActions() {const changes = {};this.actions.forEach(action => action.exec(changes));return changes;@@ -528,7 +528,7 @@ export class Rule {exec(object) {if (this.evalConditions(object)) {- return this.execActions(object);+ return this.execActions();}return null;}diff --git a/packages/loot-core/src/server/api.ts b/packages/loot-core/src/server/api.tsindex 9c42e25a60..a89625971e 100644--- a/packages/loot-core/src/server/api.ts+++ b/packages/loot-core/src/server/api.ts@@ -253,7 +253,7 @@ handlers['api/finish-import'] = async function () {await handlers['get-budget-bounds']();await sheet.waitOnSpreadsheet();- await cloudStorage.upload().catch(err => {});+ await cloudStorage.upload().catch(() => {});connection.send('finish-import');IMPORT_MODE = false;@@ -426,10 +426,6 @@ handlers['api/transactions-get'] = async function ({return data;};-handlers['api/transactions-filter'] = async function ({ text, accountId }) {- throw new Error('`filterTransactions` is deprecated, use `runQuery` instead');-};-handlers['api/transaction-update'] = withMutation(async function ({id,fields,diff --git a/packages/loot-core/src/server/aql/compiler.ts b/packages/loot-core/src/server/aql/compiler.tsindex e5c6397bbc..8c6bb76b7d 100644--- a/packages/loot-core/src/server/aql/compiler.ts+++ b/packages/loot-core/src/server/aql/compiler.ts@@ -1015,7 +1015,7 @@ export function compileQuery(const {tableViews = {},- tableFilters = name => [],+ tableFilters = () => [],customizeQuery = queryState => queryState,} = schemaConfig;diff --git a/packages/loot-core/src/server/bench.ts b/packages/loot-core/src/server/bench.tsindex ec2ff9fc0e..4607493426 100644--- a/packages/loot-core/src/server/bench.ts+++ b/packages/loot-core/src/server/bench.ts@@ -9,7 +9,7 @@ const queries = fs.split('___BOUNDARY').map(q => q.trim());-function runQueries(n?) {+function runQueries() {for (let i = 0; i < queries.length; i++) {if (queries[i] !== '') {db.runQuery(queries[i], [], true);diff --git a/packages/loot-core/src/server/cloud-storage.ts b/packages/loot-core/src/server/cloud-storage.tsindex c4735c5ae0..7be08444ff 100644--- a/packages/loot-core/src/server/cloud-storage.ts+++ b/packages/loot-core/src/server/cloud-storage.ts@@ -334,7 +334,7 @@ export async function possiblyUpload() {}// Don't block on uploading- upload().catch(err => {});+ upload().catch(() => {});}export async function removeFile(fileId) {diff --git a/packages/loot-core/src/server/db/index.ts b/packages/loot-core/src/server/db/index.tsindex f662cf3c7a..3a359f0659 100644--- a/packages/loot-core/src/server/db/index.ts+++ b/packages/loot-core/src/server/db/index.ts@@ -618,15 +618,6 @@ export async function getTransaction(id) {return rows[0];}-export async function getTransactionsByDate(- accountId,- startDate,- endDate,- options = {},-) {- throw new Error('`getTransactionsByDate` is deprecated');-}-export async function getTransactions(accountId) {if (arguments.length > 1) {throw new Error(diff --git a/packages/loot-core/src/server/importers/actual.ts b/packages/loot-core/src/server/importers/actual.tsindex 31a4f40b59..675b8a1161 100644--- a/packages/loot-core/src/server/importers/actual.ts+++ b/packages/loot-core/src/server/importers/actual.ts@@ -43,5 +43,5 @@ export async function importActual(_filepath: string, buffer: Buffer) {await handlers['load-budget']({ id });await handlers['get-budget-bounds']();await waitOnSpreadsheet();- await cloudStorage.upload().catch(err => {});+ await cloudStorage.upload().catch(() => {});}diff --git a/packages/loot-core/src/server/importers/ynab4.ts b/packages/loot-core/src/server/importers/ynab4.tsindex f285b8047c..3fbf27d0a1 100644--- a/packages/loot-core/src/server/importers/ynab4.ts+++ b/packages/loot-core/src/server/importers/ynab4.ts@@ -199,7 +199,7 @@ async function importTransactions(subtransactions:transaction.subTransactions &&- transaction.subTransactions.map((t, i) => {+ transaction.subTransactions.map(t => {return {id: entityIdMap.get(t.entityId),amount: amountToInteger(t.amount),@@ -346,7 +346,7 @@ export async function doImport(data: YNAB4.YFull) {console.log('Setting up...');}-export function getBudgetName(filepath, _data) {+export function getBudgetName(filepath) {let unixFilepath = normalizePathSep(filepath);if (!/\.zip/.test(unixFilepath)) {diff --git a/packages/loot-core/src/server/main.ts b/packages/loot-core/src/server/main.tsindex 3a80926cdc..03d661f06d 100644--- a/packages/loot-core/src/server/main.ts+++ b/packages/loot-core/src/server/main.ts@@ -1867,7 +1867,7 @@ handlers['delete-budget'] = async function ({ id, cloudFileId }) {// If it's a cloud file, you can delete it from the server by// passing its cloud idif (cloudFileId) {- await cloudStorage.removeFile(cloudFileId).catch(err => {});+ await cloudStorage.removeFile(cloudFileId).catch(() => {});}// If a local file exists, you can delete it by passing its local iddiff --git a/packages/loot-core/src/server/migrate/cli.ts b/packages/loot-core/src/server/migrate/cli.tsindex bc3bdff751..5928b67141 100755--- a/packages/loot-core/src/server/migrate/cli.ts+++ b/packages/loot-core/src/server/migrate/cli.ts@@ -48,7 +48,7 @@ function create(migrationName) {async function list(db) {const migrationsDir = getMigrationsDir();- const applied = await getAppliedMigrations(getDatabase());+ const applied = await getAppliedMigrations(db);const all = await getMigrationList(migrationsDir);const pending = getPending(applied, all);diff --git a/packages/loot-core/src/server/schedules/app.ts b/packages/loot-core/src/server/schedules/app.tsindex 0b82e4248f..1bd4c0eb01 100644--- a/packages/loot-core/src/server/schedules/app.ts+++ b/packages/loot-core/src/server/schedules/app.ts@@ -563,7 +563,7 @@ app.method('schedule/get-upcoming-dates', getUpcomingDates);app.service(trackJSONPaths);-app.events.on('sync', ({ type, subtype }) => {+app.events.on('sync', ({ type }) => {const completeEvent =type === 'success' || type === 'error' || type === 'unauthorized';diff --git a/packages/loot-core/src/server/schedules/find-schedules.ts b/packages/loot-core/src/server/schedules/find-schedules.tsindex 373a2bbe8a..8b45406138 100644--- a/packages/loot-core/src/server/schedules/find-schedules.ts+++ b/packages/loot-core/src/server/schedules/find-schedules.ts@@ -53,7 +53,7 @@ function getRank(day1, day2) {return 1 / (dayDiff + 1);}-function matchSchedules(allOccurs, config, partialMatchRank = 0.5) {+function matchSchedules(allOccurs, config) {allOccurs = [...allOccurs].reverse();const baseOccur = allOccurs[0];const occurs = allOccurs.slice(1);@@ -107,13 +107,7 @@ function matchSchedules(allOccurs, config, partialMatchRank = 0.5) {return schedules;}-async function schedulesForPattern(- baseStart,- numDays,- baseConfig,- accountId,- partialMatchRank?: number,-) {+async function schedulesForPattern(baseStart, numDays, baseConfig, accountId) {let schedules = [];for (let i = 0; i < numDays; i++) {@@ -142,9 +136,7 @@ async function schedulesForPattern(});}- schedules = schedules.concat(- matchSchedules(data, config, partialMatchRank),- );+ schedules = schedules.concat(matchSchedules(data, config));}return schedules;}@@ -196,9 +188,6 @@ async function monthlyLastDay(startDate, accountId) {1,{ frequency: 'monthly', patterns: [{ type: 'day', value: -1 }] },accountId,- // Last day patterns should win over day-specific ones that just- // happen to match- 0.75,);const s2 = await schedulesForPattern(@@ -206,7 +195,6 @@ async function monthlyLastDay(startDate, accountId) {1,{ frequency: 'monthly', patterns: [{ type: 'day', value: -1 }] },accountId,- 0.75,);return s1.concat(s2);@@ -368,7 +356,7 @@ export async function findSchedules() {}const schedules = [...groupBy(allSchedules, 'payee').entries()].map(- ([payeeId, schedules]) => {+ ([, schedules]) => {schedules.sort((s1, s2) => s2.rank - s1.rank);const winner = schedules[0];diff --git a/packages/loot-core/src/server/spreadsheet/spreadsheet.ts b/packages/loot-core/src/server/spreadsheet/spreadsheet.tsindex 4fbeacd436..4aff0f0062 100644--- a/packages/loot-core/src/server/spreadsheet/spreadsheet.ts+++ b/packages/loot-core/src/server/spreadsheet/spreadsheet.ts@@ -78,7 +78,7 @@ export class Spreadsheet {return this.nodes.has(name);}- add(name, expr, value) {+ add(name, expr) {this.set(name, expr);}diff --git a/packages/loot-core/src/server/sync/index.ts b/packages/loot-core/src/server/sync/index.tsindex c2fa6e3016..0cd7386bb4 100644--- a/packages/loot-core/src/server/sync/index.ts+++ b/packages/loot-core/src/server/sync/index.ts@@ -131,7 +131,7 @@ async function fetchAll(table, ids) {}sql += ` WHERE `;- sql += partIds.map(id => `${column} = ?`).join(' OR ');+ sql += partIds.map(() => `${column} = ?`).join(' OR ');try {const rows = await db.runQuery(sql, partIds, true);diff --git a/packages/loot-core/src/server/tests/mockSyncServer.ts b/packages/loot-core/src/server/tests/mockSyncServer.tsindex 79994dc174..4852c09550 100644--- a/packages/loot-core/src/server/tests/mockSyncServer.ts+++ b/packages/loot-core/src/server/tests/mockSyncServer.ts@@ -82,7 +82,7 @@ handlers['/plaid/handoff_public_token'] = () => {// Do nothing};-handlers['/plaid/accounts'] = ({ client_id, group_id, item_id }) => {+handlers['/plaid/accounts'] = () => {// Ignore the parameters and just return the accounts.return { accounts: currentMockData.accounts };};diff --git a/packages/loot-core/src/shared/async.test.ts b/packages/loot-core/src/shared/async.test.tsindex 6f3c5e9fff..4aa9f9000e 100644--- a/packages/loot-core/src/shared/async.test.ts+++ b/packages/loot-core/src/shared/async.test.ts@@ -60,7 +60,7 @@ describe('async', () => {test('sequential fn should still flush queue when error is thrown', async () => {const test = async fn => {fn(1);- fn(2, { throwError: true }).catch(err => {});+ fn(2, { throwError: true }).catch(() => {});await fn(3);};@@ -86,7 +86,7 @@ describe('async', () => {// happened in here, it wouldn't effect anything else)expect(data).toEqual([1, 1, 1, 2]);});- fn(2, { throwError: true }).catch(err => {+ fn(2, { throwError: true }).catch(() => {// Same as aboveexpect(data).toEqual([1, 1, 1, 2, 3]);});diff --git a/packages/loot-core/src/types/api-handlers.d.ts b/packages/loot-core/src/types/api-handlers.d.tsindex c4e8c2b11b..1a667eba31 100644--- a/packages/loot-core/src/types/api-handlers.d.ts+++ b/packages/loot-core/src/types/api-handlers.d.ts@@ -72,9 +72,6 @@ export interface ApiHandlers {endDate;}) => Promise<unknown>;- /** @deprecated `filterTransactions` is deprecated, use `runQuery` instead' */- 'api/transactions-filter': (arg: { text; accountId }) => Promise<void>;-'api/transaction-update': (arg: { id; fields }) => Promise<unknown>;'api/transaction-delete': (arg: { id }) => Promise<unknown>;diff --git a/upcoming-release-notes/2255.md b/upcoming-release-notes/2255.mdnew file mode 100644index 0000000000..0ab94f27b7--- /dev/null+++ b/upcoming-release-notes/2255.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Code clean-up: removing unused variables