Skip to content

A local-first personal finance app

fixup! Schedules editor: exclude closed accounts in Account autocomplete

Trevor Farlowb131879d309e
diff --git a/packages/desktop-client/src/components/accounts/TransactionsTable.js b/packages/desktop-client/src/components/accounts/TransactionsTable.js
index ba9599821f..2d25cbe842 100644
--- a/packages/desktop-client/src/components/accounts/TransactionsTable.js
+++ b/packages/desktop-client/src/components/accounts/TransactionsTable.js
@@ -762,7 +762,6 @@ export const Transaction = React.memo(function Transaction(props) {
<AccountAutocomplete
value={accountId}
accounts={accounts}
- includeClosedAccounts
shouldSaveFromKey={shouldSaveFromKey}
tableBehavior={true}
focused={true}
diff --git a/packages/desktop-client/src/components/schedules/EditSchedule.js b/packages/desktop-client/src/components/schedules/EditSchedule.js
index 3433222221..e8fcb19c45 100644
--- a/packages/desktop-client/src/components/schedules/EditSchedule.js
+++ b/packages/desktop-client/src/components/schedules/EditSchedule.js
@@ -442,6 +442,7 @@ export default function ScheduleDetails() {
<FormField style={{ flex: 1 }}>
<FormLabel title="Account" />
<AccountAutocomplete
+ includeClosedAccounts={false}
value={state.fields.account}
inputProps={{ placeholder: '(none)' }}
onSelect={id =>
diff --git a/packages/desktop-client/src/components/util/GenericInput.js b/packages/desktop-client/src/components/util/GenericInput.js
index 4813dd8a48..8d8c6aeaf0 100644
--- a/packages/desktop-client/src/components/util/GenericInput.js
+++ b/packages/desktop-client/src/components/util/GenericInput.js
@@ -66,7 +66,6 @@ export default function GenericInput({
content = (
<AccountAutocomplete
accounts={accounts}
- includeClosedAccounts
value={value}
multi={multi}
openOnFocus={false}
diff --git a/packages/loot-design/src/components/AccountAutocomplete.js b/packages/loot-design/src/components/AccountAutocomplete.js
index 7b2acadd31..e0e43e4d4e 100644
--- a/packages/loot-design/src/components/AccountAutocomplete.js
+++ b/packages/loot-design/src/components/AccountAutocomplete.js
@@ -68,7 +68,7 @@ export function AccountList({
export default function AccountAutocomplete({
embedded,
- includeClosedAccounts = false,
+ includeClosedAccounts = true,
...props
}) {
let accounts = useCachedAccounts() || [];
diff --git a/packages/loot-design/src/components/modals/EditField.js b/packages/loot-design/src/components/modals/EditField.js
index a9c2208c54..9b0277d681 100644
--- a/packages/loot-design/src/components/modals/EditField.js
+++ b/packages/loot-design/src/components/modals/EditField.js
@@ -72,7 +72,6 @@ function EditField({
<AccountAutocomplete
value={null}
accounts={accounts}
- includeClosedAccounts
focused={true}
embedded={true}
onSelect={value => {