A local-first personal finance app
fix split transaction sort order when duplicating (#5911)
guizab6f80c26e6b0
diff --git a/packages/desktop-client/src/hooks/useTransactionBatchActions.ts b/packages/desktop-client/src/hooks/useTransactionBatchActions.tsindex 8c5e9524b5..ec9008dbf5 100644--- a/packages/desktop-client/src/hooks/useTransactionBatchActions.ts+++ b/packages/desktop-client/src/hooks/useTransactionBatchActions.ts@@ -280,19 +280,14 @@ export function useTransactionBatchActions() {const transactions = data as TransactionEntity[];const changes = {- added: transactions- .reduce(- (- newTransactions: TransactionEntity[],- trans: TransactionEntity,- ) => {- return newTransactions.concat(- realizeTempTransactions(ungroupTransaction(trans)),- );- },- [],- )- .map(({ sort_order, ...trans }: TransactionEntity) => ({ ...trans })),+ added: transactions.reduce(+ (newTransactions: TransactionEntity[], trans: TransactionEntity) => {+ return newTransactions.concat(+ realizeTempTransactions(ungroupTransaction(trans)),+ );+ },+ [],+ ),};await send('transactions-batch-update', changes);diff --git a/packages/loot-core/src/shared/transactions.ts b/packages/loot-core/src/shared/transactions.tsindex bf5c4a5d1c..0df560f8a5 100644--- a/packages/loot-core/src/shared/transactions.ts+++ b/packages/loot-core/src/shared/transactions.ts@@ -345,6 +345,7 @@ export function realizeTempTransactions(const parent = {...transactions.find(t => !t.is_child),id: uuidv4(),+ sort_order: Date.now(),} as TransactionEntity;const children = transactions.filter(t => t.is_child);return [diff --git a/upcoming-release-notes/5911.md b/upcoming-release-notes/5911.mdnew file mode 100644index 0000000000..e84f96687a--- /dev/null+++ b/upcoming-release-notes/5911.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [guizaa]+---++Adds functionality to maintain sort order when duplicating a split transaction and generate new valid sort order for duplicate transactions.