Skip to content

A local-first personal finance app

fix styling of transaction page on mobile (#1820)

凯 - kǎib7a2f1624676
diff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png
index 8b6f637184..6abd408273 100644
Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png
index 0cfdffe0d7..e2981f282c 100644
Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png
index 08644ff837..65935ac142 100644
Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png differ
diff --git a/packages/desktop-client/src/components/mobile/MobileForms.js b/packages/desktop-client/src/components/mobile/MobileForms.js
index 21ebbc657a..66f5bd780f 100644
--- a/packages/desktop-client/src/components/mobile/MobileForms.js
+++ b/packages/desktop-client/src/components/mobile/MobileForms.js
@@ -32,8 +32,8 @@ export function FieldLabel({ title, flush, style }) {
const valueStyle = {
borderWidth: 1,
borderColor: theme.formInputBorder,
- marginLeft: -1,
- marginRight: -1,
+ marginLeft: 8,
+ marginRight: 8,
height: FIELD_HEIGHT,
paddingHorizontal: styles.mobileEditingPadding,
};
diff --git a/packages/desktop-client/src/components/transactions/MobileTransaction.js b/packages/desktop-client/src/components/transactions/MobileTransaction.js
index 5a88eee4d2..8705224ac7 100644
--- a/packages/desktop-client/src/components/transactions/MobileTransaction.js
+++ b/packages/desktop-client/src/components/transactions/MobileTransaction.js
@@ -570,14 +570,18 @@ class TransactionEditInner extends PureComponent {
/>
</View>
- <View style={{ marginLeft: 35, marginRight: 35 }}>
+ <View style={{ marginLeft: 0, marginRight: 8 }}>
<FieldLabel title="Cleared" />
<BooleanField
checked={transaction.cleared}
onUpdate={checked =>
this.onEdit(transaction, 'cleared', checked)
}
- style={{ marginTop: 4 }}
+ style={{
+ margin: 'auto',
+ width: 22,
+ height: 22,
+ }}
/>
</View>
</View>
diff --git a/upcoming-release-notes/1820.md b/upcoming-release-notes/1820.md
new file mode 100644
index 0000000000..c678478a00
--- /dev/null
+++ b/upcoming-release-notes/1820.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [KaiBelmo]
+---
+
+Fix styling of transaction page on mobile.
\ No newline at end of file