Skip to content

A local-first personal finance app

[AI] Fix /update-vrt build step after lage browser-build refactor (#7781)

Matiss Janis Aboltinsb9ab3e7bc616
diff --git a/.github/workflows/vrt-update-generate.yml b/.github/workflows/vrt-update-generate.yml
index dbf9cf27c3..8221ef1109 100644
--- a/.github/workflows/vrt-update-generate.yml
+++ b/.github/workflows/vrt-update-generate.yml
@@ -82,16 +82,17 @@ jobs:
with:
download-translations: 'false'
- name: Build browser bundle
- # REACT_APP_NETLIFY=true keeps the "Create test file" button in the
- # production bundle — every VRT test's beforeEach relies on it via
- # ConfigurationPage.createTestFile().
+ # REACT_APP_NETLIFY=true flips isNonProductionEnvironment() on in the
+ # bundle so the "Create test file" button (used by every e2e beforeEach
+ # via ConfigurationPage.createTestFile()) is still rendered in a
+ # production build. Without it, e2e tests would time out waiting for
+ # a button that was tree-shaken out.
+ # --skip-translations keeps VRT screenshots deterministic by rendering
+ # source-code English instead of upstream Weblate en.json (which can
+ # drift between snapshot capture and test runs).
env:
REACT_APP_NETLIFY: 'true'
- run: |
- yarn workspace plugins-service build
- yarn workspace @actual-app/crdt build
- yarn workspace @actual-app/core build:browser
- yarn workspace @actual-app/web build:browser
+ run: yarn build:browser --skip-translations
- name: Upload build artifact
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
diff --git a/upcoming-release-notes/7781.md b/upcoming-release-notes/7781.md
new file mode 100644
index 0000000000..a8ae325793
--- /dev/null
+++ b/upcoming-release-notes/7781.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Fix update-vrt workflow