Skip to content

A local-first personal finance app

♻️ remove unnecessary playwright container pulls to speed up CI (#8067)

Matt Fiddamanbab555a11746
diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
index ecf8eda012..be74689782 100644
--- a/.github/workflows/e2e-test.yml
+++ b/.github/workflows/e2e-test.yml
@@ -28,8 +28,6 @@ jobs:
build-web:
name: Build web bundle
runs-on: ubuntu-latest
- container:
- image: mcr.microsoft.com/playwright:v1.59.1-jammy
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
@@ -38,8 +36,6 @@ jobs:
uses: ./.github/actions/setup
with:
download-translations: 'false'
- - name: Trust the repository directory
- run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Build browser bundle
# REACT_APP_NETLIFY=true flips isNonProductionEnvironment() on in the
# bundle so the "Create test file" button (used by every e2e beforeEach
@@ -171,8 +167,6 @@ jobs:
needs: vrt
runs-on: ubuntu-latest
if: ${{ !cancelled() }}
- container:
- image: mcr.microsoft.com/playwright:v1.59.1-jammy
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
diff --git a/.github/workflows/vrt-update-generate.yml b/.github/workflows/vrt-update-generate.yml
index a4c5fb7565..3ee777863e 100644
--- a/.github/workflows/vrt-update-generate.yml
+++ b/.github/workflows/vrt-update-generate.yml
@@ -65,18 +65,12 @@ jobs:
name: Build web bundle
runs-on: ubuntu-latest
needs: get-pr
- container:
- image: mcr.microsoft.com/playwright:v1.59.1-jammy
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
ref: ${{ needs.get-pr.outputs.head_sha }}
persist-credentials: false
- - name: Trust workspace directory
- run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- shell: bash
-
- name: Set up environment
uses: ./.github/actions/setup
with:
@@ -242,8 +236,6 @@ jobs:
runs-on: ubuntu-latest
needs: [get-pr, browser-vrt, desktop-vrt]
if: ${{ !cancelled() && needs.get-pr.result == 'success' }}
- container:
- image: mcr.microsoft.com/playwright:v1.59.1-jammy
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
diff --git a/upcoming-release-notes/8067.md b/upcoming-release-notes/8067.md
new file mode 100644
index 0000000000..0bcf2623e5
--- /dev/null
+++ b/upcoming-release-notes/8067.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [matt-fidd]
+---
+
+Remove unnecessary playwright container pulls to speed up CI