Skip to content

A local-first personal finance app

🐛 Fix `On budget` / `Off budget` underline with translated languages (#4417)

lelemmbde99b75ae01
diff --git a/packages/desktop-client/src/components/sidebar/Account.tsx b/packages/desktop-client/src/components/sidebar/Account.tsx
index 95cb911f60..0c095ae16e 100644
--- a/packages/desktop-client/src/components/sidebar/Account.tsx
+++ b/packages/desktop-client/src/components/sidebar/Account.tsx
@@ -62,6 +62,7 @@ type AccountProps<FieldName extends SheetFields<'account'>> = {
outerStyle?: CSSProperties;
onDragChange?: OnDragChangeCallback<{ id: string }>;
onDrop?: OnDropCallback;
+ titleAccount?: boolean;
};
export function Account<FieldName extends SheetFields<'account'>>({
@@ -77,6 +78,7 @@ export function Account<FieldName extends SheetFields<'account'>>({
outerStyle,
onDragChange,
onDrop,
+ titleAccount,
}: AccountProps<FieldName>) {
const type = account
? account.closed
@@ -178,7 +180,7 @@ export function Account<FieldName extends SheetFields<'account'>>({
<AlignedText
style={
- (name === 'Off budget' || name === 'On budget') && {
+ titleAccount && {
borderBottom: `1.5px solid rgba(255,255,255,0.4)`,
paddingBottom: '3px',
}
diff --git a/packages/desktop-client/src/components/sidebar/Accounts.tsx b/packages/desktop-client/src/components/sidebar/Accounts.tsx
index 0e46568768..bb6ea8ddf3 100644
--- a/packages/desktop-client/src/components/sidebar/Accounts.tsx
+++ b/packages/desktop-client/src/components/sidebar/Accounts.tsx
@@ -108,6 +108,7 @@ export function Accounts() {
marginTop: 13,
marginBottom: 5,
}}
+ titleAccount={true}
/>
)}
@@ -138,6 +139,7 @@ export function Accounts() {
marginTop: 13,
marginBottom: 5,
}}
+ titleAccount={true}
/>
)}
diff --git a/upcoming-release-notes/4417.md b/upcoming-release-notes/4417.md
new file mode 100644
index 0000000000..275a004e6e
--- /dev/null
+++ b/upcoming-release-notes/4417.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [lelemm]
+---
+
+Fix `On budget` / `Off budget` underline with translated languages