A local-first personal finance app
:recycle: (eslint) disallow importing actual-app/web in loot-core (#4347)
Matiss Janis Aboltinsbe1c194eb4c4
diff --git a/eslint.config.mjs b/eslint.config.mjsindex df7a07adb2..41392b3e28 100644--- a/eslint.config.mjs+++ b/eslint.config.mjs@@ -671,7 +671,6 @@ export default [},{files: ['packages/loot-core/src/**/*'],-rules: {'no-restricted-imports': ['warn',@@ -691,6 +690,10 @@ export default [message:'Please use relative imports in loot-core instead of importing from `loot-core/*`',},+ {+ group: ['@actual-app/web/*'],+ message: 'Please do not import `@actual-app/web` in `loot-core`',+ },],},],diff --git a/packages/loot-core/src/client/actions/prefs.ts b/packages/loot-core/src/client/actions/prefs.tsindex 713c66bd51..a0034b0224 100644--- a/packages/loot-core/src/client/actions/prefs.ts+++ b/packages/loot-core/src/client/actions/prefs.ts@@ -1,3 +1,4 @@+// eslint-disable-next-line no-restricted-imports -- fix me -- do not import @actual-app/web in loot-coreimport { setI18NextLanguage } from '@actual-app/web/src/i18n';import { send } from '../../platform/client/fetch';diff --git a/packages/loot-core/src/client/data-hooks/schedules.tsx b/packages/loot-core/src/client/data-hooks/schedules.tsxindex d6d54e7919..372c96dc54 100644--- a/packages/loot-core/src/client/data-hooks/schedules.tsx+++ b/packages/loot-core/src/client/data-hooks/schedules.tsx@@ -8,6 +8,7 @@ import React, {useState,} from 'react';+// eslint-disable-next-line no-restricted-imports -- fix me -- do not import @actual-app/web in loot-coreimport { useSyncedPref } from '@actual-app/web/src/hooks/useSyncedPref';import { q, type Query } from '../../shared/query';diff --git a/packages/loot-core/src/client/data-hooks/transactions.ts b/packages/loot-core/src/client/data-hooks/transactions.tsindex b1aff56721..4bf415e816 100644--- a/packages/loot-core/src/client/data-hooks/transactions.ts+++ b/packages/loot-core/src/client/data-hooks/transactions.ts@@ -1,5 +1,6 @@import { useEffect, useRef, useState, useMemo, useCallback } from 'react';+// eslint-disable-next-line no-restricted-imports -- fix me -- do not import @actual-app/web in loot-coreimport { useSyncedPref } from '@actual-app/web/src/hooks/useSyncedPref';import * as d from 'date-fns';import debounce from 'lodash/debounce';diff --git a/upcoming-release-notes/4347.md b/upcoming-release-notes/4347.mdnew file mode 100644index 0000000000..f1bc0c6b1c--- /dev/null+++ b/upcoming-release-notes/4347.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Disallow importing `@actual-app/web` in `loot-core` - circular dependencies.