A local-first personal finance app
Fix icon hover effect in transaction table (#4070)
Julian Dominguez-Schatzbe5bfa275ef3
diff --git a/packages/desktop-client/e2e/schedules.test.js b/packages/desktop-client/e2e/schedules.test.jsindex cc8e374365..d5147a82da 100644--- a/packages/desktop-client/e2e/schedules.test.js+++ b/packages/desktop-client/e2e/schedules.test.js@@ -58,6 +58,10 @@ test.describe('Schedules', () => {await expect(transaction.debit).toHaveText('25.00');await expect(transaction.credit).toHaveText('');+ const icon = transaction.payee.getByTestId('schedule-icon');+ await icon.hover();+ await expect(page).toMatchThemeScreenshots();+// go to rules pageconst rulesPage = await navigation.goToRulesPage();await rulesPage.searchFor('Home Depot');diff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.pngindex 4f1d5f1979..0480605248 100644Binary files a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.pngindex e3116aaead..575d7a0e5c 100644Binary files a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.pngindex 927394477a..0aac59ceeb 100644Binary files a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.pngnew file mode 100644index 0000000000..4f8931b69aBinary files /dev/null and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.pngnew file mode 100644index 0000000000..e3116aaeadBinary files /dev/null and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.pngnew file mode 100644index 0000000000..5d5682c3adBinary files /dev/null and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.pngindex 1414d624b1..a3767e0543 100644Binary files a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.pngindex 6a43aa588b..6ea0152dfd 100644Binary files a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.pngindex 3aa8de5ec1..0ea4bd7b7d 100644Binary files a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png differdiff --git a/packages/desktop-client/src/components/transactions/TransactionsTable.jsx b/packages/desktop-client/src/components/transactions/TransactionsTable.jsxindex f6b247902d..adcdaa7067 100644--- a/packages/desktop-client/src/components/transactions/TransactionsTable.jsx+++ b/packages/desktop-client/src/components/transactions/TransactionsTable.jsx@@ -699,40 +699,42 @@ function PayeeCell({);return (- <div- style={{- overflow: 'hidden',- textOverflow: 'ellipsis',- display: 'flex',- alignItems: 'center',- }}- >+ <><PayeeIconstransaction={transaction}transferAccount={transferAccount}onNavigateToTransferAccount={onNavigateToTransferAccount}onNavigateToSchedule={onNavigateToSchedule}/>- {importedPayee ? (- <Tooltip- content={- <View style={{ padding: 10 }}>- <Text style={{ fontWeight: 'bold' }}>Imported Payee</Text>- <Text style={{ fontWeight: 'normal' }}>- {importedPayee}- </Text>- </View>- }- style={{ ...styles.tooltip, borderRadius: '0px 5px 5px 0px' }}- placement="bottom"- triggerProps={{ delay: 750 }}- >- {payeeName}- </Tooltip>- ) : (- payeeName- )}- </div>+ <div+ style={{+ overflow: 'hidden',+ textOverflow: 'ellipsis',+ display: 'flex',+ alignItems: 'center',+ }}+ >+ {importedPayee ? (+ <Tooltip+ content={+ <View style={{ padding: 10 }}>+ <Text style={{ fontWeight: 'bold' }}>Imported Payee</Text>+ <Text style={{ fontWeight: 'normal' }}>+ {importedPayee}+ </Text>+ </View>+ }+ style={{ ...styles.tooltip, borderRadius: '0px 5px 5px 0px' }}+ placement="bottom"+ triggerProps={{ delay: 750 }}+ >+ {payeeName}+ </Tooltip>+ ) : (+ payeeName+ )}+ </div>+ </>);}}>@@ -804,6 +806,7 @@ function PayeeIcons({{schedule && (<Buttonvariant="bare"+ data-testid="schedule-icon"aria-label="See schedule details"style={payeeIconButtonStyle}onPress={() => {@@ -820,6 +823,7 @@ function PayeeIcons({{transferAccount && (<Buttonvariant="bare"+ data-testid="transfer-icon"aria-label="See transfer account"style={payeeIconButtonStyle}onPress={() => {diff --git a/upcoming-release-notes/4070.md b/upcoming-release-notes/4070.mdnew file mode 100644index 0000000000..ec84ab397e--- /dev/null+++ b/upcoming-release-notes/4070.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [jfdoming]+---++Fix regression in hover effect for icons