Skip to content

A local-first personal finance app

Fix react-hooks/exhaustive-deps error on Titlebar.tsx (#4273)

Joel Jeremy Marquezbf72a26e5c2f
diff --git a/eslint.config.mjs b/eslint.config.mjs
index 5e2136d966..c7cac6e8af 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -791,10 +791,6 @@ export default [
'packages/desktop-client/src/components/sort.tsx',
'packages/desktop-client/src/components/spreadsheet/useSheetValue.ts',
'packages/desktop-client/src/components/table.tsx',
- 'packages/desktop-client/src/components/Titlebar.tsx',
- 'packages/desktop-client/src/components/transactions/MobileTransaction.jsx',
- 'packages/desktop-client/src/components/transactions/SelectedTransactions.jsx',
- 'packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx',
'packages/desktop-client/src/components/transactions/TransactionList.jsx',
'packages/desktop-client/src/components/transactions/TransactionsTable.jsx',
'packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx',
diff --git a/packages/desktop-client/src/components/Titlebar.tsx b/packages/desktop-client/src/components/Titlebar.tsx
index f8e630935c..ebddb91132 100644
--- a/packages/desktop-client/src/components/Titlebar.tsx
+++ b/packages/desktop-client/src/components/Titlebar.tsx
@@ -148,7 +148,7 @@ function SyncButton({ style, isMobile = false }: SyncButtonProps) {
});
return unlisten;
- }, []);
+ }, [cloudFileId]);
const mobileColor =
syncState === 'error'
diff --git a/upcoming-release-notes/4273.md b/upcoming-release-notes/4273.md
new file mode 100644
index 0000000000..179d7948c5
--- /dev/null
+++ b/upcoming-release-notes/4273.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [joel-jeremy]
+---
+
+Fix react-hooks/exhaustive-deps error on Titlebar.tsx