A local-first personal finance app
Fix budget type toggle not working the first time (#3169)
Yusef Oudac3c6acd37cb1
diff --git a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsxindex 24612aa832..067bf43eeb 100644--- a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx+++ b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx@@ -375,7 +375,7 @@ function CategoryItem({borderTop: `1px solid ${theme.pillBorder}`,}: {};- const [budgetType] = useLocalPref('budgetType');+ const [budgetType = 'rollover'] = useLocalPref('budgetType');const balance = useSheetValue(budgetType === 'rollover'diff --git a/packages/desktop-client/src/components/budget/index.tsx b/packages/desktop-client/src/components/budget/index.tsxindex 16c0211dbd..9f41747400 100644--- a/packages/desktop-client/src/components/budget/index.tsx+++ b/packages/desktop-client/src/components/budget/index.tsx@@ -75,8 +75,7 @@ function BudgetInner(props: BudgetInnerProps) {start: startMonth,end: startMonth,});- const [budgetTypePref] = useLocalPref('budgetType');- const budgetType = budgetTypePref || 'rollover';+ const [budgetType = 'rollover'] = useLocalPref('budgetType');const [maxMonthsPref] = useGlobalPref('maxMonths');const maxMonths = maxMonthsPref || 1;const [initialized, setInitialized] = useState(false);diff --git a/packages/desktop-client/src/components/mobile/budget/index.tsx b/packages/desktop-client/src/components/mobile/budget/index.tsxindex 91e8461150..3fa93d7c40 100644--- a/packages/desktop-client/src/components/mobile/budget/index.tsx+++ b/packages/desktop-client/src/components/mobile/budget/index.tsx@@ -461,8 +461,7 @@ function BudgetInner(props: BudgetInnerProps) {export function Budget() {const { list: categories, grouped: categoryGroups } = useCategories();- const [_budgetType] = useLocalPref('budgetType');- const budgetType = _budgetType || 'rollover';+ const [budgetType = 'rollover'] = useLocalPref('budgetType');const spreadsheet = useSpreadsheet();useSetThemeColor(theme.mobileViewTheme);return (diff --git a/packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx b/packages/desktop-client/src/components/settings/BudgetTypeSettings.tsxindex e98d0ea3a5..9fbb26da28 100644--- a/packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx+++ b/packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx@@ -15,7 +15,7 @@ import { Setting } from './UI';export function BudgetTypeSettings() {const dispatch = useDispatch();- const [budgetType] = useLocalPref('budgetType');+ const [budgetType = 'rollover'] = useLocalPref('budgetType');const [loading, setLoading] = useState(false);const currentMonth = monthUtils.currentMonth();diff --git a/packages/desktop-client/src/components/settings/Experimental.tsx b/packages/desktop-client/src/components/settings/Experimental.tsxindex 79cc91ccb1..0cd2da8383 100644--- a/packages/desktop-client/src/components/settings/Experimental.tsx+++ b/packages/desktop-client/src/components/settings/Experimental.tsx@@ -57,7 +57,7 @@ function FeatureToggle({}function ReportBudgetFeature() {- const [budgetType] = useLocalPref('budgetType');+ const [budgetType = 'rollover'] = useLocalPref('budgetType');const enabled = useFeatureFlag('reportBudget');const blockToggleOff = budgetType === 'report' && enabled;return (diff --git a/upcoming-release-notes/3169.md b/upcoming-release-notes/3169.mdnew file mode 100644index 0000000000..be8369f8bb--- /dev/null+++ b/upcoming-release-notes/3169.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [YusefOuda]+---++Fix budget type toggle not working the first time