Skip to content

A local-first personal finance app

Fix failure to create category with deleted name (#2002)

Kyle Mckayc4ff099f26b8
diff --git a/packages/loot-core/src/server/db/index.test.ts b/packages/loot-core/src/server/db/index.test.ts
index 6083445626..007269d56f 100644
--- a/packages/loot-core/src/server/db/index.test.ts
+++ b/packages/loot-core/src/server/db/index.test.ts
@@ -38,6 +38,21 @@ describe('Database', () => {
expect((await db.getCategories()).length).toBe(1);
});
+ test('using a deleted category name works', async () => {
+ await db.insertCategoryGroup({ id: 'group1', name: 'group1' });
+ const id = await db.insertCategory({
+ name: 'foo',
+ cat_group: 'group1',
+ });
+ await db.deleteCategory({ id });
+ expect((await db.getCategories()).length).toBe(0);
+ await db.insertCategory({
+ name: 'foo',
+ cat_group: 'group1',
+ });
+ expect((await db.getCategories()).length).toBe(1);
+ });
+
test('transactions are sorted by date', async () => {
await insertTransactions([
{ date: '2018-01-05', account: 'foo', amount: -23 },
diff --git a/packages/loot-core/src/server/db/index.ts b/packages/loot-core/src/server/db/index.ts
index 9b152daf85..8ed8f81176 100644
--- a/packages/loot-core/src/server/db/index.ts
+++ b/packages/loot-core/src/server/db/index.ts
@@ -348,7 +348,7 @@ export async function insertCategory(
await batchMessages(async () => {
// Dont allow duplicated names in groups
const existingCatInGroup = await first(
- `SELECT id FROM categories WHERE cat_group = ? and UPPER(name) = ? LIMIT 1`,
+ `SELECT id FROM categories WHERE cat_group = ? and UPPER(name) = ? and tombstone = 0 LIMIT 1`,
[category.cat_group, category.name.toUpperCase()],
);
if (existingCatInGroup) {
diff --git a/upcoming-release-notes/2002.md b/upcoming-release-notes/2002.md
new file mode 100644
index 0000000000..de2fc7cba3
--- /dev/null
+++ b/upcoming-release-notes/2002.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [kymckay]
+---
+
+Prevent deleted categories blocking creation of new categories with the same name.