A local-first personal finance app
(nordigen) Include hashed IBAN in get-accounts and transactions endpoints (#166)
Jakub Kuczysc8a901d3ff69
diff --git a/src/app-nordigen/app-nordigen.js b/src/app-nordigen/app-nordigen.jsindex 2c82a20f49..7d06fe48e9 100644--- a/src/app-nordigen/app-nordigen.js+++ b/src/app-nordigen/app-nordigen.js@@ -8,6 +8,7 @@ import {GenericNordigenError,} from './errors.js';import { handleError } from './util/handle-error.js';+import { sha256String } from '../util/hash.js';import validateUser from '../util/validate-user.js';const app = express();@@ -69,7 +70,13 @@ app.post(status: 'ok',data: {...requisition,- accounts,+ accounts: await Promise.all(+ accounts.map(async (account) =>+ account?.iban+ ? { ...account, iban: await sha256String(account.iban) }+ : account,+ ),+ ),},});} catch (error) {@@ -138,6 +145,7 @@ app.post(try {const {+ iban,balances,institutionId,startingBalance,@@ -152,6 +160,7 @@ app.post(res.send({status: 'ok',data: {+ iban: iban ? await sha256String(iban) : null,balances,institutionId,startingBalance,diff --git a/src/app-nordigen/banks/ing-pl-ingbplpw.js b/src/app-nordigen/banks/ing-pl-ingbplpw.jsindex a377e79d15..511594280c 100644--- a/src/app-nordigen/banks/ing-pl-ingbplpw.js+++ b/src/app-nordigen/banks/ing-pl-ingbplpw.js@@ -9,6 +9,7 @@ export default {account_id: account.id,institution: account.institution,mask: account.iban.slice(-4),+ iban: account.iban,name: [account.product, printIban(account)].join(' ').trim(),official_name: account.product,type: 'checking',diff --git a/src/app-nordigen/banks/integration-bank.js b/src/app-nordigen/banks/integration-bank.jsindex 4156aa0af1..8849b735cf 100644--- a/src/app-nordigen/banks/integration-bank.js+++ b/src/app-nordigen/banks/integration-bank.js@@ -23,6 +23,7 @@ export default {account_id: account.id,institution: account.institution,mask: (account?.iban || '0000').slice(-4),+ iban: account?.iban || null,name: [account.name, printIban(account), account.currency].filter(Boolean).join(' '),diff --git a/src/app-nordigen/banks/mbank-retail-brexplpw.js b/src/app-nordigen/banks/mbank-retail-brexplpw.jsindex ddf1223dc0..1639b42540 100644--- a/src/app-nordigen/banks/mbank-retail-brexplpw.js+++ b/src/app-nordigen/banks/mbank-retail-brexplpw.js@@ -9,6 +9,7 @@ export default {account_id: account.id,institution: account.institution,mask: account.iban.slice(-4),+ iban: account.iban,name: [account.displayName, printIban(account)].join(' '),official_name: account.product,type: 'checking',diff --git a/src/app-nordigen/banks/sandboxfinance-sfin0000.js b/src/app-nordigen/banks/sandboxfinance-sfin0000.jsindex 5f4dbb238b..d6e0d41c44 100644--- a/src/app-nordigen/banks/sandboxfinance-sfin0000.js+++ b/src/app-nordigen/banks/sandboxfinance-sfin0000.js@@ -9,6 +9,7 @@ export default {account_id: account.id,institution: account.institution,mask: account.iban.slice(-4),+ iban: account.iban,name: [account.name, printIban(account)].join(' '),official_name: account.product,type: 'checking',diff --git a/src/app-nordigen/banks/tests/ing-pl-ingbplpw.spec.js b/src/app-nordigen/banks/tests/ing-pl-ingbplpw.spec.jsindex ac978d9734..eb60d8b7da 100644--- a/src/app-nordigen/banks/tests/ing-pl-ingbplpw.spec.js+++ b/src/app-nordigen/banks/tests/ing-pl-ingbplpw.spec.js@@ -45,6 +45,7 @@ describe('IngPlIngbplpw', () => {expect(normalizedAccount).toMatchInlineSnapshot(`{"account_id": "d3eccc94-9536-48d3-98be-813f79199ee3",+ "iban": "PL00000000000000000987654321","institution": {"bic": "INGBPLPW","countries": [diff --git a/src/app-nordigen/banks/tests/integration-bank.spec.js b/src/app-nordigen/banks/tests/integration-bank.spec.jsindex fc708e47fc..17c97f3bb2 100644--- a/src/app-nordigen/banks/tests/integration-bank.spec.js+++ b/src/app-nordigen/banks/tests/integration-bank.spec.js@@ -21,6 +21,7 @@ describe('IntegrationBank', () => {account_id: account.id,institution: mockInstitution,mask: '4321',+ iban: account.iban,name: 'account-example-one (XXX 4321) PLN',official_name: 'integration-SANDBOXFINANCE_SFIN0000',type: 'checking',@@ -36,6 +37,7 @@ describe('IntegrationBank', () => {account_id: account.id,institution: mockInstitution,mask: '0000',+ iban: null,name: 'account-example-one PLN',official_name: 'integration-SANDBOXFINANCE_SFIN0000',type: 'checking',diff --git a/src/app-nordigen/banks/tests/mbank-retail-brexplpw.spec.js b/src/app-nordigen/banks/tests/mbank-retail-brexplpw.spec.jsindex a960980705..f14dba2e88 100644--- a/src/app-nordigen/banks/tests/mbank-retail-brexplpw.spec.js+++ b/src/app-nordigen/banks/tests/mbank-retail-brexplpw.spec.js@@ -44,6 +44,7 @@ describe('MbankRetailBrexplpw', () => {.toMatchInlineSnapshot(`{"account_id": "d3eccc94-9536-48d3-98be-813f79199ee3",+ "iban": "PL00000000000000000987654321","institution": {"bic": "BREXPLPW","countries": [diff --git a/src/app-nordigen/banks/tests/sandboxfinance-sfin0000.spec.js b/src/app-nordigen/banks/tests/sandboxfinance-sfin0000.spec.jsindex 5b1c8a384b..ce610df6d8 100644--- a/src/app-nordigen/banks/tests/sandboxfinance-sfin0000.spec.js+++ b/src/app-nordigen/banks/tests/sandboxfinance-sfin0000.spec.js@@ -35,6 +35,7 @@ describe('SandboxfinanceSfin0000', () => {.toMatchInlineSnapshot(`{"account_id": "99a0bfe2-0bef-46df-bff2-e9ae0c6c5838",+ "iban": "GL0865354374424724","institution": {"bic": "SFIN0000","countries": [diff --git a/src/app-nordigen/nordigen.types.ts b/src/app-nordigen/nordigen.types.tsindex 2d2d9051ab..2d76d9fcd8 100644--- a/src/app-nordigen/nordigen.types.ts+++ b/src/app-nordigen/nordigen.types.ts@@ -28,6 +28,11 @@ export type NormalizedAccountDetails = {*/mask: string;+ /**+ * the account iban+ */+ iban: string;+/*** Name displayed on the UI of Actual app*/diff --git a/src/app-nordigen/services/nordigen-service.js b/src/app-nordigen/services/nordigen-service.jsindex 63be7f37be..ccfbdafacb 100644--- a/src/app-nordigen/services/nordigen-service.js+++ b/src/app-nordigen/services/nordigen-service.js@@ -170,7 +170,7 @@ export const nordigenService = {* @throws {RateLimitError}* @throws {UnknownError}* @throws {ServiceError}- * @returns {Promise<{balances: Array<import('../nordigen-node.types.js').Balance>, institutionId: string, transactions: {booked: Array<import('../nordigen-node.types.js').Transaction>, pending: Array<import('../nordigen-node.types.js').Transaction>}, startingBalance: number}>}+ * @returns {Promise<{iban: string, balances: Array<import('../nordigen-node.types.js').Balance>, institutionId: string, transactions: {booked: Array<import('../nordigen-node.types.js').Transaction>, pending: Array<import('../nordigen-node.types.js').Transaction>}, startingBalance: number}>}*/getTransactionsWithBalance: async (requisitionId,@@ -185,7 +185,8 @@ export const nordigenService = {throw new AccountNotLinedToRequisition(accountId, requisitionId);}- const [transactions, accountBalance] = await Promise.all([+ const [accountMetadata, transactions, accountBalance] = await Promise.all([+ nordigenService.getAccountMetadata(accountId),nordigenService.getTransactions({accountId,startDate,@@ -208,6 +209,7 @@ export const nordigenService = {);return {+ iban: accountMetadata.iban,balances: accountBalance.balances,institutionId: institution_id,startingBalance,@@ -321,6 +323,22 @@ export const nordigenService = {};},+ /**+ * Retrieve account metadata by account id+ *+ * Unlike getDetailedAccount, this method is not affected by institution rate-limits.+ *+ * @param accountId+ * @returns {Promise<import('../nordigen-node.types.js').NordigenAccountMetadata>}+ */+ getAccountMetadata: async (accountId) => {+ const response = await client.getMetadata(accountId);++ handleNordigenError(response);++ return response;+ },+/*** Retrieve details about all Institutions in a specific country* @param countrydiff --git a/src/app-nordigen/services/tests/nordigen-service.spec.js b/src/app-nordigen/services/tests/nordigen-service.spec.jsindex a8a7965333..5f26a8f5e6 100644--- a/src/app-nordigen/services/tests/nordigen-service.spec.js+++ b/src/app-nordigen/services/tests/nordigen-service.spec.js@@ -149,6 +149,9 @@ describe('nordigenService', () => {jest.spyOn(nordigenService, 'getLinkedRequisition').mockResolvedValue(mockRequisition);+ jest+ .spyOn(nordigenService, 'getAccountMetadata')+ .mockResolvedValue(mockAccountMetaData);jest.spyOn(nordigenService, 'getTransactions').mockResolvedValue(mockTransactions);@@ -165,6 +168,7 @@ describe('nordigenService', () => {),).toEqual(expect.objectContaining({+ iban: mockAccountMetaData.iban,balances: mockedBalances.balances,institutionId: mockRequisition.institution_id,startingBalance: expect.any(Number),diff --git a/src/util/hash.js b/src/util/hash.jsnew file mode 100644index 0000000000..e8f14f3e4e--- /dev/null+++ b/src/util/hash.js@@ -0,0 +1,5 @@+import crypto from 'crypto';++export async function sha256String(str) {+ return crypto.createHash('sha256').update(str).digest('base64');+}diff --git a/upcoming-release-notes/166.md b/upcoming-release-notes/166.mdnew file mode 100644index 0000000000..36f4768c79--- /dev/null+++ b/upcoming-release-notes/166.md@@ -0,0 +1,6 @@+---+category: Enhancements+authors: [Jackenmen]+---++Expose sha256 hashes of account IBANs in Nordigen get-accounts and transactions endpoints