Skip to content

A local-first personal finance app

Fix crash when undoing a rule application (#1885)

Julian Dominguez-Schatzcd6bd9ece8b5
diff --git a/packages/desktop-client/src/components/ManageRules.tsx b/packages/desktop-client/src/components/ManageRules.tsx
index 5a3ddad2b7..1d6ea7d0a7 100644
--- a/packages/desktop-client/src/components/ManageRules.tsx
+++ b/packages/desktop-client/src/components/ManageRules.tsx
@@ -154,7 +154,9 @@ function ManageRulesContent({
await dispatch(initiallyLoadPayees());
}
- undo.setUndoState('openModal', 'manage-rules');
+ if (payeeId) {
+ undo.setUndoState('openModal', 'manage-rules');
+ }
loadData();
diff --git a/packages/desktop-client/src/components/Modals.tsx b/packages/desktop-client/src/components/Modals.tsx
index e2e201169a..e47d026b13 100644
--- a/packages/desktop-client/src/components/Modals.tsx
+++ b/packages/desktop-client/src/components/Modals.tsx
@@ -139,7 +139,7 @@ export default function Modals() {
return (
<ManageRulesModal
modalProps={modalProps}
- payeeId={options.payeeId}
+ payeeId={options?.payeeId}
/>
);
diff --git a/upcoming-release-notes/1885.md b/upcoming-release-notes/1885.md
new file mode 100644
index 0000000000..d389d8bf1d
--- /dev/null
+++ b/upcoming-release-notes/1885.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [jfdoming]
+---
+
+Fix crash when hitting undo after applying a rule to some transactions