Skip to content

A local-first personal finance app

fix: csv import deduplication (#3456)

Koen van Staverend0ba623cfa2b
diff --git a/packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx b/packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx
index 44851ca7ae..00ffdc971e 100644
--- a/packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx
+++ b/packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx
@@ -1,6 +1,7 @@
import React, { useState, useEffect, useMemo, useCallback } from 'react';
import * as d from 'date-fns';
+import deepEqual from 'deep-equal';
import { format as formatDate_ } from 'loot-core/src/shared/months';
import {
@@ -922,8 +923,8 @@ export function ImportTransactionsModal({ options }) {
);
break;
}
- if (trans.payee == null || !(trans.payee instanceof String)) {
- console.log(`Unable·to·parse·payee·${trans.payee || '(empty)'}`);
+ if (trans.payee_name == null || typeof trans.payee_name !== 'string') {
+ console.log(`Unable·to·parse·payee·${trans.payee_name || '(empty)'}`);
break;
}
@@ -1379,7 +1380,10 @@ export function ImportTransactionsModal({ options }) {
outValue,
multiplierAmount,
);
- setTransactions(transactionPreview);
+
+ if (!deepEqual(transactions, transactionPreview)) {
+ setTransactions(transactionPreview);
+ }
}, [
getImportPreview,
transactions,
diff --git a/upcoming-release-notes/3456.md b/upcoming-release-notes/3456.md
new file mode 100644
index 0000000000..c3ebd318f6
--- /dev/null
+++ b/upcoming-release-notes/3456.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [UnderKoen]
+---
+
+Fix csv import deduplication #3416