Skip to content

A local-first personal finance app

[Bug] Goals: Fix schedules 'in between' calculation (#1753)

shall0passd3ab8f9812bf
diff --git a/packages/loot-core/src/server/budget/goaltemplates.ts b/packages/loot-core/src/server/budget/goaltemplates.ts
index c07557a05d..c23d3f7eb1 100644
--- a/packages/loot-core/src/server/budget/goaltemplates.ts
+++ b/packages/loot-core/src/server/budget/goaltemplates.ts
@@ -645,7 +645,12 @@ async function applyCategoryTemplate(
let conditions = rule.serialize().conditions;
let { date: dateConditions, amount: amountCondition } =
extractScheduleConds(conditions);
- let target = -amountCondition.value;
+ let target =
+ amountCondition.op === 'isbetween'
+ ? -Math.round(
+ amountCondition.value.num1 + amountCondition.value.num2,
+ ) / 2
+ : -amountCondition.value;
let next_date_string = getNextDate(
dateConditions,
monthUtils._parse(current_month),
@@ -682,7 +687,7 @@ async function applyCategoryTemplate(
monthUtils._parse(current_month),
);
while (next_date < next_month) {
- monthlyTarget += amountCondition.value;
+ monthlyTarget += -target;
next_date = monthUtils.addDays(next_date, 1);
next_date = getNextDate(
dateConditions,
diff --git a/upcoming-release-notes/1753.md b/upcoming-release-notes/1753.md
new file mode 100644
index 0000000000..0e04fb44e9
--- /dev/null
+++ b/upcoming-release-notes/1753.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [shall0pass]
+---
+
+Goals - Fix schedules 'in between' calculation