Skip to content

A local-first personal finance app

fix: only count failed attempts against auth rate limit (#7707)

Dan Hopkinsd787d0ce434b
diff --git a/packages/sync-server/src/app-account.js b/packages/sync-server/src/app-account.js
index ae065559ab..1f4fb97a83 100644
--- a/packages/sync-server/src/app-account.js
+++ b/packages/sync-server/src/app-account.js
@@ -28,6 +28,7 @@ const authRateLimiter = rateLimit({
max: 5, // 5 attempts per window
legacyHeaders: false,
standardHeaders: true,
+ skipSuccessfulRequests: true,
message: { status: 'error', reason: 'too-many-requests' },
});
diff --git a/upcoming-release-notes/7707.md b/upcoming-release-notes/7707.md
new file mode 100644
index 0000000000..214f657aac
--- /dev/null
+++ b/upcoming-release-notes/7707.md
@@ -0,0 +1,6 @@
+---
+category: Bugfixes
+authors: [danielhopkins]
+---
+
+Count only failed login attempts against the authentication rate limit