Skip to content

A local-first personal finance app

Import Transactions - Persist and set reimport deleted transactions config to true (#7610)

Alec Bakholdindaab7f737ee9
diff --git a/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx b/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx
index 816dc5d9b6..fafa2e4d63 100644
--- a/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx
+++ b/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx
@@ -1,11 +1,11 @@
// @ts-strict-ignore
-import React, { useCallback, useEffect, useEffectEvent, useState } from 'react';
import type {
ComponentProps,
Dispatch,
ReactNode,
SetStateAction,
} from 'react';
+import { useCallback, useEffect, useEffectEvent, useState } from 'react';
import { Trans, useTranslation } from 'react-i18next';
import { Button, ButtonWithLoading } from '@actual-app/components/button';
@@ -39,6 +39,7 @@ import { FieldMappings } from './FieldMappings';
import { InOutOption } from './InOutOption';
import { MultiplierOption } from './MultiplierOption';
import { Transaction } from './Transaction';
+import type { DateFormat, FieldMapping, ImportTransaction } from './utils';
import {
applyFieldMappings,
dateFormats,
@@ -48,7 +49,6 @@ import {
parseDate,
stripCsvImportTransaction,
} from './utils';
-import type { DateFormat, FieldMapping, ImportTransaction } from './utils';
function CheckboxToggle({
id,
@@ -203,7 +203,6 @@ export function ImportTransactionsModal({
const [flipAmount, setFlipAmount] = useState(false);
const [multiplierEnabled, setMultiplierEnabled] = useState(false);
const [reconcile, setReconcile] = useState(true);
- const [reimportDeleted, setReimportDeleted] = useState(false);
const [importNotes, setImportNotes] = useState(true);
// This cannot be set after parsing the file, because changing it
@@ -242,6 +241,9 @@ export function ImportTransactionsModal({
const [camtSwapPayeeAndMemo, setCamtSwapPayeeAndMemo] = useState(
String(prefs[`camt-swap-payee-memo-${accountId}`]) === 'true',
);
+ const [reimportDeleted, setReimportDeleted] = useState(
+ String(prefs[`import-reimport-deleted-${accountId}`] || 'true') === 'true',
+ );
const [parseDateFormat, setParseDateFormat] = useState<DateFormat | null>(
null,
@@ -706,6 +708,10 @@ export function ImportTransactionsModal({
});
}
+ savePrefs({
+ [`import-reimport-deleted-${accountId}`]: String(reimportDeleted),
+ });
+
importTransactions.mutate(
{
accountId,
diff --git a/packages/loot-core/src/types/prefs.ts b/packages/loot-core/src/types/prefs.ts
index de57a7e27a..68d44188ed 100644
--- a/packages/loot-core/src/types/prefs.ts
+++ b/packages/loot-core/src/types/prefs.ts
@@ -34,6 +34,7 @@ export type SyncedPrefs = Partial<
| `hide-reconciled-${string}`
// TODO: pull from src/components/modals/ImportTransactions.js
| `parse-date-${string}-${'csv' | 'qif'}`
+ | `import-reimport-deleted-${string}`
| `csv-mappings-${string}`
| `csv-delimiter-${string}`
| `csv-skip-start-lines-${string}`
diff --git a/upcoming-release-notes/7610.md b/upcoming-release-notes/7610.md
new file mode 100644
index 0000000000..71cfc2dcd8
--- /dev/null
+++ b/upcoming-release-notes/7610.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [alecbakholdin]
+---
+
+Reimport Deleted is now on by default and persisted between imports