Skip to content

A local-first personal finance app

[AI] Don't learn a category rule that a "one of" rule already covers (#9154)

Kristián Valentíndb42f652e0ee
diff --git a/packages/loot-core/src/server/transactions/transaction-rules.test.ts b/packages/loot-core/src/server/transactions/transaction-rules.test.ts
index ff8d5bbdbe..24140248e0 100644
--- a/packages/loot-core/src/server/transactions/transaction-rules.test.ts
+++ b/packages/loot-core/src/server/transactions/transaction-rules.test.ts
@@ -1289,6 +1289,56 @@ describe('Learning categories', () => {
);
});
+ test('does not create a rule if a "one of" rule already sets the category', async () => {
+ await loadData();
+
+ await insertRule({
+ stage: null,
+ conditionsOp: 'and',
+ conditions: [{ op: 'oneOf', field: 'payee', value: ['foo', 'bar'] }],
+ actions: [{ op: 'set', field: 'category', value: 'food' }],
+ });
+
+ const trans = {
+ date: '2016-12-01',
+ account: 'acct',
+ payee: 'foo',
+ category: 'food',
+ };
+ await db.insertTransaction({ ...trans, id: 'one' });
+ await db.insertTransaction({ ...trans, id: 'two' });
+ await db.insertTransaction({ ...trans, id: 'three' });
+ await updateCategoryRules([{ ...trans, id: 'three' }]);
+
+ expect(getRules().length).toBe(1);
+ expect(getRules()[0].conditions[0].op).toBe('oneOf');
+ });
+
+ test('creates a rule if a "one of" rule sets a different category', async () => {
+ await loadData();
+
+ await insertRule({
+ stage: null,
+ conditionsOp: 'and',
+ conditions: [{ op: 'oneOf', field: 'payee', value: ['foo', 'bar'] }],
+ actions: [{ op: 'set', field: 'category', value: 'beer' }],
+ });
+
+ const trans = {
+ date: '2016-12-01',
+ account: 'acct',
+ payee: 'foo',
+ category: 'food',
+ };
+ await db.insertTransaction({ ...trans, id: 'one' });
+ await db.insertTransaction({ ...trans, id: 'two' });
+ await db.insertTransaction({ ...trans, id: 'three' });
+ await updateCategoryRules([{ ...trans, id: 'three' }]);
+
+ expect(getRules().length).toBe(2);
+ expectCategoryRule(getRules()[1], 'food', 'foo');
+ });
+
test('updates rules correctly even if multiple rules exist', async () => {
await loadData();
diff --git a/packages/loot-core/src/server/transactions/transaction-rules.ts b/packages/loot-core/src/server/transactions/transaction-rules.ts
index 0f9a3818b2..15a3786a35 100644
--- a/packages/loot-core/src/server/transactions/transaction-rules.ts
+++ b/packages/loot-core/src/server/transactions/transaction-rules.ts
@@ -1026,8 +1026,14 @@ export async function updateCategoryRules(transactions) {
});
}
}
- } else {
- // No existing rules, so create one
+ } else if (
+ !getOneOfSetterRules(null, 'payee', 'category', {
+ condValue: payeeId,
+ actionValue: category,
+ }).next().value
+ ) {
+ // No existing rules (and no "one of" rule that already sets this
+ // category for the payee), so create one
const newRule = new Rule({
stage: null,
conditionsOp: 'and',
diff --git a/upcoming-release-notes/learn-category-oneof-rule.md b/upcoming-release-notes/learn-category-oneof-rule.md
new file mode 100644
index 0000000000..f447a7afa8
--- /dev/null
+++ b/upcoming-release-notes/learn-category-oneof-rule.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [kikoval]
+---
+
+Stop category learning from creating a rule when a "payee is one of" rule already sets the same category.