A local-first personal finance app
[Mobile] Fix "Category budget has been updated to ..." notification even when the budget was not updated (#4200)
Joel Jeremy Marquezdd2b0a8bd5d2
diff --git a/packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx b/packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsxindex d7c2564b8f..04e466b946 100644--- a/packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx+++ b/packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx@@ -97,9 +97,12 @@ const AmountInput = memo(function AmountInput({};const onUpdate = (value: string) => {- props.onUpdate?.(value);+ const originalAmount = Math.abs(props.value);const amount = applyText();- props.onUpdateAmount?.(amount);+ if (amount !== originalAmount) {+ props.onUpdate?.(value);+ props.onUpdateAmount?.(amount);+ }};const onBlur: HTMLProps<HTMLInputElement>['onBlur'] = e => {diff --git a/packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx b/packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsxindex e8ee25930c..2c8fc8b856 100644--- a/packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx+++ b/packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx@@ -584,11 +584,9 @@ const TransactionEditInner = memo(function TransactionEditInner({value => {if (transaction.amount !== value) {onUpdateInner(transaction, 'amount', value.toString());- } else {- onClearActiveEdit();}},- [onClearActiveEdit, onUpdateInner, transaction],+ [onUpdateInner, transaction],);const onEditFieldInner = useCallback(@@ -788,6 +786,7 @@ const TransactionEditInner = memo(function TransactionEditInner({zeroSign="-"focused={totalAmountFocused}onFocus={onTotalAmountEdit}+ onBlur={onClearActiveEdit}onUpdateAmount={onTotalAmountUpdate}focusedStyle={{width: 'auto',diff --git a/upcoming-release-notes/4200.md b/upcoming-release-notes/4200.mdnew file mode 100644index 0000000000..b5975ad3f3--- /dev/null+++ b/upcoming-release-notes/4200.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [joel-jeremy]+---++Fix FocusableAmountInput's onUpdate to only fire when amount was updated