Skip to content

A local-first personal finance app

[AI] Add ErrorBoundary around dashboard widgets (#7382)

Matiss Janis Aboltinse0772e24cd62
diff --git a/packages/desktop-client/src/components/reports/Overview.tsx b/packages/desktop-client/src/components/reports/Overview.tsx
index 323eb143ef..1fc3f01940 100644
--- a/packages/desktop-client/src/components/reports/Overview.tsx
+++ b/packages/desktop-client/src/components/reports/Overview.tsx
@@ -1,5 +1,6 @@
import { useCallback, useMemo, useState } from 'react';
import { Dialog, DialogTrigger } from 'react-aria-components';
+import { ErrorBoundary } from 'react-error-boundary';
import ReactGridLayout from 'react-grid-layout';
import type { Layout } from 'react-grid-layout';
import { useHotkeys } from 'react-hotkeys-hook';
@@ -34,6 +35,7 @@ import { CrossoverCard } from './reports/CrossoverCard';
import { CustomReportListCards } from './reports/CustomReportListCards';
import { FormulaCard } from './reports/FormulaCard';
import { MarkdownCard } from './reports/MarkdownCard';
+import { MissingReportCard } from './reports/MissingReportCard';
import { NetWorthCard } from './reports/NetWorthCard';
import { SankeyCard } from './reports/SankeyCard';
import './overview.scss';
@@ -770,142 +772,176 @@ export function Overview({ dashboard }: OverviewProps) {
return (
<div key={item.i}>
- {widget.type === 'net-worth-card' ? (
- <NetWorthCard
- widgetId={item.i}
- isEditing={isEditing}
- accounts={accounts}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'crossover-card' &&
- crossoverReportEnabled ? (
- <CrossoverCard
- widgetId={item.i}
- isEditing={isEditing}
- accounts={accounts}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'age-of-money-card' &&
- ageOfMoneyReportEnabled ? (
- <AgeOfMoneyCard
- widgetId={item.i}
- isEditing={isEditing}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'cash-flow-card' ? (
- <CashFlowCard
- widgetId={item.i}
- isEditing={isEditing}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'spending-card' ? (
- <SpendingCard
- widgetId={item.i}
- isEditing={isEditing}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'budget-analysis-card' &&
- budgetAnalysisReportEnabled ? (
- <BudgetAnalysisCard
- widgetId={item.i}
- isEditing={isEditing}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'markdown-card' ? (
- <MarkdownCard
- isEditing={isEditing}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'custom-report' ? (
- <CustomReportListCards
- isEditing={isEditing}
- report={customReportMap.get(widget.meta.id)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'summary-card' ? (
- <SummaryCard
- widgetId={item.i}
- isEditing={isEditing}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'calendar-card' ? (
- <CalendarCard
- widgetId={item.i}
- isEditing={isEditing}
- meta={widget.meta}
- firstDayOfWeekIdx={firstDayOfWeekIdx}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'formula-card' && formulaMode ? (
- <FormulaCard
- widgetId={item.i}
- isEditing={isEditing}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : widget.type === 'sankey-card' && sankeyFeatureFlag ? (
- <SankeyCard
- widgetId={item.i}
- isEditing={isEditing}
- meta={widget.meta}
- onMetaChange={newMeta => onMetaChange(item, newMeta)}
- onRemove={() => onRemoveWidget(item.i)}
- onCopy={targetDashboardId =>
- onCopyWidget(item.i, targetDashboardId)
- }
- />
- ) : null}
+ <ErrorBoundary
+ fallbackRender={() => (
+ <MissingReportCard
+ isEditing={isEditing}
+ onRemove={() => onRemoveWidget(item.i)}
+ >
+ <Trans>This widget has failed to load.</Trans>
+ </MissingReportCard>
+ )}
+ >
+ {widget.type === 'net-worth-card' ? (
+ <NetWorthCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ accounts={accounts}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'crossover-card' &&
+ crossoverReportEnabled ? (
+ <CrossoverCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ accounts={accounts}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'age-of-money-card' &&
+ ageOfMoneyReportEnabled ? (
+ <AgeOfMoneyCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'cash-flow-card' ? (
+ <CashFlowCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'spending-card' ? (
+ <SpendingCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'budget-analysis-card' &&
+ budgetAnalysisReportEnabled ? (
+ <BudgetAnalysisCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'markdown-card' ? (
+ <MarkdownCard
+ isEditing={isEditing}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'custom-report' ? (
+ <CustomReportListCards
+ isEditing={isEditing}
+ report={customReportMap.get(widget.meta.id)}
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'summary-card' ? (
+ <SummaryCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'calendar-card' ? (
+ <CalendarCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ meta={widget.meta}
+ firstDayOfWeekIdx={firstDayOfWeekIdx}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'formula-card' && formulaMode ? (
+ <FormulaCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : widget.type === 'sankey-card' &&
+ sankeyFeatureFlag ? (
+ <SankeyCard
+ widgetId={item.i}
+ isEditing={isEditing}
+ meta={widget.meta}
+ onMetaChange={newMeta =>
+ onMetaChange(item, newMeta)
+ }
+ onRemove={() => onRemoveWidget(item.i)}
+ onCopy={targetDashboardId =>
+ onCopyWidget(item.i, targetDashboardId)
+ }
+ />
+ ) : null}
+ </ErrorBoundary>
</div>
);
})}
diff --git a/upcoming-release-notes/7382.md b/upcoming-release-notes/7382.md
new file mode 100644
index 0000000000..0f4850b0e3
--- /dev/null
+++ b/upcoming-release-notes/7382.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [MatissJanis]
+---
+
+Add error boundary to dashboard widgets, displaying fallback UI for rendering failures.