A local-first personal finance app
[Typescript migration] Migrate AccountSyncCheck to ts (#3757)
Joel Jeremy Marqueze078ed21bafc
diff --git a/packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx b/packages/desktop-client/src/components/accounts/AccountSyncCheck.tsxsimilarity index 84%rename from packages/desktop-client/src/components/accounts/AccountSyncCheck.jsxrename to packages/desktop-client/src/components/accounts/AccountSyncCheck.tsxindex 29da40e135..04c59a44ac 100644--- a/packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx+++ b/packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx@@ -1,4 +1,4 @@-import React, { useRef, useState } from 'react';+import React, { useCallback, useRef, useState } from 'react';import { Trans } from 'react-i18next';import { useDispatch, useSelector } from 'react-redux';import { useParams } from 'react-router-dom';@@ -6,6 +6,7 @@ import { useParams } from 'react-router-dom';import { t } from 'i18next';import { unlinkAccount } from 'loot-core/client/actions';+import { type AccountEntity } from 'loot-core/types/models';import { authorizeBank } from '../../gocardless';import { useAccounts } from '../../hooks/useAccounts';@@ -16,7 +17,7 @@ import { Link } from '../common/Link';import { Popover } from '../common/Popover';import { View } from '../common/View';-function getErrorMessage(type, code) {+function getErrorMessage(type: string, code: string) {switch (type.toUpperCase()) {case 'ITEM_ERROR':switch (code.toUpperCase()) {@@ -81,7 +82,29 @@ export function AccountSyncCheck() {const [open, setOpen] = useState(false);const triggerRef = useRef(null);- if (!failedAccounts) {+ const reauth = useCallback(+ (acc: AccountEntity) => {+ setOpen(false);++ if (acc.account_id) {+ authorizeBank(dispatch, { upgradingAccountId: acc.account_id });+ }+ },+ [dispatch],+ );++ const unlink = useCallback(+ (acc: AccountEntity) => {+ if (acc.id) {+ dispatch(unlinkAccount(acc.id));+ }++ setOpen(false);+ },+ [dispatch],+ );++ if (!failedAccounts || !id) {return null;}@@ -91,22 +114,15 @@ export function AccountSyncCheck() {}const account = accounts.find(account => account.id === id);+ if (!account) {+ return null;+ }+const { type, code } = error;const showAuth =(type === 'ITEM_ERROR' && code === 'ITEM_LOGIN_REQUIRED') ||(type === 'INVALID_INPUT' && code === 'INVALID_ACCESS_TOKEN');- function reauth() {- setOpen(false);-- authorizeBank(dispatch, { upgradingAccountId: account.account_id });- }-- async function unlink() {- dispatch(unlinkAccount(account.id));- setOpen(false);- }-return (<View><Button@@ -148,20 +164,20 @@ export function AccountSyncCheck() {<View style={{ justifyContent: 'flex-end', flexDirection: 'row' }}>{showAuth ? (<>- <Button onPress={unlink}>+ <Button onPress={() => unlink(account)}><Trans>Unlink</Trans></Button><Buttonvariant="primary"autoFocus- onPress={reauth}+ onPress={() => reauth(account)}style={{ marginLeft: 5 }}><Trans>Reauthorize</Trans></Button></>) : (- <Button onPress={unlink}>+ <Button onPress={() => unlink(account)}><Trans>Unlink account</Trans></Button>)}diff --git a/packages/desktop-client/src/components/budget/util.ts b/packages/desktop-client/src/components/budget/util.tsindex 97a51a08ba..2996e1db68 100644--- a/packages/desktop-client/src/components/budget/util.ts+++ b/packages/desktop-client/src/components/budget/util.ts@@ -60,7 +60,7 @@ export function separateGroups(categoryGroups: CategoryGroupEntity[]) {return [categoryGroups.filter(g => !g.is_income),categoryGroups.find(g => g.is_income),- ];+ ] as const;}export function makeAmountGrey(value: number | string): CSSProperties {diff --git a/upcoming-release-notes/3757.md b/upcoming-release-notes/3757.mdnew file mode 100644index 0000000000..078e427ca1--- /dev/null+++ b/upcoming-release-notes/3757.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [joel-jeremy]+---++Migrate AccountSyncCheck.jsx file to typescript