Skip to content

A local-first personal finance app

fix: Preserve disappearing split payees (in schedules) after posting transactions (#9288)

Alireza Shaerie35036803af3
diff --git a/packages/desktop-client/src/util/schedule-actions.test.ts b/packages/desktop-client/src/util/schedule-actions.test.ts
new file mode 100644
index 0000000000..2398cddc77
--- /dev/null
+++ b/packages/desktop-client/src/util/schedule-actions.test.ts
@@ -0,0 +1,76 @@
+import type { TransactionEntity } from '@actual-app/core/types/models';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+
+import { initServer } from '#mocks/connection';
+import { createSingleTimeScheduleFromTransaction } from '#util/schedule-actions';
+
+vi.mock(
+ '@actual-app/core/platform/client/connection',
+ () => import('#mocks/connection'),
+);
+
+const createSchedule = vi.fn();
+const updateRule = vi.fn();
+
+function makeTransaction(
+ payees: TransactionEntity['payee'][],
+): TransactionEntity {
+ return {
+ id: 'parent',
+ account: 'account',
+ date: '2026-10-25',
+ amount: -1000 * payees.length,
+ payee: 'parent-payee',
+ is_parent: true,
+ subtransactions: payees.map((payee, index) => ({
+ id: `split-${index}`,
+ parent_id: 'parent',
+ is_child: true,
+ account: 'account',
+ date: '2026-10-25',
+ amount: -1000,
+ payee,
+ category: 'category',
+ })),
+ };
+}
+
+describe('createSingleTimeScheduleFromTransaction', () => {
+ beforeEach(() => {
+ createSchedule.mockReset();
+ createSchedule.mockResolvedValue('schedule');
+ updateRule.mockReset();
+
+ initServer({
+ 'schedule/create': createSchedule,
+ query: () => ({ data: [{ rule: 'rule' }] }),
+ 'rule-get': () => ({
+ id: 'rule',
+ conditions: [],
+ actions: [{ op: 'link-schedule', value: 'schedule' }],
+ }),
+ 'rule-update': updateRule,
+ });
+ });
+
+ it.each([
+ ['different payees', ['payee-a', 'payee-b'], ['payee-a', 'payee-b']],
+ ['a blank payee', ['payee-a', null], ['payee-a', null]],
+ ])('preserves %s when creating a schedule', async (_, payees, expected) => {
+ await createSingleTimeScheduleFromTransaction(makeTransaction(payees));
+
+ expect(updateRule).toHaveBeenCalledOnce();
+ expect(updateRule).toHaveBeenCalledWith(
+ expect.objectContaining({
+ actions: expect.arrayContaining(
+ expected.map((payee, index) => ({
+ op: 'set',
+ field: 'payee',
+ value: payee,
+ options: { splitIndex: index + 1 },
+ })),
+ ),
+ }),
+ );
+ });
+});
diff --git a/packages/desktop-client/src/util/schedule-actions.ts b/packages/desktop-client/src/util/schedule-actions.ts
index aa08e9dca7..2e075ead0a 100644
--- a/packages/desktop-client/src/util/schedule-actions.ts
+++ b/packages/desktop-client/src/util/schedule-actions.ts
@@ -63,6 +63,15 @@ export async function createSingleTimeScheduleFromTransaction(
transaction.subtransactions.forEach((split, index) => {
const splitIndex = index + 1;
+ actions.push({
+ op: 'set',
+ field: 'payee',
+ value: split.payee || null,
+ options: {
+ splitIndex,
+ },
+ });
+
if (split.amount != null) {
actions.push({
op: 'set-split-amount',
diff --git a/upcoming-release-notes/preserve-schedule-split-payees.md b/upcoming-release-notes/preserve-schedule-split-payees.md
new file mode 100644
index 0000000000..49c8435413
--- /dev/null
+++ b/upcoming-release-notes/preserve-schedule-split-payees.md
@@ -0,0 +1,6 @@
+---
+category: Bugfixes
+authors: [AlzShaeri]
+---
+
+Preserve disappearing split payees (in schedules) after posting transactions