Skip to content

A local-first personal finance app

Corner case transaction for GoCardLess adapater (ING Romania) (#535)

spideraxale6ed4505b31e
diff --git a/src/app-gocardless/banks/ing-ingbrobu.js b/src/app-gocardless/banks/ing-ingbrobu.js
index bbf39b6f4e..4f90da51c9 100644
--- a/src/app-gocardless/banks/ing-ingbrobu.js
+++ b/src/app-gocardless/banks/ing-ingbrobu.js
@@ -16,9 +16,19 @@ export default {
//For deduplication to work better, payeeName needs to be standardized
//and converted from a pending transaction form ("payeeName":"Card no: xxxxxxxxxxxx1111"') to a booked transaction form ("payeeName":"Card no: Xxxx Xxxx Xxxx 1111")
if (transaction.transactionId === 'NOTPROVIDED') {
+ //Some corner case transactions only have the `proprietaryBankTransactionCode` field, this need to be copied to `remittanceInformationUnstructured`
+ if (
+ transaction.proprietaryBankTransactionCode &&
+ !transaction.remittanceInformationUnstructured
+ ) {
+ transaction.remittanceInformationUnstructured =
+ transaction.proprietaryBankTransactionCode;
+ }
+
if (booked) {
transaction.transactionId = transaction.internalTransactionId;
if (
+ transaction.remittanceInformationUnstructured &&
transaction.remittanceInformationUnstructured
.toLowerCase()
.includes('card no:')
@@ -32,7 +42,9 @@ export default {
}
} else {
transaction.transactionId = null;
+
if (
+ transaction.remittanceInformationUnstructured &&
transaction.remittanceInformationUnstructured
.toLowerCase()
.includes('card no:')
diff --git a/upcoming-release-notes/535.md b/upcoming-release-notes/535.md
new file mode 100644
index 0000000000..95df934300
--- /dev/null
+++ b/upcoming-release-notes/535.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [spideraxal]
+---
+
+Add corner case transaction for ING Bank Romania