Skip to content

A local-first personal finance app

reorganise the SimpleFIN key saving logic (#8362)

Matt Fiddamane891c2e30ed0
diff --git a/packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx b/packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx
index 6ab3a4efba..5528628932 100644
--- a/packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx
+++ b/packages/desktop-client/src/components/modals/SimpleFinInitialiseModal.tsx
@@ -52,6 +52,10 @@ export const SimpleFinInitialiseModal = ({
setIsValid(false);
setError(getSecretsError(error, reason));
} else {
+ await send('secret-set', {
+ name: 'simplefin_accessKey',
+ value: null,
+ });
onSuccess();
}
setIsLoading(false);
diff --git a/packages/sync-server/src/app-secrets.js b/packages/sync-server/src/app-secrets.js
index 0aa370c534..dc9b45551c 100644
--- a/packages/sync-server/src/app-secrets.js
+++ b/packages/sync-server/src/app-secrets.js
@@ -42,16 +42,8 @@ app.post('/', async (req, res) => {
return;
}
- const simplefinTokenChanged =
- name === SecretName.simplefin_token &&
- value !== secretsService.get(SecretName.simplefin_token);
-
secretsService.set(name, value);
- if (simplefinTokenChanged) {
- secretsService.set(SecretName.simplefin_accessKey, null);
- }
-
res.status(200).send({ status: 'ok' });
});
diff --git a/packages/sync-server/src/secrets.test.js b/packages/sync-server/src/secrets.test.js
index 1688ed60df..4197381f90 100644
--- a/packages/sync-server/src/secrets.test.js
+++ b/packages/sync-server/src/secrets.test.js
@@ -101,35 +101,6 @@ describe('secretsService', () => {
});
});
- it('clears the cached SimpleFIN access key when the token changes', async () => {
- secretsService.set(SecretName.simplefin_token, 'old-token');
- secretsService.set(SecretName.simplefin_accessKey, 'cached-access-key');
-
- const res = await request(app)
- .post(`/`)
- .set('x-actual-token', 'valid-token')
- .send({ name: SecretName.simplefin_token, value: 'new-token' });
-
- expect(res.statusCode).toEqual(200);
- expect(secretsService.get(SecretName.simplefin_token)).toBe('new-token');
- expect(secretsService.get(SecretName.simplefin_accessKey)).toBeNull();
- });
-
- it('keeps the SimpleFIN access key when the token is unchanged', async () => {
- secretsService.set(SecretName.simplefin_token, 'same-token');
- secretsService.set(SecretName.simplefin_accessKey, 'cached-access-key');
-
- const res = await request(app)
- .post(`/`)
- .set('x-actual-token', 'valid-token')
- .send({ name: SecretName.simplefin_token, value: 'same-token' });
-
- expect(res.statusCode).toEqual(200);
- expect(secretsService.get(SecretName.simplefin_accessKey)).toBe(
- 'cached-access-key',
- );
- });
-
it('POST returns 400 for unknown secret names', async () => {
const res = await request(app)
.post('/')
diff --git a/upcoming-release-notes/simplefin-secrets-tweak.md b/upcoming-release-notes/simplefin-secrets-tweak.md
new file mode 100644
index 0000000000..db26ae42e5
--- /dev/null
+++ b/upcoming-release-notes/simplefin-secrets-tweak.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [matt-fidd]
+---
+
+Reorganise the SimpleFIN key saving logic