A local-first personal finance app
:bug: (darkmode) fixing lightmode regressions in transaction table (#1530)
Matiss Janis Aboltinsefec507bf8ef
diff --git a/.eslintrc.js b/.eslintrc.jsindex b9f3990117..06c284f01a 100644--- a/.eslintrc.js+++ b/.eslintrc.js@@ -228,6 +228,7 @@ module.exports = {'./packages/desktop-client/src/components/SidebarWithData.*','./packages/desktop-client/src/components/Titlebar.*','./packages/desktop-client/src/components/UpdateNotification.*',+ './packages/desktop-client/src/components/accounts/Header.*','./packages/desktop-client/src/components/alerts.*','./packages/desktop-client/src/components/budget/MobileBudget.*','./packages/desktop-client/src/components/budget/MobileBudgetTable.*',diff --git a/packages/desktop-client/src/components/accounts/Balance.js b/packages/desktop-client/src/components/accounts/Balance.jsindex 04a7a4b350..52971b66e3 100644--- a/packages/desktop-client/src/components/accounts/Balance.js+++ b/packages/desktop-client/src/components/accounts/Balance.js@@ -171,7 +171,7 @@ export function Balances({width: 10,height: 10,marginLeft: 10,- color: 'inherit',+ color: theme.alt2PillText,transform: showExtraBalances ? 'rotateZ(180deg)' : 'rotateZ(0)',}}/>diff --git a/packages/desktop-client/src/components/accounts/Header.js b/packages/desktop-client/src/components/accounts/Header.jsindex e1062f7706..b9376cc07e 100644--- a/packages/desktop-client/src/components/accounts/Header.js+++ b/packages/desktop-client/src/components/accounts/Header.js@@ -7,7 +7,7 @@ import ArrowsExpand3 from '../../icons/v2/ArrowsExpand3';import ArrowsShrink3 from '../../icons/v2/ArrowsShrink3';import DownloadThickBottom from '../../icons/v2/DownloadThickBottom';import Pencil1 from '../../icons/v2/Pencil1';-import { styles } from '../../style';+import { colors, styles } from '../../style';import AnimatedRefresh from '../AnimatedRefresh';import Button from '../common/Button';import InitialFocus from '../common/InitialFocus';@@ -170,7 +170,7 @@ export function AccountHeader({style={{width: 11,height: 11,- color: 'inherit',+ color: colors.n8,}}/></Button>diff --git a/packages/desktop-client/src/components/schedules/StatusBadge.js b/packages/desktop-client/src/components/schedules/StatusBadge.jsindex 5b9d67cd4c..c59447ddbd 100644--- a/packages/desktop-client/src/components/schedules/StatusBadge.js+++ b/packages/desktop-client/src/components/schedules/StatusBadge.js@@ -58,7 +58,7 @@ export function getStatusProps(status) {Icon = CheckCircle1;break;default:- color = colors.n1;+ color = colors.n7;backgroundColor = colors.n11;Icon = CheckCircleHollow;break;diff --git a/packages/desktop-client/src/components/transactions/TransactionsTable.js b/packages/desktop-client/src/components/transactions/TransactionsTable.jsindex db1051708c..10214e326c 100644--- a/packages/desktop-client/src/components/transactions/TransactionsTable.js+++ b/packages/desktop-client/src/components/transactions/TransactionsTable.js@@ -1108,7 +1108,11 @@ const Transaction = memo(function Transaction(props) {: ''}valueStyle={valueStyle}- style={{ fontStyle: 'italic', fontWeight: 300 }}+ style={{+ fontStyle: 'italic',+ color: '#c0c0c0',+ fontWeight: 300,+ }}inputProps={{readOnly: true,style: { fontStyle: 'italic' },diff --git a/packages/desktop-client/src/style/themes/light.ts b/packages/desktop-client/src/style/themes/light.tsindex 860f97b7d2..2c635c4442 100644--- a/packages/desktop-client/src/style/themes/light.ts+++ b/packages/desktop-client/src/style/themes/light.ts@@ -23,7 +23,7 @@ export const cardShadow = colorPalette.navy700;export const tableBackground = colorPalette.white;export const tableRowBackgroundHover = colorPalette.navy50;-export const tableText = colorPalette.navy700;+export const tableText = pageText;export const altTableText = colorPalette.navy400;export const tableTextSelected = colorPalette.navy700;export const tableTextHover = colorPalette.navy900;@@ -129,7 +129,7 @@ export const buttonBareDisabledText = buttonNormalDisabledText;export const buttonBareDisabledBackground = buttonBareBackground;export const noticeBackground = colorPalette.green50;-export const noticeText = colorPalette.green600;+export const noticeText = colorPalette.green500;export const noticeAccent = colorPalette.green200;export const warningBackground = colorPalette.orange200;export const warningText = colorPalette.orange800;diff --git a/upcoming-release-notes/1530.md b/upcoming-release-notes/1530.mdnew file mode 100644index 0000000000..1f0955b597--- /dev/null+++ b/upcoming-release-notes/1530.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [MatissJanis]+---++Fix lightmode regressions introduced with experimental darkmode changes.