A local-first personal finance app
reserved whitespace for bank sync indicator when non-synced accounts … (#7611)
Alec Bakholdinf2f3a5aa6ddb
diff --git a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.pngindex 2ad5a203cc..0b44c0bda5 100644Binary files a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png and b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.pngindex 88a04ae93b..ee6ce1e3a4 100644Binary files a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png and b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.pngindex 2af38ae14c..61f772d58d 100644Binary files a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png and b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png differdiff --git a/packages/desktop-client/src/components/mobile/accounts/AccountsPage.tsx b/packages/desktop-client/src/components/mobile/accounts/AccountsPage.tsxindex a46bc1ea24..3bb9dcff4e 100644--- a/packages/desktop-client/src/components/mobile/accounts/AccountsPage.tsx+++ b/packages/desktop-client/src/components/mobile/accounts/AccountsPage.tsx@@ -1,4 +1,4 @@-import React, { forwardRef, useCallback, useRef } from 'react';+import { forwardRef, useCallback, useRef } from 'react';import type { ComponentPropsWithoutRef, CSSProperties } from 'react';import type { DragItem } from 'react-aria';import {@@ -165,7 +165,7 @@ function AccountListItem({backgroundColor: theme.tableBackground,border: 'none',borderRadius: 0,- paddingLeft: 20,+ paddingLeft: 8,}}data-testid="account-list-item"onPress={() => onSelect(account)}@@ -177,23 +177,21 @@ function AccountListItem({flexDirection: 'row',}}>- {account.bankId ? (- <View- style={{- backgroundColor: isPending- ? theme.sidebarItemBackgroundPending- : isFailed- ? theme.sidebarItemBackgroundFailed- : theme.sidebarItemBackgroundPositive,- marginRight: '8px',- width: 8,- flexShrink: 0,- height: 8,- borderRadius: 8,- opacity: isConnected ? 1 : 0,- }}- />- ) : null}+ <View+ style={{+ backgroundColor: isPending+ ? theme.sidebarItemBackgroundPending+ : isFailed+ ? theme.sidebarItemBackgroundFailed+ : theme.sidebarItemBackgroundPositive,+ marginRight: '6px',+ width: 8,+ flexShrink: 0,+ height: 8,+ borderRadius: 8,+ opacity: isConnected ? 1 : 0,+ }}+ /><TextOneLinestyle={{...styles.text,diff --git a/upcoming-release-notes/7611.md b/upcoming-release-notes/7611.mdnew file mode 100644index 0000000000..974b617a2b--- /dev/null+++ b/upcoming-release-notes/7611.md@@ -0,0 +1,6 @@+---+category: Enhancements+authors: [alecbakholdin]+---++Moved the bank sync indicator on mobile to the right side of the text