A local-first personal finance app
Add typings condition operators for Action class (#1909)
Stefan Hallf970263c7243
diff --git a/packages/loot-core/src/server/accounts/rules.test.ts b/packages/loot-core/src/server/accounts/rules.test.tsindex 432f3c8dca..f4942f1a15 100644--- a/packages/loot-core/src/server/accounts/rules.test.ts+++ b/packages/loot-core/src/server/accounts/rules.test.ts@@ -318,7 +318,7 @@ describe('Action', () => {}).toThrow(/invalid field/i);expect(() => {- new Action('noop', 'name', 'James', null, fieldTypes);+ new Action(null, 'name', 'James', null, fieldTypes);}).toThrow(/invalid action operation/i);});});diff --git a/packages/loot-core/src/server/accounts/rules.ts b/packages/loot-core/src/server/accounts/rules.tsindex 2d09078872..71aab52700 100644--- a/packages/loot-core/src/server/accounts/rules.ts+++ b/packages/loot-core/src/server/accounts/rules.ts@@ -416,17 +416,19 @@ export class Condition {}}-let ACTION_OPS = ['set', 'link-schedule'];+type ActionOperator = 'set' | 'link-schedule';++let ACTION_OPS: ActionOperator[] = ['set', 'link-schedule'];export class Action {field;- op;+ op: ActionOperator;options;rawValue;type;value;- constructor(op, field, value, options, fieldTypes) {+ constructor(op: ActionOperator, field, value, options, fieldTypes) {assert(ACTION_OPS.includes(op),'internal',diff --git a/upcoming-release-notes/1909.md b/upcoming-release-notes/1909.mdnew file mode 100644index 0000000000..10f2c5e536--- /dev/null+++ b/upcoming-release-notes/1909.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [Marethyu1]+---++Type hardening action operator in rules.tsx