A local-first personal finance app
:bug: fix 'delete budget' button always deleting cloud file (#2251)
Matiss Janis Aboltinsfbb1a9647dc3
diff --git a/packages/desktop-client/src/components/manager/DeleteFile.tsx b/packages/desktop-client/src/components/manager/DeleteFile.tsxindex c8dff180cb..29c3875b80 100644--- a/packages/desktop-client/src/components/manager/DeleteFile.tsx+++ b/packages/desktop-client/src/components/manager/DeleteFile.tsx@@ -26,17 +26,6 @@ export function DeleteFile({ modalProps, actions, file }: DeleteFileProps) {null,);- async function onDelete() {- setLoadingState(isCloudFile ? 'cloud' : 'local');- await actions.deleteBudget(- 'id' in file ? file.id : undefined,- isCloudFile ? file.cloudFileId : undefined,- );- setLoadingState(null);-- modalProps.onBack();- }-return (<Modal{...modalProps}@@ -75,7 +64,16 @@ export function DeleteFile({ modalProps, actions, file }: DeleteFileProps) {padding: '10px 30px',fontSize: 14,}}- onClick={onDelete}+ onClick={async () => {+ setLoadingState('cloud');+ await actions.deleteBudget(+ 'id' in file ? file.id : undefined,+ file.cloudFileId,+ );+ setLoadingState(null);++ modalProps.onBack();+ }}>Delete file from all devices</ButtonWithLoading>@@ -125,7 +123,13 @@ export function DeleteFile({ modalProps, actions, file }: DeleteFileProps) {backgroundColor: theme.errorText,}),}}- onClick={onDelete}+ onClick={async () => {+ setLoadingState('local');+ await actions.deleteBudget(file.id);+ setLoadingState(null);++ modalProps.onBack();+ }}>Delete file locally</ButtonWithLoading>diff --git a/upcoming-release-notes/2251.md b/upcoming-release-notes/2251.mdnew file mode 100644index 0000000000..145d3e7302--- /dev/null+++ b/upcoming-release-notes/2251.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [MatissJanis]+---++Fix 'delete file' button always deleting the cloud file.