Skip to content

A local-first personal finance app

[AI] Use fixed version for Playwright tests (#7965)

Matiss Janis Aboltinsff4d880313f2
diff --git a/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-4-chromium-linux.png b/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-4-chromium-linux.png
index 9534a06583..eed731ddce 100644
Binary files a/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-4-chromium-linux.png and b/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-4-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-5-chromium-linux.png b/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-5-chromium-linux.png
index 1eed8741b0..c25e5340a5 100644
Binary files a/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-5-chromium-linux.png and b/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-5-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-6-chromium-linux.png b/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-6-chromium-linux.png
index 10b8cffec8..5f608b35f8 100644
Binary files a/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-6-chromium-linux.png and b/packages/desktop-client/e2e/onboarding.test.ts-snapshots/Onboarding-checks-the-page-visuals-6-chromium-linux.png differ
diff --git a/packages/desktop-client/src/components/ServerContext.tsx b/packages/desktop-client/src/components/ServerContext.tsx
index cb47cb2b07..9e669f7dde 100644
--- a/packages/desktop-client/src/components/ServerContext.tsx
+++ b/packages/desktop-client/src/components/ServerContext.tsx
@@ -8,6 +8,7 @@ import React, {
import type { ReactNode } from 'react';
import { send } from '@actual-app/core/platform/client/connection';
+import * as Platform from '@actual-app/core/shared/platform';
import type { Handlers } from '@actual-app/core/types/handlers';
import { t } from 'i18next';
@@ -73,6 +74,9 @@ export const useAvailableLoginMethods = () =>
useContext(ServerContext).availableLoginMethods;
async function getServerVersion() {
+ if (Platform.isPlaywright) {
+ return '99.9.9';
+ }
const result = await send('get-server-version');
if ('version' in result) {
return result.version;
diff --git a/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-checks-the-page-visuals-1-linux.png b/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-checks-the-page-visuals-1-linux.png
index 3604ab5a72..96a89b187c 100644
Binary files a/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-checks-the-page-visuals-1-linux.png and b/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-checks-the-page-visuals-1-linux.png differ
diff --git a/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-checks-the-page-visuals-2-linux.png b/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-checks-the-page-visuals-2-linux.png
index ea3fbde8bb..6aba77183d 100644
Binary files a/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-checks-the-page-visuals-2-linux.png and b/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-checks-the-page-visuals-2-linux.png differ
diff --git a/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-starts-the-sync-server-and-navigates-to-bootstrap-page-1-linux.png b/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-starts-the-sync-server-and-navigates-to-bootstrap-page-1-linux.png
index 9a18bf4870..467e3a0f2d 100644
Binary files a/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-starts-the-sync-server-and-navigates-to-bootstrap-page-1-linux.png and b/packages/desktop-electron/e2e/__screenshots__/onboarding.test.ts/Onboarding-starts-the-sync-server-and-navigates-to-bootstrap-page-1-linux.png differ
diff --git a/packages/desktop-electron/index.ts b/packages/desktop-electron/index.ts
index 782fd586a4..113669121e 100644
--- a/packages/desktop-electron/index.ts
+++ b/packages/desktop-electron/index.ts
@@ -356,6 +356,17 @@ async function createWindow() {
win.setBackgroundColor('#E8ECF0');
+ if (isPlaywrightTest) {
+ // Append a 'playwright' marker to the default Electron userAgent so
+ // navigator.userAgent-based checks in the renderer (Platform.isPlaywright,
+ // environment.isElectron) both light up. Replacing the UA with bare
+ // 'playwright' (as playwright.config.ts does for chromium launches) would
+ // strip the 'Electron' substring that isElectron() relies on.
+ win.webContents.setUserAgent(
+ `${win.webContents.getUserAgent()} playwright`,
+ );
+ }
+
if (isDev) {
win.webContents.openDevTools();
}
@@ -533,7 +544,7 @@ export type GetBootstrapDataPayload = {
ipcMain.on('get-bootstrap-data', event => {
const payload: GetBootstrapDataPayload = {
- version: app.getVersion(),
+ version: isPlaywrightTest ? '99.9.9' : app.getVersion(),
isDev,
};
diff --git a/packages/loot-core/src/shared/platform.ts b/packages/loot-core/src/shared/platform.ts
index 3088aec2df..0628c76390 100644
--- a/packages/loot-core/src/shared/platform.ts
+++ b/packages/loot-core/src/shared/platform.ts
@@ -6,7 +6,7 @@ const isWindows =
const isMac =
navigator.platform && navigator.platform.toUpperCase().indexOf('MAC') >= 0;
-export const isPlaywright = navigator.userAgent === 'playwright';
+export const isPlaywright = navigator.userAgent.includes('playwright');
export const OS: 'windows' | 'mac' | 'linux' | 'unknown' = isWindows
? 'windows'
diff --git a/upcoming-release-notes/7965.md b/upcoming-release-notes/7965.md
new file mode 100644
index 0000000000..7ae88f167b
--- /dev/null
+++ b/upcoming-release-notes/7965.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Update Playwright tests to use fixed version strings for consistent test behavior.