Open-source Revit MCP server: let Claude and other AI assistants read and edit BIM models, with human approval on every change.
Python aecai-agentsautodeskautomationbimclaudeifcmcpmcp-servermodel-context-protocolnavisworksrevitrevit-addinrevit-apirhino
feat(panel): dispatch chat to native Anthropic loop when API key is set
sammohammad57872d52260ae24
diff --git a/packages/mcp-server-revit/src/revit_mcp_server/panel_server.py b/packages/mcp-server-revit/src/revit_mcp_server/panel_server.pyindex e191768..b6120e5 100644--- a/packages/mcp-server-revit/src/revit_mcp_server/panel_server.py+++ b/packages/mcp-server-revit/src/revit_mcp_server/panel_server.py@@ -18,10 +18,13 @@ import asyncioimport jsonimport loggingimport os+import shutilfrom http.server import BaseHTTPRequestHandler, ThreadingHTTPServerfrom typing import Any, Dict-from .agent_bridge import run_agent_turn+from . import agent_bridge+from . import agent_native+from .config import configfrom .errors import RevitMCPErrorfrom .registry_factory import build_registryfrom .security.audit import redact_data@@ -92,8 +95,21 @@ class PanelRequestHandler(BaseHTTPRequestHandler):if self.path == "/reports":self._handle_list_reports()return+ if self.path == "/agent/providers":+ self._handle_agent_providers()+ returnself._send_json(404, {"ok": False, "error": f"Unknown path '{self.path}'"})+ def _handle_agent_providers(self) -> None:+ """Reports which chat providers are actually usable right now, so the+ panel's dropdown can show/enable options accordingly. "claude" covers+ both the native (API key) and CLI-fallback paths that /agent/chat's+ dispatch chain below may route to; "codex" has no native path (CLI+ only, per Task 1's ADR)."""+ claude_available = bool(config.anthropic_api_key) or shutil.which("claude") is not None+ codex_available = shutil.which("codex") is not None+ self._send_json(200, {"ok": True, "providers": {"claude": claude_available, "codex": codex_available}})+def _handle_list_reports(self) -> None:workspace_dir = self.workspace.allowed_directories[0]reports = [@@ -159,7 +175,26 @@ class PanelRequestHandler(BaseHTTPRequestHandler):session_id = body.get("session_id")try:- result = run_agent_turn(provider, message, session_id)+ if config.anthropic_api_key:+ # Native path takes priority whenever an API key is+ # configured, regardless of the requested `provider` value -+ # it replaces the CLI-based "claude" option entirely (see+ # /agent/providers above for how the panel learns this).+ result = agent_native.run_native_turn(message, session_id, self.registry, self.approval_provider)+ elif provider == "codex" or (provider == "claude" and shutil.which("claude") is not None):+ # CLI fallback: codex has no native path so always routes+ # here (agent_bridge itself reports a missing-CLI error);+ # claude only lands here with no API key configured AND the+ # CLI resolvable on PATH.+ result = agent_bridge.run_agent_turn(provider, message, session_id)+ else:+ result = {+ "ok": False,+ "error": (+ "No AI provider is available. Add an Anthropic API key in Settings, "+ "or install and sign in to the claude/codex CLI."+ ),+ }except Exception as e:self._send_json(500, {"ok": False, "error": redact_data(str(e))})returndiff --git a/packages/mcp-server-revit/tests/test_panel_server.py b/packages/mcp-server-revit/tests/test_panel_server.pyindex 1e6d030..4bcf7ff 100644--- a/packages/mcp-server-revit/tests/test_panel_server.py+++ b/packages/mcp-server-revit/tests/test_panel_server.py@@ -11,9 +11,11 @@ import threadingimport timeimport urllib.errorimport urllib.request+from unittest.mock import Mockimport pytest+from revit_mcp_server import panel_serverfrom revit_mcp_server.panel_server import build_serverfrom revit_mcp_server.security.workspace import WorkspaceMonitor@@ -159,3 +161,95 @@ def test_plan_actions_approve_execute_round_trip_over_http(running_server):# an error (no live Revit process in tests). Accept "executed" (all OK) or# "partial" (some actions failed — expected here since Revit is unavailable).assert executed["result"]["state"] in ("executed", "partial")+++def test_agent_providers_none_available(running_server, monkeypatch):+ """No API key configured and neither CLI on PATH: both providers are+ reported unavailable."""+ monkeypatch.setattr(panel_server.config, "anthropic_api_key", None)+ monkeypatch.setattr(panel_server.shutil, "which", lambda _name: None)++ status, body = _get(running_server, "/agent/providers")++ assert status == 200+ assert body == {"ok": True, "providers": {"claude": False, "codex": False}}+++def test_agent_providers_claude_true_with_api_key_configured(running_server, monkeypatch):+ """An Anthropic API key alone is enough for the "claude" provider to be+ reported available, even with no CLI on PATH at all."""+ monkeypatch.setattr(panel_server.config, "anthropic_api_key", "test-key")+ monkeypatch.setattr(panel_server.shutil, "which", lambda _name: None)++ status, body = _get(running_server, "/agent/providers")++ assert status == 200+ assert body["providers"]["claude"] is True+ assert body["providers"]["codex"] is False+++def test_agent_providers_claude_true_with_cli_fallback_only(running_server, monkeypatch):+ """No API key, but the `claude` CLI resolves on PATH: "claude" is still+ reported available via the CLI fallback."""+ monkeypatch.setattr(panel_server.config, "anthropic_api_key", None)+ monkeypatch.setattr(panel_server.shutil, "which", lambda name: "/usr/bin/claude" if name == "claude" else None)++ status, body = _get(running_server, "/agent/providers")++ assert status == 200+ assert body["providers"]["claude"] is True+ assert body["providers"]["codex"] is False+++def test_agent_chat_dispatches_to_native_when_api_key_configured(running_server, monkeypatch):+ """Load-bearing dispatch-priority test: when an Anthropic API key is+ configured, /agent/chat must go through agent_native.run_native_turn and+ must NOT fall through to agent_bridge.run_agent_turn (the CLI path),+ even though the request's provider field says "claude" (the field the+ CLI path used to key off of)."""+ monkeypatch.setattr(panel_server.config, "anthropic_api_key", "test-key")++ native_calls = []+ bridge_calls = []++ def fake_native(message, session_id, registry, approval_provider):+ native_calls.append((message, session_id, registry, approval_provider))+ return {"ok": True, "response": "native reply", "session_id": "sess-native"}++ def fake_bridge(provider, message, session_id):+ bridge_calls.append((provider, message, session_id))+ return {"ok": True, "response": "bridge reply", "session_id": "sess-bridge"}++ monkeypatch.setattr(panel_server.agent_native, "run_native_turn", fake_native)+ monkeypatch.setattr(panel_server.agent_bridge, "run_agent_turn", fake_bridge)++ status, body = _post(running_server, "/agent/chat", {"message": "hi", "provider": "claude"})++ assert status == 200+ assert body == {"ok": True, "response": "native reply", "session_id": "sess-native"}+ assert len(native_calls) == 1+ assert native_calls[0][0] == "hi"+ assert native_calls[0][1] is None+ assert bridge_calls == []+++def test_agent_chat_no_provider_available_returns_error_without_dispatch(running_server, monkeypatch):+ """No API key and no CLI on PATH: the chat request must fail fast with+ the "no provider available" error, without ever calling either agent+ module."""+ monkeypatch.setattr(panel_server.config, "anthropic_api_key", None)+ monkeypatch.setattr(panel_server.shutil, "which", lambda _name: None)++ native_mock = Mock()+ bridge_mock = Mock()+ monkeypatch.setattr(panel_server.agent_native, "run_native_turn", native_mock)+ monkeypatch.setattr(panel_server.agent_bridge, "run_agent_turn", bridge_mock)++ status, body = _post(running_server, "/agent/chat", {"message": "hi"})++ assert body == {+ "ok": False,+ "error": "No AI provider is available. Add an Anthropic API key in Settings, or install and sign in to the claude/codex CLI.",+ }+ native_mock.assert_not_called()+ bridge_mock.assert_not_called()