Skip to content

Open-source Revit MCP server: let Claude and other AI assistants read and edit BIM models, with human approval on every change.

feat: add location handling for Revit placement tools and corresponding tests

sammohammad578dfe8df551681
diff --git a/packages/mcp-server-revit/src/revit_mcp_server/providers/revit.py b/packages/mcp-server-revit/src/revit_mcp_server/providers/revit.py
index fe0da9d..177e563 100644
--- a/packages/mcp-server-revit/src/revit_mcp_server/providers/revit.py
+++ b/packages/mcp-server-revit/src/revit_mcp_server/providers/revit.py
@@ -147,6 +147,24 @@ class RevitProvider(AECProvider):
if key in arguments and isinstance(arguments[key], str):
self.workspace.assert_in_workspace(Path(arguments[key]))
+ @staticmethod
+ def _placement_location(args: Dict[str, Any]) -> Dict[str, Any]:
+ location = args.get("location")
+ if location is not None:
+ if not isinstance(location, dict):
+ raise ValueError("location must be an object with x, y, and optional z coordinates")
+ return {
+ "x": location.get("x"),
+ "y": location.get("y"),
+ "z": location.get("z", 0),
+ }
+
+ return {
+ "x": args.get("x"),
+ "y": args.get("y"),
+ "z": args.get("z", 0),
+ }
+
def _init_tool_mapping(self):
self._tool_mapping = {
"revit_health": ("revit.health", lambda args: {}),
@@ -202,13 +220,13 @@ class RevitProvider(AECProvider):
"wall_id": args.get("wall_id"),
"family_name": args.get("family_name"),
"type_name": args.get("type_name"),
- "location": {"x": args.get("x"), "y": args.get("y"), "z": args.get("z", 0)}
+ "location": self._placement_location(args)
}),
"revit_place_window": ("revit.place_window", lambda args: {
"wall_id": args.get("wall_id"),
"family_name": args.get("family_name"),
"type_name": args.get("type_name"),
- "location": {"x": args.get("x"), "y": args.get("y"), "z": args.get("z", 0)}
+ "location": self._placement_location(args)
}),
"revit_list_families": ("revit.list_families", lambda args: {}),
"revit_create_floor_plan_view": ("revit.create_floor_plan_view", lambda args: {
@@ -455,8 +473,8 @@ class RevitProvider(AECProvider):
ProviderTool(name="revit_create_room", description="Create a room at a specific point on a level", inputSchema={"type": "object", "properties": {"level": {"type": "string"}, "x": {"type": "number"}, "y": {"type": "number"}, "name": {"type": "string", "default": "Room"}, "number": {"type": "string"}}, "required": ["level", "x", "y"]}),
ProviderTool(name="revit_delete_element", description="Delete an element by ID", inputSchema={"type": "object", "properties": {"element_id": {"type": "integer"}}, "required": ["element_id"]}),
ProviderTool(name="revit_place_family_instance", description="Place a family instance (e.g., furniture, equipment)", inputSchema={"type": "object", "properties": {"family_name": {"type": "string"}, "type_name": {"type": "string"}, "level": {"type": "string"}, "x": {"type": "number"}, "y": {"type": "number"}, "z": {"type": "number", "default": 0}}, "required": ["family_name", "type_name", "level", "x", "y"]}),
- ProviderTool(name="revit_place_door", description="Place a door in a wall", inputSchema={"type": "object", "properties": {"wall_id": {"type": "integer"}, "x": {"type": "number"}, "y": {"type": "number"}, "z": {"type": "number", "default": 0}, "family_name": {"type": "string"}, "type_name": {"type": "string"}}, "required": ["wall_id", "x", "y"]}),
- ProviderTool(name="revit_place_window", description="Place a window in a wall", inputSchema={"type": "object", "properties": {"wall_id": {"type": "integer"}, "x": {"type": "number"}, "y": {"type": "number"}, "z": {"type": "number", "default": 0}, "family_name": {"type": "string"}, "type_name": {"type": "string"}}, "required": ["wall_id", "x", "y"]}),
+ ProviderTool(name="revit_place_door", description="Place a door in a wall", inputSchema={"type": "object", "properties": {"wall_id": {"type": "integer"}, "x": {"type": "number"}, "y": {"type": "number"}, "z": {"type": "number", "default": 0}, "location": {"type": "object", "properties": {"x": {"type": "number"}, "y": {"type": "number"}, "z": {"type": "number", "default": 0}}, "required": ["x", "y"]}, "family_name": {"type": "string"}, "type_name": {"type": "string"}}, "required": ["wall_id"], "oneOf": [{"required": ["x", "y"]}, {"required": ["location"]}]}),
+ ProviderTool(name="revit_place_window", description="Place a window in a wall", inputSchema={"type": "object", "properties": {"wall_id": {"type": "integer"}, "x": {"type": "number"}, "y": {"type": "number"}, "z": {"type": "number", "default": 0}, "location": {"type": "object", "properties": {"x": {"type": "number"}, "y": {"type": "number"}, "z": {"type": "number", "default": 0}}, "required": ["x", "y"]}, "family_name": {"type": "string"}, "type_name": {"type": "string"}}, "required": ["wall_id"], "oneOf": [{"required": ["x", "y"]}, {"required": ["location"]}]}),
ProviderTool(name="revit_list_families", description="List all loaded families and their types", inputSchema={"type": "object", "properties": {}}),
ProviderTool(name="revit_create_floor_plan_view", description="Create a floor plan view for a level", inputSchema={"type": "object", "properties": {"level_name": {"type": "string"}, "view_name": {"type": "string"}}, "required": ["level_name"]}),
ProviderTool(name="revit_create_3d_view", description="Create a new 3D view", inputSchema={"type": "object", "properties": {"view_name": {"type": "string"}}, "required": ["view_name"]}),
diff --git a/packages/mcp-server-revit/tests/test_providers.py b/packages/mcp-server-revit/tests/test_providers.py
index 23c5158..28f0287 100644
--- a/packages/mcp-server-revit/tests/test_providers.py
+++ b/packages/mcp-server-revit/tests/test_providers.py
@@ -74,6 +74,32 @@ async def test_revit_provider_mock_mode(tmp_path):
assert res2["status"] == "healthy"
+def test_revit_wall_placement_preserves_nested_location_z(tmp_path):
+ workspace = WorkspaceMonitor([tmp_path])
+ provider = RevitProvider(workspace=workspace, mode=BridgeMode.mock)
+
+ for tool_name in ("revit_place_window", "revit_place_door"):
+ _, build_payload = provider._tool_mapping[tool_name]
+ payload = build_payload({
+ "wall_id": 1245580,
+ "family_name": "Window-Double-Hung",
+ "type_name": '26" x 42"',
+ "location": {"x": -25.0, "y": -50.0, "z": 33.0},
+ })
+
+ assert payload["location"] == {"x": -25.0, "y": -50.0, "z": 33.0}
+
+
+def test_revit_wall_placement_keeps_flat_coordinates_compatible(tmp_path):
+ workspace = WorkspaceMonitor([tmp_path])
+ provider = RevitProvider(workspace=workspace, mode=BridgeMode.mock)
+
+ _, build_payload = provider._tool_mapping["revit_place_window"]
+ payload = build_payload({"wall_id": 1245580, "x": 1.0, "y": 2.0, "z": 3.0})
+
+ assert payload["location"] == {"x": 1.0, "y": 2.0, "z": 3.0}
+
+
@pytest.mark.anyio
async def test_ifc_provider_tools(tmp_path):
workspace = WorkspaceMonitor([tmp_path])