Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

7.3 KB
Raw Blame
using Aetheris.Kernel.Core.Diagnostics;
using Aetheris.Kernel.Core.Brep;
using Aetheris.Kernel.Core.Step242;

namespace Aetheris.Kernel.Core.Tests.Step242;

public sealed class Step242OrientationSemanticsTests
{
    [Fact]
    public void ImportBody_EdgeCurveSameSenseFalse_DoesNotAlterCoedgeReversalState()
    {
        var forward = Step242Importer.ImportBody(BuildSingleTriangleStep(edgeCurveSameSense: true, faceBoundOrientation: true, advancedFaceSameSense: true));
        var reversed = Step242Importer.ImportBody(BuildSingleTriangleStep(edgeCurveSameSense: false, faceBoundOrientation: true, advancedFaceSameSense: true));

        Assert.True(forward.IsSuccess);
        Assert.True(reversed.IsSuccess);

        var forwardCoedge = Assert.Single(forward.Value.Topology.Coedges);
        var reversedCoedge = Assert.Single(reversed.Value.Topology.Coedges);
        Assert.Equal(forwardCoedge.IsReversed, reversedCoedge.IsReversed);
    }

    /// <summary>
    /// FACE_BOUND orientation .F. means the face uses its EDGE_LOOP reversed (ISO 10303-42): the loop order
    /// reverses and every oriented edge flips. Flipping senses without reversing order (the pre-March 2026
    /// handler) breaks loop connectivity; ignoring the flag leaves loops running against their faces.
    /// </summary>
    [Fact]
    public void ImportBody_FaceBoundOrientationFalse_UsesTheLoopReversed()
    {
        var forward = Step242Importer.ImportBody(BuildSingleTriangleStep(edgeCurveSameSense: true, faceBoundOrientation: true, advancedFaceSameSense: true));
        var reversed = Step242Importer.ImportBody(BuildSingleTriangleStep(edgeCurveSameSense: true, faceBoundOrientation: false, advancedFaceSameSense: true));

        Assert.True(forward.IsSuccess);
        Assert.True(reversed.IsSuccess);

        var forwardCoedge = Assert.Single(forward.Value.Topology.Coedges);
        var reversedCoedge = Assert.Single(reversed.Value.Topology.Coedges);
        Assert.NotEqual(forwardCoedge.IsReversed, reversedCoedge.IsReversed);
    }

    /// <summary>
    /// ADVANCED_FACE.same_sense is retained as source evidence and never folded into the stored support or exposed as
    /// canonical orientation. An open one-face shell has deterministic local orientation but no global outwardness.
    /// </summary>
    [Fact]
    public void ImportBody_AdvancedFaceSameSenseFalse_KeepsTheStatedPlane_AndRecordsSourceEvidenceSeparately()
    {
        var forward = Step242Importer.ImportBody(BuildSingleTriangleStep(edgeCurveSameSense: true, faceBoundOrientation: true, advancedFaceSameSense: true));
        var reversed = Step242Importer.ImportBody(BuildSingleTriangleStep(edgeCurveSameSense: true, faceBoundOrientation: true, advancedFaceSameSense: false));

        Assert.True(forward.IsSuccess);
        Assert.True(reversed.IsSuccess);

        var forwardFace = Assert.Single(forward.Value.Topology.Faces);
        var reversedFace = Assert.Single(reversed.Value.Topology.Faces);

        Assert.True(forward.Value.TryGetFaceSurfaceGeometry(forwardFace.Id, out var forwardSurface));
        Assert.True(reversed.Value.TryGetFaceSurfaceGeometry(reversedFace.Id, out var reversedSurface));

        Assert.Equal(1d, forwardSurface!.Plane!.Value.Normal.Z);
        Assert.Equal(1d, reversedSurface!.Plane!.Value.Normal.Z);
        Assert.True(forward.Value.Bindings.GetFaceBinding(forwardFace.Id).Orientation.IsAlignedWithSurface);
        Assert.True(reversed.Value.Bindings.GetFaceBinding(reversedFace.Id).Orientation.IsAlignedWithSurface);
        var evidence = Assert.Single(reversed.Value.FaceOrientationReport!.Faces);
        Assert.False(evidence.SourceEvidence.StepSameSense);
        Assert.Equal(FaceOrientationQualification.DerivedLocallyConsistentGlobalUnknown, evidence.Qualification);
        Assert.Equal(SourceFaceOrientationComparison.Disagrees, evidence.SourceComparison);
    }

    [Fact]
    public void ImportBody_EdgeCurveSameSenseFalse_WithOppositeLineDirection_ImportsSuccessfully()
    {
        var result = Step242Importer.ImportBody(BuildSingleEdgeStep(edgeCurveSameSense: false, orientedEdgeOrientation: true, lineDirectionX: -1d));

        Assert.True(result.IsSuccess, string.Join(" | ", result.Diagnostics.Select(d => $"{d.Source}:{d.Message}")));
        Assert.Contains(result.Diagnostics, diagnostic => diagnostic.Source == "Importer.StepOrientation.GlobalOrientationUnknown");
    }

    [Fact]
    public void ImportBody_EdgeCurveSameSenseTrue_WithOppositeLineDirection_ReturnsGeometryDiagnostic()
    {
        var result = Step242Importer.ImportBody(BuildSingleEdgeStep(edgeCurveSameSense: true, orientedEdgeOrientation: true, lineDirectionX: -1d));

        Assert.False(result.IsSuccess);
        var first = Assert.Single(result.Diagnostics);
        Assert.Equal("Importer.Geometry.EdgeCurveParameters", first.Source);
        Assert.Contains("opposite to vertex ordering", first.Message, StringComparison.Ordinal);
    }

    [Fact]
    public void ImportBody_OrientationTypeMismatch_ReturnsDiagnosticsWithoutThrowing()
    {
        const string invalidOrientation = "ISO-10303-21;\nHEADER;\nENDSEC;\nDATA;\n#1=MANIFOLD_SOLID_BREP('solid',#2);\n#2=CLOSED_SHELL($,(#3));\n#3=ADVANCED_FACE((#4),#5,.T.);\n#4=FACE_OUTER_BOUND($,#6,#7);\n#5=PLANE($,#20);\n#6=EDGE_LOOP($,(#8));\n#7=CARTESIAN_POINT($,(0,0,0));\n#8=ORIENTED_EDGE($,$,$,#9,.T.);\n#9=EDGE_CURVE($,#10,#11,#12,.T.);\n#10=VERTEX_POINT($,#13);\n#11=VERTEX_POINT($,#14);\n#12=LINE($,#13,#15);\n#13=CARTESIAN_POINT($,(0,0,0));\n#14=CARTESIAN_POINT($,(1,0,0));\n#15=VECTOR($,#16,1.0);\n#16=DIRECTION($,(1,0,0));\n#20=AXIS2_PLACEMENT_3D($,#13,#21,#22);\n#21=DIRECTION($,(0,0,1));\n#22=DIRECTION($,(1,0,0));\nENDSEC;\nEND-ISO-10303-21;";

        var import = Record.Exception(() => Step242Importer.ImportBody(invalidOrientation));

        Assert.Null(import);
        var result = Step242Importer.ImportBody(invalidOrientation);
        Assert.False(result.IsSuccess);
        Assert.NotEmpty(result.Diagnostics);
    }

    private static string BuildSingleTriangleStep(bool edgeCurveSameSense, bool faceBoundOrientation, bool advancedFaceSameSense)
    {
        var boundOrientation = faceBoundOrientation ? ".T." : ".F.";
        var faceSense = advancedFaceSameSense ? ".T." : ".F.";
        return BuildSingleEdgeStep(edgeCurveSameSense, orientedEdgeOrientation: true, lineDirectionX: 1d, boundOrientation, faceSense);
    }

    private static string BuildSingleEdgeStep(bool edgeCurveSameSense, bool orientedEdgeOrientation, double lineDirectionX, string boundOrientation = ".T.", string faceSense = ".T.")
    {
        var edgeSense = edgeCurveSameSense ? ".T." : ".F.";
        var orientedSense = orientedEdgeOrientation ? ".T." : ".F.";

        return $"ISO-10303-21;\nHEADER;\nENDSEC;\nDATA;\n#1=MANIFOLD_SOLID_BREP('solid',#2);\n#2=CLOSED_SHELL($,(#3));\n#3=ADVANCED_FACE((#4),#5,{faceSense});\n#4=FACE_OUTER_BOUND($,#6,{boundOrientation});\n#5=PLANE($,#20);\n#6=EDGE_LOOP($,(#7));\n#7=ORIENTED_EDGE($,$,$,#8,{orientedSense});\n#8=EDGE_CURVE($,#9,#10,#11,{edgeSense});\n#9=VERTEX_POINT($,#12);\n#10=VERTEX_POINT($,#13);\n#11=LINE($,#12,#14);\n#12=CARTESIAN_POINT($,(0,0,0));\n#13=CARTESIAN_POINT($,(1,0,0));\n#14=VECTOR($,#15,1.0);\n#15=DIRECTION($,({lineDirectionX},0,0));\n#20=AXIS2_PLACEMENT_3D($,#12,#21,#22);\n#21=DIRECTION($,(0,0,1));\n#22=DIRECTION($,(1,0,0));\nENDSEC;\nEND-ISO-10303-21;";
    }

}