Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel
Route AIR chamfer exports through authoritative topology plans
Yuechen Li15b1ddaab90b
diff --git a/Aetheris.CLI.Tests/FirmamentV2AirChamferStepPipelineTests.cs b/Aetheris.CLI.Tests/FirmamentV2AirChamferStepPipelineTests.csnew file mode 100644index 00000000..80adf4b4--- /dev/null+++ b/Aetheris.CLI.Tests/FirmamentV2AirChamferStepPipelineTests.cs@@ -0,0 +1,92 @@+using System.Security.Cryptography;+using System.Text;+using System.Text.Json;+using Aetheris.Kernel.Core.Step242;++namespace Aetheris.CLI.Tests;++public sealed class FirmamentV2AirChamferStepPipelineTests+{+ [Fact]+ public void FirmamentV2_AirChamfer_Matrix_ExportsChangedDeterministicReimportableGeometry()+ {+ var cases = new[] { (10d, 8d, 6d, 1d), (10d, 8d, 6d, 2d), (12d, 5d, 7d, 1d) };+ var hashes = new HashSet<string>(StringComparer.Ordinal);+ foreach (var test in cases)+ {+ var first = Build(test.Item1, test.Item2, test.Item3, test.Item4);+ var second = Build(test.Item1, test.Item2, test.Item3, test.Item4);+ Assert.Equal(first.Hash, second.Hash);+ Assert.True(hashes.Add(first.Hash), "parameter variations must change STEP geometry/hash");+ Assert.Equal(12, first.Body.Topology.Vertices.Count());+ Assert.Equal(20, first.Body.Topology.Edges.Count());+ Assert.Equal(10, first.Body.Topology.Faces.Count());++ var top = first.Body.Topology.Vertices.Select(v => first.Body.TryGetVertexPoint(v.Id, out var p) ? p : throw new InvalidOperationException()).Where(p => Math.Abs(p.Z - test.Item3) < 1e-9).ToArray();+ Assert.Equal(4, top.Length);+ Assert.Equal((-test.Item1 / 2d) + test.Item4, top.Min(p => p.X), 9);+ Assert.Equal((test.Item1 / 2d) - test.Item4, top.Max(p => p.X), 9);+ Assert.Equal((-test.Item2 / 2d) + test.Item4, top.Min(p => p.Y), 9);+ Assert.Equal((test.Item2 / 2d) - test.Item4, top.Max(p => p.Y), 9);+ }+ }++ [Theory]+ [InlineData(0, "+Z", "Boundary", "air-chamfer-distance-must-be-positive")]+ [InlineData(4, "+Z", "Boundary", "air-chamfer-distance-too-large-rejected")]+ [InlineData(1, "-Z", "Boundary", "air-chamfer-unsupported-face-rejected")]+ [InlineData(1, "+Z", "SingleEdge", "air-chamfer-unsupported-selection-rejected")]+ public void FirmamentV2_AirChamfer_Rejections_DoNotFallBack(double distance, string face, string target, string expected)+ {+ var run = Run(Source(10, 8, 6, distance, face, target));+ Assert.Equal(1, run.Exit);+ Assert.Contains(expected, run.Stdout, StringComparison.Ordinal);+ Assert.DoesNotContain("legacyFallback\":true", run.Stdout, StringComparison.Ordinal);+ }++ private static (string Hash, Aetheris.Kernel.Core.Brep.BrepBody Body) Build(double width, double depth, double height, double distance)+ {+ var run = Run(Source(width, depth, height, distance));+ Assert.Equal(0, run.Exit);+ using var json = JsonDocument.Parse(run.Stdout);+ var air = json.RootElement.GetProperty("air");+ Assert.True(air.GetProperty("bRepPlan").GetProperty("authoritative").GetBoolean());+ Assert.Equal("AirPrismaticTopFaceBoundaryChamfer", air.GetProperty("materialization").GetProperty("route").GetString());+ Assert.False(air.GetProperty("materialization").GetProperty("legacyFallback").GetBoolean());+ Assert.True(air.GetProperty("materialization").GetProperty("enclosedManifold").GetBoolean());+ Assert.Equal(distance, air.GetProperty("materialization").GetProperty("measuredTopInsetX").GetDouble(), 9);+ Assert.Equal(distance, air.GetProperty("materialization").GetProperty("measuredTopInsetY").GetDouble(), 9);+ Assert.True(air.GetProperty("step").GetProperty("reimportSucceeded").GetBoolean());+ var stepPath = json.RootElement.GetProperty("outputPath").GetString()!;+ var bytes = File.ReadAllBytes(stepPath);+ var imported = Step242Importer.ImportBody(Encoding.UTF8.GetString(bytes));+ Assert.True(imported.IsSuccess, string.Join(Environment.NewLine, imported.Diagnostics.Select(d => d.Message)));+ return (Convert.ToHexString(SHA256.HashData(bytes)), imported.Value);+ }++ private static (int Exit, string Stdout) Run(string source)+ {+ var dir = Path.Combine(Path.GetTempPath(), "aetheris-air-chamfer-m1", Guid.NewGuid().ToString("N"));+ Directory.CreateDirectory(dir);+ var sourcePath = Path.Combine(dir, "case.firmament");+ var stepPath = Path.Combine(dir, "case.step");+ File.WriteAllText(sourcePath, source);+ var stdout = new StringWriter();+ var stderr = new StringWriter();+ var exit = Aetheris.CLI.CliRunner.Run(["build", sourcePath, "--out", stepPath, "--json"], stdout, stderr);+ return (exit, stdout + stderr.ToString());+ }++ private static string Source(double width, double depth, double height, double distance, string face = "+Z", string target = "Boundary") => $$"""+ Model Test mm+ Box Base { Size: [{{width}}mm, {{depth}}mm, {{height}}mm] }+ Modify Base {+ EdgeFinish TopBreak {+ Face: {{face}}+ Target: {{target}}+ Kind: Chamfer+ Distance: {{distance}}mm+ }+ }+ """;+}diff --git a/Aetheris.CLI/CliRunner.cs b/Aetheris.CLI/CliRunner.csindex b635c3ea..8da2cf2e 100644--- a/Aetheris.CLI/CliRunner.cs+++ b/Aetheris.CLI/CliRunner.cs@@ -261,6 +261,7 @@ public static class CliRunnersuccess = true,sourcePath = build.Value.SourcePath,outputPath = build.Value.OutputPath,+ air = build.Value.Export.Air,inlineStepMigration = build.Value.Export.InlineStepMigration,inlineStepReplacementAssist = build.Value.Export.InlineStepReplacementAssist,pmiExportEvidence = newdiff --git a/Aetheris.Kernel.Core/Air/AirBRepPlan.cs b/Aetheris.Kernel.Core/Air/AirBRepPlan.csindex 1a7a9577..a6ee7fb0 100644--- a/Aetheris.Kernel.Core/Air/AirBRepPlan.cs+++ b/Aetheris.Kernel.Core/Air/AirBRepPlan.cs@@ -73,7 +73,11 @@ internal sealed record AirBRepPlan(AirBRepPlanSummary Summary,IReadOnlyList<AirDiagnostic> Diagnostics,IReadOnlyList<string> Guarantees,- AirBRepPlanFeatureContext? FeatureContext = null);+ AirBRepPlanFeatureContext? FeatureContext = null,+ PrismaticSectionTransitionTopologyPlan? RealizationPlan = null)+{+ public bool IsAuthoritative => RealizationPlan is not null;+}internal sealed record AirBRepPlanResult(AirBRepPlan? Plan, AirBRepPlanValidationResult Validation){@@ -110,14 +114,15 @@ internal static class AirPrismaticSectionTransitionBRepPlannerreturn new AirBRepPlanResult(null, Validation(false, sourceAirNodeId, diagnostics, rejected));}- var elements = BuildElements(request, sourceAirNodeId, provenance, diagnostics);- var summary = Summary(request, sourceAirNodeId, diagnostics, RouteGuarantees);+ var realizationPlan = PrismaticSectionTransitionTopologyPlanner.Create(request);+ var elements = BuildElements(realizationPlan, sourceAirNodeId, provenance, diagnostics);+ var summary = Summary(realizationPlan, sourceAirNodeId, diagnostics, RouteGuarantees);diagnostics.Add(D("air-x3-prismatic-plan-created"));diagnostics.Add(D("air-x3-prismatic-plan-validated"));diagnostics.AddRange(RouteGuarantees.Select(g => D("air-x3-" + g.Replace(" ", "-").Replace("STEP", "step").Replace("BRep", "brep").Replace("AirEdgeSweep", "air-edge-sweep").Replace("Boolean", "boolean"))));diagnostics = Stable(diagnostics).ToList();summary = summary with { Diagnostics = diagnostics };- var plan = new AirBRepPlan("brep-plan:prismatic-section-transition:" + sourceAirNodeId, AirBRepPlanKind.PrismaticSectionTransition, sourceAirNodeId, provenance, elements, summary, diagnostics, RouteGuarantees);+ var plan = new AirBRepPlan("brep-plan:prismatic-section-transition:" + sourceAirNodeId, AirBRepPlanKind.PrismaticSectionTransition, sourceAirNodeId, provenance, elements, summary, diagnostics, RouteGuarantees, RealizationPlan: realizationPlan);return new AirBRepPlanResult(plan, new AirBRepPlanValidationResult(true, diagnostics, [], [], summary));}@@ -142,22 +147,37 @@ internal static class AirPrismaticSectionTransitionBRepPlannerreturn null;}- private static IReadOnlyList<AirBRepPlanElement> BuildElements(PrismaticSectionTransitionRequest request, string sourceAirNodeId, AirProvenance provenance, List<AirDiagnostic> diagnostics)+ private static IReadOnlyList<AirBRepPlanElement> BuildElements(PrismaticSectionTransitionTopologyPlan plan, string sourceAirNodeId, AirProvenance provenance, List<AirDiagnostic> diagnostics){var e = new List<AirBRepPlanElement>();- var n = request.Sections[0].OuterLoop.Count;- for (var s = 0; s < request.Sections.Count; s++) for (var i = 0; i < n; i++) e.Add(E($"v:s{s}:{i}", AirBRepPlanElementKind.Vertex, AirBRepPlanRole.SectionVertex, s, i));+ foreach (var vertex in plan.Vertices) e.Add(E(vertex.Id, AirBRepPlanElementKind.Vertex, AirBRepPlanRole.SectionVertex, vertex.SectionIndex, vertex.ProfileVertexIndex));diagnostics.Add(D("air-x3-section-vertices-planned"));- for (var s = 0; s < request.Sections.Count; s++) for (var i = 0; i < n; i++) { e.Add(E($"c:section:{s}:{i}", AirBRepPlanElementKind.Curve, AirBRepPlanRole.SectionEdge, s, null, null, i)); e.Add(E($"e:section:{s}:{i}", AirBRepPlanElementKind.Edge, AirBRepPlanRole.SectionEdge, s, null, null, i)); }+ foreach (var edge in plan.Edges)+ {+ var role = edge.Kind == PrismaticPlannedEdgeKind.Section ? AirBRepPlanRole.SectionEdge : AirBRepPlanRole.VerticalTransitionEdge;+ e.Add(E(edge.Id.Replace("e:", "c:", StringComparison.Ordinal), AirBRepPlanElementKind.Curve, role, edge.SectionIndex, null, edge.IntervalIndex, edge.ProfileEdgeIndex));+ e.Add(E(edge.Id, AirBRepPlanElementKind.Edge, role, edge.SectionIndex, null, edge.IntervalIndex, edge.ProfileEdgeIndex));+ }diagnostics.Add(D("air-x3-section-edges-planned"));- for (var s = 0; s < request.Sections.Count - 1; s++) for (var i = 0; i < n; i++) { e.Add(E($"c:transition:{s}:{i}", AirBRepPlanElementKind.Curve, AirBRepPlanRole.VerticalTransitionEdge, null, null, s, i)); e.Add(E($"e:transition:{s}:{i}", AirBRepPlanElementKind.Edge, AirBRepPlanRole.VerticalTransitionEdge, null, null, s, i)); }diagnostics.Add(D("air-x3-transition-edges-planned"));- e.Add(E("surf:cap:bottom", AirBRepPlanElementKind.Surface, AirBRepPlanRole.CapFace)); e.Add(E("loop:face:cap:bottom", AirBRepPlanElementKind.Loop, AirBRepPlanRole.SectionLoop)); e.Add(E("f:cap:bottom", AirBRepPlanElementKind.Face, AirBRepPlanRole.CapFace, faceRole: "bottom-cap"));- e.Add(E("surf:cap:top", AirBRepPlanElementKind.Surface, AirBRepPlanRole.CapFace)); e.Add(E("loop:face:cap:top", AirBRepPlanElementKind.Loop, AirBRepPlanRole.SectionLoop)); e.Add(E("f:cap:top", AirBRepPlanElementKind.Face, AirBRepPlanRole.CapFace, faceRole: "top-cap"));+ var coedgeIndex = 0;+ foreach (var face in plan.Faces)+ {+ var role = face.Kind switch+ {+ PrismaticPlannedFaceKind.BottomCap or PrismaticPlannedFaceKind.TopCap => AirBRepPlanRole.CapFace,+ PrismaticPlannedFaceKind.StableSide => AirBRepPlanRole.SideFace,+ _ => AirBRepPlanRole.TransitionFace,+ };+ var faceRole = face.Kind switch { PrismaticPlannedFaceKind.BottomCap => "bottom-cap", PrismaticPlannedFaceKind.TopCap => "top-cap", PrismaticPlannedFaceKind.StableSide => "side", _ => "transition" };+ var suffix = face.Id[2..];+ e.Add(E($"surf:{suffix}", AirBRepPlanElementKind.Surface, role, interval: face.IntervalIndex, edge: face.ProfileEdgeIndex));+ e.Add(E($"loop:face:{suffix}", AirBRepPlanElementKind.Loop, role, interval: face.IntervalIndex, edge: face.ProfileEdgeIndex));+ e.Add(E(face.Id, AirBRepPlanElementKind.Face, role, interval: face.IntervalIndex, edge: face.ProfileEdgeIndex, faceRole: faceRole));+ foreach (var _ in face.Boundary) e.Add(E($"coedge:{coedgeIndex++:00}", AirBRepPlanElementKind.Coedge, role, interval: face.IntervalIndex, edge: face.ProfileEdgeIndex));+ }diagnostics.Add(D("air-x3-cap-faces-planned"));- for (var s = 0; s < request.Sections.Count - 1; s++) for (var i = 0; i < n; i++) { var role = s == 0 ? AirBRepPlanRole.SideFace : AirBRepPlanRole.TransitionFace; var label = s == 0 ? "side" : "transition"; e.Add(E($"surf:{label}:interval{s}:edge{i}", AirBRepPlanElementKind.Surface, role, null, null, s, i)); e.Add(E($"loop:face:{label}:interval{s}:edge{i}", AirBRepPlanElementKind.Loop, role, null, null, s, i)); e.Add(E($"f:{label}:interval{s}:edge{i}", AirBRepPlanElementKind.Face, role, null, null, s, i, label)); }diagnostics.Add(D("air-x3-transition-faces-planned"));- for (var i = 0; i < 40; i++) e.Add(E($"coedge:{i:00}", AirBRepPlanElementKind.Coedge, AirBRepPlanRole.Unknown));e.Add(E("shell:body:0", AirBRepPlanElementKind.Shell, AirBRepPlanRole.BodyShell)); diagnostics.Add(D("air-x3-shell-planned"));e.Add(E("body:0", AirBRepPlanElementKind.Body, AirBRepPlanRole.Body)); diagnostics.Add(D("air-x3-body-planned"));diagnostics.Add(D("air-x3-stable-planned-ids-created"));@@ -165,12 +185,13 @@ internal static class AirPrismaticSectionTransitionBRepPlannerAirBRepPlanElement E(string id, AirBRepPlanElementKind kind, AirBRepPlanRole role, int? section = null, int? vertex = null, int? interval = null, int? edge = null, string? faceRole = null) => new(new AirBRepPlanId(id), kind, role, sourceAirNodeId, provenance, section, vertex, interval, edge, faceRole, [], role == AirBRepPlanRole.TransitionFace ? [AirBRepPlanRole.PrismaticTransitionFace] : [role]);}- private static AirBRepPlanSummary Summary(PrismaticSectionTransitionRequest request, string sourceAirNodeId, IReadOnlyList<AirDiagnostic> diagnostics, IReadOnlyList<string> guarantees)+ private static AirBRepPlanSummary Summary(PrismaticSectionTransitionTopologyPlan plan, string sourceAirNodeId, IReadOnlyList<AirDiagnostic> diagnostics, IReadOnlyList<string> guarantees){- var n = request.Sections[0].OuterLoop.Count; var intervals = request.Sections.Count - 1; var faces = 2 + intervals * n;- var allX = request.Sections.SelectMany(s => s.OuterLoop.Select(p => p.X)); var allY = request.Sections.SelectMany(s => s.OuterLoop.Select(p => p.Y));- var bounds = FormattableString.Invariant($"[{allX.Min():0.###},{allY.Min():0.###},{request.Sections.Min(s => s.Z):0.###}]..[{allX.Max():0.###},{allY.Max():0.###},{request.Sections.Max(s => s.Z):0.###}]");- return new(AirBRepPlanKind.PrismaticSectionTransition, sourceAirNodeId, request.Sections.Count * n, request.Sections.Count * n + intervals * n, request.Sections.Count * n + intervals * n, (2 * n) + (4 * intervals * n), faces, faces, faces, 1, 1, 2, n, n, 0, bounds, PreserveSectionSplits, diagnostics, guarantees);+ var bounds = FormattableString.Invariant($"[{plan.Vertices.Min(v => v.Point.X):0.###},{plan.Vertices.Min(v => v.Point.Y):0.###},{plan.Vertices.Min(v => v.Point.Z):0.###}]..[{plan.Vertices.Max(v => v.Point.X):0.###},{plan.Vertices.Max(v => v.Point.Y):0.###},{plan.Vertices.Max(v => v.Point.Z):0.###}]");+ var caps = plan.Faces.Count(f => f.Kind is PrismaticPlannedFaceKind.BottomCap or PrismaticPlannedFaceKind.TopCap);+ var sides = plan.Faces.Count(f => f.Kind == PrismaticPlannedFaceKind.StableSide);+ var transitions = plan.Faces.Count(f => f.Kind == PrismaticPlannedFaceKind.Transition);+ return new(AirBRepPlanKind.PrismaticSectionTransition, sourceAirNodeId, plan.Vertices.Count, plan.Edges.Count, plan.Edges.Count, plan.ExpectedCoedgeCount, plan.ExpectedLoopCount, plan.Faces.Count, plan.Faces.Count, 1, 1, caps, sides, transitions, 0, bounds, plan.SplitPolicy, diagnostics, guarantees);}private static AirBRepPlanValidationResult Validation(bool succeeded, string sourceAirNodeId, List<AirDiagnostic> diagnostics, AirDiagnostic error)@@ -214,8 +235,8 @@ internal static class AirTopFaceLoopChamferBRepPlannerAirSelectionClass.FaceBoundaryLoop,AirRuleKind.UniformChamfer,"generated/history-known",- false,- ["Class B face-boundary loop uniform chamfer lowered through the prismatic section-transition plan.", "not-four-independent-single-edge-chamfers"]);+ true,+ ["Class B face-boundary loop uniform chamfer lowered through the authoritative prismatic section-transition plan.", "not-four-independent-single-edge-chamfers"]);var prismatic = AirPrismaticSectionTransitionBRepPlanner.Plan(new PrismaticSectionTransitionRequest(PrismaticTopFaceLoopChamferPrototype.CreateSectionStack(request), PrismaticCorrespondenceMap.Identity(4), new PrismaticSectionTransitionOptions(RunStepSmoke: request.ExportStep, TraceLabel: "air-x4-top-face-loop-chamfer-brep-plan")),diff --git a/Aetheris.Kernel.Core/Air/AirTopFaceBoundaryChamferCompiler.cs b/Aetheris.Kernel.Core/Air/AirTopFaceBoundaryChamferCompiler.csnew file mode 100644index 00000000..267a2bd4--- /dev/null+++ b/Aetheris.Kernel.Core/Air/AirTopFaceBoundaryChamferCompiler.cs@@ -0,0 +1,145 @@+using Aetheris.Kernel.Core.Air.BRepPlan;+using Aetheris.Kernel.Core.Brep;+using Aetheris.Kernel.Core.Brep.Prismatic;++namespace Aetheris.Kernel.Core.Air;++internal enum AirFeatureAdmissionStatus { Admitted, Rejected, Deferred }+internal sealed record AirSourceSpan(int Start, int Length, string SourceName);+internal sealed record AirFaceBoundarySelection(string FaceAxis, string BoundaryKind = "Outer", bool CompleteLoop = true);+internal sealed record AirEqualDistanceChamferRule(double Distance, string Unit = "mm");++internal sealed record AirChamferFeature(+ string FeatureId,+ string FeatureName,+ string BodyId,+ AirFaceBoundarySelection Selection,+ AirEqualDistanceChamferRule Rule,+ AirSourceSpan SourceSpan,+ string ConstructionHistoryKind,+ AirFeatureAdmissionStatus Admission,+ string AdmissionReason);++internal sealed record AirPlanarProfileNode(string NodeId, int Order, double Z, IReadOnlyList<(double X, double Y)> OuterLoop);+internal sealed record AirSectionTransitionNode(string NodeId, IReadOnlyList<string> OrderedProfileNodeIds, string Correspondence, string SplitPolicy);+internal sealed record AirChamferConstruction(+ string ConstructionId,+ string SourceFeatureId,+ IReadOnlyList<AirPlanarProfileNode> Profiles,+ AirSectionTransitionNode Transition,+ PrismaticSectionTransitionRequest Request);++internal sealed record AirTopFaceBoundaryChamferCompileRequest(+ string BodyId,+ string FeatureId,+ string FeatureName,+ double Width,+ double Depth,+ double Height,+ string FaceAxis,+ string Target,+ string Kind,+ double Distance,+ AirSourceSpan SourceSpan,+ bool HistoryKnown = true);++internal sealed record AirTopFaceBoundaryChamferCompileResult(+ bool Succeeded,+ AirChamferFeature Feature,+ AirChamferConstruction? Construction,+ AirBRepPlan? BRepPlan,+ BrepBody? Body,+ PrismaticTransitionTopologySummary? Topology,+ IReadOnlyList<string> Diagnostics)+{+ public const string ProductionRoute = "AirPrismaticTopFaceBoundaryChamfer";+}++/// <summary>Production compiler for the single admitted history-known rectangular-prism top-boundary chamfer.</summary>+internal static class AirTopFaceBoundaryChamferCompiler+{+ private const double Tol = 1e-9;++ public static AirTopFaceBoundaryChamferCompileResult Compile(AirTopFaceBoundaryChamferCompileRequest input)+ {+ var (status, reason) = Admit(input);+ var feature = new AirChamferFeature(+ input.FeatureId,+ input.FeatureName,+ input.BodyId,+ new AirFaceBoundarySelection(input.FaceAxis),+ new AirEqualDistanceChamferRule(input.Distance),+ input.SourceSpan,+ input.HistoryKnown ? "generated/history-known-axis-aligned-rectangular-prism" : "imported/no-history",+ status,+ reason);+ if (status != AirFeatureAdmissionStatus.Admitted)+ return new(false, feature, null, null, null, null, [reason]);++ var geometricRequest = new PrismaticTopFaceLoopChamferRequest(input.Width, input.Depth, input.Height, input.Distance);+ var sections = PrismaticTopFaceLoopChamferPrototype.CreateSectionStack(geometricRequest);+ var profiles = sections.Select((section, index) => new AirPlanarProfileNode(+ $"{input.FeatureId}:profile:{index}", index, section.Z, section.OuterLoop.ToArray())).ToArray();+ var request = new PrismaticSectionTransitionRequest(+ sections,+ PrismaticCorrespondenceMap.Identity(4),+ new PrismaticSectionTransitionOptions(false, AirTopFaceBoundaryChamferCompileResult.ProductionRoute));+ var transition = new AirSectionTransitionNode(+ $"{input.FeatureId}:section-transition",+ profiles.Select(p => p.NodeId).ToArray(),+ "identity-by-profile-index",+ PrismaticSectionTransitionTopologyPlanner.PreserveSectionSplits);+ var construction = new AirChamferConstruction($"construction:{input.FeatureId}", input.FeatureId, profiles, transition, request);++ var featureContext = new AirBRepPlanFeatureContext(+ AirNodeKind.TopFaceLoopChamfer,+ AirRouteKind.TopFaceLoopChamferPrismatic,+ AirSelectionClass.FaceBoundaryLoop,+ AirRuleKind.UniformChamfer,+ feature.ConstructionHistoryKind,+ "BoundedProductionAdmission",+ ["complete +Z outer boundary loop", "uniform equal-distance rule"]);+ var planned = AirTopFaceLoopChamferBRepPlanner.Plan(geometricRequest, featureContext, input.FeatureId);+ if (!planned.Succeeded || planned.Plan?.RealizationPlan is null)+ return new(false, feature, construction, planned.Plan, null, null, planned.Validation.Diagnostics.Select(d => d.Code).ToArray());++ var emitted = PrismaticSectionTransitionEmitter.Emit(+ planned.Plan.RealizationPlan,+ new PrismaticSectionTransitionOptions(false, AirTopFaceBoundaryChamferCompileResult.ProductionRoute));+ if (!emitted.Succeeded || emitted.Body is null)+ return new(false, feature, construction, planned.Plan, emitted.Body, emitted.Topology, emitted.Diagnostics);++ var topologyMatchesPlan = emitted.Topology.VertexCount == planned.Plan.RealizationPlan.Vertices.Count+ && emitted.Topology.EdgeCount == planned.Plan.RealizationPlan.Edges.Count+ && emitted.Topology.FaceCount == planned.Plan.RealizationPlan.Faces.Count+ && emitted.Topology.LoopCount == planned.Plan.RealizationPlan.ExpectedLoopCount+ && emitted.Topology.CoedgeCount == planned.Plan.RealizationPlan.ExpectedCoedgeCount;+ if (!topologyMatchesPlan)+ return new(false, feature, construction, planned.Plan, emitted.Body, emitted.Topology, emitted.Diagnostics.Concat(["air-chamfer-materialization-diverged-from-authoritative-brep-plan"]).ToArray());++ var top = planned.Plan.RealizationPlan.Vertices.Where(v => v.SectionIndex == 2).Select(v => v.Point).ToArray();+ var insetIsExact = top.Min(p => p.X) == (-input.Width / 2d) + input.Distance+ && top.Max(p => p.X) == (input.Width / 2d) - input.Distance+ && top.Min(p => p.Y) == (-input.Depth / 2d) + input.Distance+ && top.Max(p => p.Y) == (input.Depth / 2d) - input.Distance;+ if (!insetIsExact)+ return new(false, feature, construction, planned.Plan, emitted.Body, emitted.Topology, ["air-chamfer-top-inset-evidence-mismatch"]);++ return new(true, feature, construction, planned.Plan, emitted.Body, emitted.Topology,+ emitted.Diagnostics.Concat(["air-chamfer-feature-admitted", "air-chamfer-authoritative-brep-plan-consumed", "air-chamfer-top-inset-verified"]).Distinct().Order().ToArray());+ }++ private static (AirFeatureAdmissionStatus Status, string Reason) Admit(AirTopFaceBoundaryChamferCompileRequest input)+ {+ if (!input.HistoryKnown) return (AirFeatureAdmissionStatus.Deferred, "air-chamfer-imported-no-history-body-deferred");+ if (!string.Equals(input.FaceAxis, "+Z", StringComparison.Ordinal)) return (AirFeatureAdmissionStatus.Rejected, "air-chamfer-unsupported-face-rejected:expected-+Z");+ if (!string.Equals(input.Target, "Boundary", StringComparison.Ordinal)) return (AirFeatureAdmissionStatus.Rejected, "air-chamfer-unsupported-selection-rejected:expected-Boundary");+ if (!string.Equals(input.Kind, "Chamfer", StringComparison.Ordinal)) return (AirFeatureAdmissionStatus.Rejected, "air-chamfer-unsupported-edge-finish-kind-rejected:expected-Chamfer");+ if (!double.IsFinite(input.Width) || !double.IsFinite(input.Depth) || !double.IsFinite(input.Height) || input.Width <= Tol || input.Depth <= Tol || input.Height <= Tol)+ return (AirFeatureAdmissionStatus.Rejected, "air-chamfer-invalid-host-dimensions-rejected");+ if (!double.IsFinite(input.Distance) || input.Distance <= Tol) return (AirFeatureAdmissionStatus.Rejected, "air-chamfer-distance-must-be-positive");+ if (input.Distance >= input.Width / 2d - Tol || input.Distance >= input.Depth / 2d - Tol || input.Distance >= input.Height - Tol)+ return (AirFeatureAdmissionStatus.Rejected, "air-chamfer-distance-too-large-rejected");+ return (AirFeatureAdmissionStatus.Admitted, "air-chamfer-bounded-top-face-boundary-admitted");+ }+}diff --git a/Aetheris.Kernel.Core/Brep/Prismatic/PrismaticSectionTransitionEmitter.cs b/Aetheris.Kernel.Core/Brep/Prismatic/PrismaticSectionTransitionEmitter.csindex b0b893dc..236c63e5 100644--- a/Aetheris.Kernel.Core/Brep/Prismatic/PrismaticSectionTransitionEmitter.cs+++ b/Aetheris.Kernel.Core/Brep/Prismatic/PrismaticSectionTransitionEmitter.cs@@ -73,7 +73,16 @@ internal static class PrismaticSectionTransitionEmitterprivate static readonly string[] RequiredStepMarkers = ["ISO-10303-21", "MANIFOLD_SOLID_BREP", "ADVANCED_FACE", "PLANE"];private static readonly string[] ForbiddenStepMarkers = ["CYLINDRICAL_SURFACE", "BREP_WITH_VOIDS"];- public static PrismaticSectionTransitionResult Emit(PrismaticSectionTransitionRequest request)+ public static PrismaticSectionTransitionResult Emit(PrismaticSectionTransitionRequest request) => EmitCore(request, null);++ public static PrismaticSectionTransitionResult Emit(+ PrismaticSectionTransitionTopologyPlan authoritativePlan,+ PrismaticSectionTransitionOptions? options = null) =>+ EmitCore(authoritativePlan.Construction with { Options = options ?? authoritativePlan.Construction.Options }, authoritativePlan);++ private static PrismaticSectionTransitionResult EmitCore(+ PrismaticSectionTransitionRequest request,+ PrismaticSectionTransitionTopologyPlan? authoritativePlan){var diagnostics = new List<string> { "edge-prismatic-v1-emitter-started" };if (!string.IsNullOrWhiteSpace(request.Options?.TraceLabel))@@ -93,7 +102,17 @@ internal static class PrismaticSectionTransitionEmitterdiagnostics.Add("edge-prismatic-v1-transition-interval-created");}- var built = TryBuildBody(request.Sections, request.Correspondence!);+ var realizationPlan = authoritativePlan ?? PrismaticSectionTransitionTopologyPlanner.Create(request);+ if (realizationPlan.SplitPolicy != PrismaticSectionTransitionTopologyPlanner.PreserveSectionSplits)+ {+ diagnostics.Add("edge-prismatic-v1-request-rejected:unsupported-split-policy");+ return Stop(PrismaticSectionTransitionStatus.Rejected, diagnostics, "prismatic-section-transition-invalid-rejected");+ }++ diagnostics.Add(authoritativePlan is null+ ? "edge-prismatic-v1-topology-plan-created"+ : "edge-prismatic-v1-authoritative-topology-plan-consumed");+ var built = TryBuildBody(realizationPlan);if (built.Body is null){diagnostics.Add($"edge-prismatic-v1-request-rejected:{built.Diagnostic}");@@ -337,50 +356,24 @@ internal static class PrismaticSectionTransitionEmitter&& topology.CoedgeCount == (2 * n) + (4 * (sectionCount - 1) * n);}- private static (BrepBody? Body, string Diagnostic) TryBuildBody(IReadOnlyList<PrismaticSection> sections, PrismaticCorrespondenceMap correspondence)+ private static (BrepBody? Body, string Diagnostic) TryBuildBody(PrismaticSectionTransitionTopologyPlan plan){- _ = correspondence;+ var sections = plan.Construction.Sections;var n = sections[0].OuterLoop.Count;- var points = sections- .SelectMany(s => s.OuterLoop.Select(p => new Point3D(p.X, p.Y, s.Z)))- .ToArray();+ var points = plan.Vertices.Select(v => v.Point).ToArray();var b = new TopologyBuilder();var vertices = points.Select(_ => b.AddVertex()).ToArray();- var profileEdges = new EdgeId[sections.Count][];- for (var s = 0; s < sections.Count; s++)- {- profileEdges[s] = new EdgeId[n];- for (var i = 0; i < n; i++)- {- profileEdges[s][i] = b.AddEdge(vertices[(s * n) + i], vertices[(s * n) + ((i + 1) % n)]);- }- }-- var transitionEdges = new EdgeId[sections.Count - 1][];- for (var s = 0; s < sections.Count - 1; s++)+ var edges = new EdgeId[plan.Edges.Count];+ for (var i = 0; i < plan.Edges.Count; i++){- transitionEdges[s] = new EdgeId[n];- for (var i = 0; i < n; i++)- {- transitionEdges[s][i] = b.AddEdge(vertices[(s * n) + i], vertices[((s + 1) * n) + i]);- }+ var edge = plan.Edges[i];+ edges[i] = b.AddEdge(vertices[edge.StartVertexIndex], vertices[edge.EndVertexIndex]);}- var faces = new List<FaceId>- {- AddFaceWithLoop(b, profileEdges[0].Select(Use.F).ToArray()),- AddFaceWithLoop(b, profileEdges[^1].Select(Use.R).ToArray()),- };-- for (var s = 0; s < sections.Count - 1; s++)- {- for (var i = 0; i < n; i++)- {- var next = (i + 1) % n;- faces.Add(AddFaceWithLoop(b, [Use.F(profileEdges[s][i]), Use.F(transitionEdges[s][next]), Use.R(profileEdges[s + 1][i]), Use.R(transitionEdges[s][i])]));- }- }+ var faces = plan.Faces+ .Select(face => AddFaceWithLoop(b, face.Boundary.Select(use => new Use(edges[use.EdgeIndex], use.Reversed)).ToArray()))+ .ToList();var shell = b.AddShell(faces);b.AddBody([shell]);diff --git a/Aetheris.Kernel.Core/Brep/Prismatic/PrismaticSectionTransitionTopologyPlan.cs b/Aetheris.Kernel.Core/Brep/Prismatic/PrismaticSectionTransitionTopologyPlan.csnew file mode 100644index 00000000..f44a4df7--- /dev/null+++ b/Aetheris.Kernel.Core/Brep/Prismatic/PrismaticSectionTransitionTopologyPlan.cs@@ -0,0 +1,83 @@+using Aetheris.Kernel.Core.Math;++namespace Aetheris.Kernel.Core.Brep.Prismatic;++internal enum PrismaticPlannedEdgeKind { Section, Transition }+internal enum PrismaticPlannedFaceKind { BottomCap, TopCap, StableSide, Transition }+internal readonly record struct PrismaticPlannedEdgeUse(int EdgeIndex, bool Reversed);+internal sealed record PrismaticPlannedVertex(string Id, int SectionIndex, int ProfileVertexIndex, Point3D Point);+internal sealed record PrismaticPlannedEdge(string Id, PrismaticPlannedEdgeKind Kind, int StartVertexIndex, int EndVertexIndex, int? SectionIndex, int? IntervalIndex, int ProfileEdgeIndex);+internal sealed record PrismaticPlannedFace(string Id, PrismaticPlannedFaceKind Kind, IReadOnlyList<PrismaticPlannedEdgeUse> Boundary, int? IntervalIndex, int? ProfileEdgeIndex);++/// <summary>Immutable topology authority consumed by both AIR BRepPlan reporting and BRep materialization.</summary>+internal sealed record PrismaticSectionTransitionTopologyPlan(+ PrismaticSectionTransitionRequest Construction,+ IReadOnlyList<PrismaticPlannedVertex> Vertices,+ IReadOnlyList<PrismaticPlannedEdge> Edges,+ IReadOnlyList<PrismaticPlannedFace> Faces,+ string SplitPolicy,+ string DeterministicSignature)+{+ public int ExpectedLoopCount => Faces.Count;+ public int ExpectedCoedgeCount => Faces.Sum(face => face.Boundary.Count);+}++internal static class PrismaticSectionTransitionTopologyPlanner+{+ public const string PreserveSectionSplits = "preserve-section-splits";++ public static PrismaticSectionTransitionTopologyPlan Create(PrismaticSectionTransitionRequest request)+ {+ ArgumentNullException.ThrowIfNull(request);+ var sections = request.Sections;+ if (sections.Count < 2 || sections.Select(s => s.OuterLoop.Count).Distinct().Count() != 1)+ throw new ArgumentException("A topology plan requires at least two equal-cardinality sections.", nameof(request));++ var n = sections[0].OuterLoop.Count;+ var vertices = new List<PrismaticPlannedVertex>(sections.Count * n);+ for (var s = 0; s < sections.Count; s++)+ for (var i = 0; i < n; i++)+ {+ var p = sections[s].OuterLoop[i];+ vertices.Add(new($"v:s{s}:{i}", s, i, new Point3D(p.X, p.Y, sections[s].Z)));+ }++ var edges = new List<PrismaticPlannedEdge>();+ var sectionEdges = new int[sections.Count, n];+ for (var s = 0; s < sections.Count; s++)+ for (var i = 0; i < n; i++)+ {+ sectionEdges[s, i] = edges.Count;+ edges.Add(new($"e:section:{s}:{i}", PrismaticPlannedEdgeKind.Section, (s * n) + i, (s * n) + ((i + 1) % n), s, null, i));+ }++ var transitionEdges = new int[sections.Count - 1, n];+ for (var s = 0; s < sections.Count - 1; s++)+ for (var i = 0; i < n; i++)+ {+ transitionEdges[s, i] = edges.Count;+ edges.Add(new($"e:transition:{s}:{i}", PrismaticPlannedEdgeKind.Transition, (s * n) + i, ((s + 1) * n) + i, null, s, i));+ }++ var faces = new List<PrismaticPlannedFace>+ {+ new("f:cap:bottom", PrismaticPlannedFaceKind.BottomCap, Enumerable.Range(0, n).Select(i => new PrismaticPlannedEdgeUse(sectionEdges[0, i], false)).ToArray(), null, null),+ new("f:cap:top", PrismaticPlannedFaceKind.TopCap, Enumerable.Range(0, n).Select(i => new PrismaticPlannedEdgeUse(sectionEdges[sections.Count - 1, i], true)).ToArray(), null, null),+ };+ for (var s = 0; s < sections.Count - 1; s++)+ for (var i = 0; i < n; i++)+ {+ var next = (i + 1) % n;+ var kind = sections[s].OuterLoop[i] == sections[s + 1].OuterLoop[i] && sections[s].OuterLoop[next] == sections[s + 1].OuterLoop[next]+ ? PrismaticPlannedFaceKind.StableSide+ : PrismaticPlannedFaceKind.Transition;+ faces.Add(new($"f:{(kind == PrismaticPlannedFaceKind.StableSide ? "side" : "transition")}:interval{s}:edge{i}", kind,+ [new(sectionEdges[s, i], false), new(transitionEdges[s, next], false), new(sectionEdges[s + 1, i], true), new(transitionEdges[s, i], true)], s, i));+ }++ var signature = string.Join("|", vertices.Select(v => FormattableString.Invariant($"{v.Id}:{v.Point.X:R},{v.Point.Y:R},{v.Point.Z:R}"))+ .Concat(edges.Select(e => $"{e.Id}:{e.StartVertexIndex}>{e.EndVertexIndex}"))+ .Concat(faces.Select(f => $"{f.Id}:{string.Join(',', f.Boundary.Select(u => $"{u.EdgeIndex}:{(u.Reversed ? 'R' : 'F')}"))}")));+ return new(request, vertices, edges, faces, PreserveSectionSplits, signature);+ }+}diff --git a/Aetheris.Kernel.Firmament.Tests/AirTopFaceBoundaryChamferProductionTests.cs b/Aetheris.Kernel.Firmament.Tests/AirTopFaceBoundaryChamferProductionTests.csnew file mode 100644index 00000000..aff9339e--- /dev/null+++ b/Aetheris.Kernel.Firmament.Tests/AirTopFaceBoundaryChamferProductionTests.cs@@ -0,0 +1,87 @@+using Aetheris.Kernel.Core.Air;+using Aetheris.Kernel.Core.Brep.Prismatic;+using Aetheris.Kernel.Firmament.FirmamentV2;++namespace Aetheris.Kernel.Firmament.Tests;++public sealed class AirTopFaceBoundaryChamferProductionTests+{+ [Fact]+ public void FirmamentV2_Phase3PascalCase_ProducesSemanticFeatureWithSourceSpan()+ {+ var parsed = FirmamentV2Parser.Parse(Source(10, 8, 6, 1));++ Assert.True(parsed.IsSuccess, string.Join(", ", parsed.Diagnostics));+ var finish = Assert.Single(Assert.Single(parsed.Document!.ModifyBlocks!).EdgeFinishes!);+ Assert.Equal("TopBreak", finish.Name);+ Assert.Equal("+Z", finish.FaceAxis);+ Assert.Equal("Boundary", finish.Target);+ Assert.Equal("Chamfer", finish.Kind);+ Assert.Equal(1, finish.Distance);+ Assert.True(finish.SourceSpan.Length > 0);+ }++ [Theory]+ [InlineData(10, 8, 6, 1)]+ [InlineData(10, 8, 6, 2)]+ [InlineData(12, 5, 7, 1)]+ public void AirCompiler_AdmittedMatrix_ConsumesAuthoritativePlanAndMeasuresExactInset(double width, double depth, double height, double distance)+ {+ var result = AirTopFaceBoundaryChamferCompiler.Compile(Request(width, depth, height, distance));++ Assert.True(result.Succeeded, string.Join(Environment.NewLine, result.Diagnostics));+ Assert.Equal(AirFeatureAdmissionStatus.Admitted, result.Feature.Admission);+ Assert.Equal("+Z", result.Feature.Selection.FaceAxis);+ Assert.Equal(distance, result.Feature.Rule.Distance);+ Assert.Equal(3, result.Construction!.Profiles.Count);+ Assert.Equal([0, height - distance, height], result.Construction.Profiles.Select(p => p.Z));+ Assert.Equal("identity-by-profile-index", result.Construction.Transition.Correspondence);+ Assert.Equal(PrismaticSectionTransitionTopologyPlanner.PreserveSectionSplits, result.Construction.Transition.SplitPolicy);+ Assert.True(result.BRepPlan!.IsAuthoritative);+ Assert.NotNull(result.BRepPlan.RealizationPlan);+ Assert.Equal(12, result.BRepPlan.RealizationPlan!.Vertices.Count);+ Assert.Equal(20, result.BRepPlan.RealizationPlan.Edges.Count);+ Assert.Equal(10, result.BRepPlan.RealizationPlan.Faces.Count);+ Assert.Equal(12, result.Body!.Topology.Vertices.Count());+ Assert.Equal(20, result.Body.Topology.Edges.Count());+ Assert.Equal(10, result.Body.Topology.Faces.Count());+ Assert.Contains("edge-prismatic-v1-authoritative-topology-plan-consumed", result.Diagnostics);++ var top = result.BRepPlan.RealizationPlan.Vertices.Where(v => v.SectionIndex == 2).Select(v => v.Point).ToArray();+ Assert.Equal((-width / 2d) + distance, top.Min(p => p.X), 9);+ Assert.Equal((width / 2d) - distance, top.Max(p => p.X), 9);+ Assert.Equal((-depth / 2d) + distance, top.Min(p => p.Y), 9);+ Assert.Equal((depth / 2d) - distance, top.Max(p => p.Y), 9);+ }++ [Theory]+ [InlineData(0, "+Z", "Boundary", "air-chamfer-distance-must-be-positive")]+ [InlineData(4, "+Z", "Boundary", "air-chamfer-distance-too-large-rejected")]+ [InlineData(1, "-Z", "Boundary", "air-chamfer-unsupported-face-rejected:expected-+Z")]+ [InlineData(1, "+Z", "SingleEdge", "air-chamfer-unsupported-selection-rejected:expected-Boundary")]+ public void AirCompiler_UnsupportedDomain_IsExplicitlyRejected(double distance, string face, string target, string reason)+ {+ var request = Request(10, 8, 6, distance) with { FaceAxis = face, Target = target };+ var result = AirTopFaceBoundaryChamferCompiler.Compile(request);+ Assert.False(result.Succeeded);+ Assert.Equal(AirFeatureAdmissionStatus.Rejected, result.Feature.Admission);+ Assert.Equal(reason, result.Feature.AdmissionReason);+ Assert.Null(result.Body);+ }++ private static AirTopFaceBoundaryChamferCompileRequest Request(double width, double depth, double height, double distance) =>+ new("Base", "Base.TopBreak", "TopBreak", width, depth, height, "+Z", "Boundary", "Chamfer", distance, new AirSourceSpan(10, 20, "test"));++ private static string Source(double width, double depth, double height, double distance) => $$"""+ Model Test mm+ Box Base { Size: [{{width}}mm, {{depth}}mm, {{height}}mm] }+ Modify Base {+ EdgeFinish TopBreak {+ Face: +Z+ Target: Boundary+ Kind: Chamfer+ Distance: {{distance}}mm+ }+ }+ """;+}diff --git a/Aetheris.Kernel.Firmament/FirmamentBuildAndExport.cs b/Aetheris.Kernel.Firmament/FirmamentBuildAndExport.csindex 3f4e16f4..5cb6446e 100644--- a/Aetheris.Kernel.Firmament/FirmamentBuildAndExport.cs+++ b/Aetheris.Kernel.Firmament/FirmamentBuildAndExport.cs@@ -1,4 +1,6 @@using System.Text;+using System.Security.Cryptography;+using Aetheris.Kernel.Core.Air;using Aetheris.Kernel.Core.Results;using Aetheris.Kernel.Core.Step242;using Aetheris.Kernel.Core.Brep;@@ -55,6 +57,11 @@ public static class FirmamentBuildAndExportreturn KernelResult<FirmamentStepExportResult>.Failure(dfm.Diagnostics);}+ if (TryExportV2AirChamferBody(v2Parse.Document) is { } airChamferExport)+ {+ return airChamferExport;+ }+if (TryExportV2SemanticHoleBody(v2Parse.Document) is { } semanticHoleExport){return semanticHoleExport;@@ -132,6 +139,75 @@ public static class FirmamentBuildAndExportreturn FirmamentStepExporter.Export(new FirmamentCompileRequest(new FirmamentSourceDocument(sourceText)));}+ private static KernelResult<FirmamentStepExportResult>? TryExportV2AirChamferBody(FirmamentV2Document document)+ {+ var finishes = (document.ModifyBlocks ?? []).SelectMany(m => (m.EdgeFinishes ?? []).Select(f => (Modify: m, Finish: f))).ToArray();+ if (finishes.Length == 0) return null;+ if (finishes.Length != 1 || document.Solids.Count != 1 || document.ModifyBlocks!.Count != 1+ || document.ModifyBlocks[0].Regions.Count != 0 || document.ModifyBlocks[0].SemanticHoles.Count != 0)+ return AirChamferFailure("air-chamfer-production-route-requires-one-box-and-one-edge-finish");++ var (modify, finish) = finishes[0];+ var solid = document.Solids.SingleOrDefault(s => s.Name == modify.TargetSolid);+ if (solid?.Primitive is not FirmamentV2BoxRecord box || box.Size.Count != 3)+ return AirChamferFailure("air-chamfer-history-known-rectangular-prism-required");++ var compiled = AirTopFaceBoundaryChamferCompiler.Compile(new(+ solid.Name,+ $"{solid.Name}.{finish.Name}",+ finish.Name,+ box.Size[0], box.Size[1], box.Size[2],+ finish.FaceAxis, finish.Target, finish.Kind, finish.Distance,+ new AirSourceSpan(finish.SourceSpan.Start, finish.SourceSpan.Length, document.ModelName)));+ if (!compiled.Succeeded || compiled.Body is null || compiled.Construction is null || compiled.BRepPlan?.RealizationPlan is null || compiled.Topology is null)+ return AirChamferFailure(compiled.Feature.AdmissionReason, compiled.Diagnostics);++ var manifold = FirmamentManifoldChecker.IsManifold(compiled.Body);+ if (!manifold) return AirChamferFailure("air-chamfer-emitted-body-is-not-manifold", compiled.Diagnostics);++ var step = Step242Exporter.ExportBody(compiled.Body, new Step242ExportOptions+ {+ ProductName = compiled.Feature.FeatureName,+ ApplicationName = AirTopFaceBoundaryChamferCompileResult.ProductionRoute,+ });+ if (!step.IsSuccess || step.Value is null) return KernelResult<FirmamentStepExportResult>.Failure(step.Diagnostics);++ var reimport = Step242Importer.ImportBody(step.Value);+ if (!reimport.IsSuccess || reimport.Value is null) return KernelResult<FirmamentStepExportResult>.Failure(reimport.Diagnostics);+ var reimported = reimport.Value;+ var reimportedManifold = FirmamentManifoldChecker.IsManifold(reimported);+ if (!reimportedManifold) return AirChamferFailure("air-chamfer-step-reimport-is-not-manifold");++ var plan = compiled.BRepPlan.RealizationPlan;+ var top = plan.Vertices.Where(v => v.SectionIndex == 2).Select(v => v.Point).ToArray();+ var sourceBounds = Bounds(compiled.Body);+ var reimportedBounds = Bounds(reimported);+ var report = new FirmamentAirChamferReport(+ new("Chamfer", compiled.Feature.BodyId, compiled.Feature.FeatureId, compiled.Feature.FeatureName, $"FaceBoundary({compiled.Feature.Selection.FaceAxis})", compiled.Feature.Rule.Distance, compiled.Feature.Rule.Unit, $"{compiled.Feature.SourceSpan.Start}:{compiled.Feature.SourceSpan.Length}", compiled.Feature.Admission.ToString(), compiled.Feature.AdmissionReason),+ new("SectionTransition", compiled.Construction.Profiles.Count, compiled.Construction.Profiles.Select(p => p.Z).ToArray(), compiled.Construction.Transition.Correspondence, compiled.Construction.Transition.SplitPolicy),+ new(compiled.BRepPlan.IsAuthoritative, plan.Vertices.Count, plan.Edges.Count, plan.Faces.Count, plan.ExpectedLoopCount, plan.ExpectedCoedgeCount, compiled.BRepPlan.Summary.ChamferFaceCount, plan.SplitPolicy, plan.DeterministicSignature),+ new(AirTopFaceBoundaryChamferCompileResult.ProductionRoute, false, manifold, compiled.Topology.VertexCount, compiled.Topology.EdgeCount, compiled.Topology.FaceCount, sourceBounds,+ top.Min(p => p.X) - (-box.Size[0] / 2d), top.Min(p => p.Y) - (-box.Size[1] / 2d)),+ new("AP242", Convert.ToHexString(SHA256.HashData(Encoding.UTF8.GetBytes(step.Value))), true,+ reimported.Topology.Vertices.Count(), reimported.Topology.Edges.Count(), reimported.Topology.Faces.Count(), reimportedBounds, reimportedManifold));++ return KernelResult<FirmamentStepExportResult>.Success(new FirmamentStepExportResult(+ step.Value, compiled.Feature.FeatureId, 0, "air-chamfer", "top-face-boundary-chamfer", Air: report));+ }++ private static string Bounds(BrepBody body)+ {+ var points = body.Topology.Vertices.Select(v => body.TryGetVertexPoint(v.Id, out var point) ? point : throw new InvalidOperationException($"Missing point for vertex {v.Id}.")).ToArray();+ return FormattableString.Invariant($"[{points.Min(p => p.X):0.###},{points.Min(p => p.Y):0.###},{points.Min(p => p.Z):0.###}]..[{points.Max(p => p.X):0.###},{points.Max(p => p.Y):0.###},{points.Max(p => p.Z):0.###}]");+ }++ private static KernelResult<FirmamentStepExportResult> AirChamferFailure(string primary, IEnumerable<string>? details = null) =>+ KernelResult<FirmamentStepExportResult>.Failure((new[] { primary }).Concat(details ?? []).Distinct().Select(message => new Kernel.Core.Diagnostics.KernelDiagnostic(+ Kernel.Core.Diagnostics.KernelDiagnosticCode.ValidationFailed,+ Kernel.Core.Diagnostics.KernelDiagnosticSeverity.Error,+ message,+ "FirmamentV2.AirChamfer")).ToArray());+private static KernelResult<FirmamentStepExportResult>? TryExportV2InlineStepReplacementBody(FirmamentV2Document document){if (document.Replacements is not { Count: 1 } replacements || document.Solids.Count != 1)diff --git a/Aetheris.Kernel.Firmament/FirmamentStepExportResult.cs b/Aetheris.Kernel.Firmament/FirmamentStepExportResult.csindex fb4106e4..75943866 100644--- a/Aetheris.Kernel.Firmament/FirmamentStepExportResult.cs+++ b/Aetheris.Kernel.Firmament/FirmamentStepExportResult.cs@@ -11,7 +11,21 @@ public sealed record FirmamentStepExportResult(IReadOnlyList<FirmamentPmiInspectionDatum>? DatumInspection = null,IReadOnlyList<FirmamentPmiInspectionDimension>? DimensionInspection = null,Aetheris.Kernel.Firmament.FirmamentV2.InlineStepMigrationReport? InlineStepMigration = null,- Aetheris.Kernel.Firmament.FirmamentV2.InlineStepReplacementAssistReport? InlineStepReplacementAssist = null);+ Aetheris.Kernel.Firmament.FirmamentV2.InlineStepReplacementAssistReport? InlineStepReplacementAssist = null,+ FirmamentAirChamferReport? Air = null);++public sealed record FirmamentAirChamferReport(+ FirmamentAirChamferFeatureReport Feature,+ FirmamentAirChamferConstructionReport Construction,+ FirmamentAirChamferBRepPlanReport BRepPlan,+ FirmamentAirChamferMaterializationReport Materialization,+ FirmamentAirChamferStepReport Step);++public sealed record FirmamentAirChamferFeatureReport(string Kind, string Body, string FeatureId, string FeatureName, string Selection, double Distance, string Unit, string SourceSpan, string Admission, string AdmissionReason);+public sealed record FirmamentAirChamferConstructionReport(string Kind, int SectionCount, IReadOnlyList<double> SectionZ, string Correspondence, string SplitPolicy);+public sealed record FirmamentAirChamferBRepPlanReport(bool Authoritative, int ExpectedVertices, int ExpectedEdges, int ExpectedFaces, int ExpectedLoops, int ExpectedCoedges, int ChamferFaces, string SplitPolicy, string DeterministicSignature);+public sealed record FirmamentAirChamferMaterializationReport(string Route, bool LegacyFallback, bool EnclosedManifold, int Vertices, int Edges, int Faces, string Bounds, double MeasuredTopInsetX, double MeasuredTopInsetY);+public sealed record FirmamentAirChamferStepReport(string Schema, string Sha256, bool ReimportSucceeded, int ReimportedVertices, int ReimportedEdges, int ReimportedFaces, string ReimportedBounds, bool ReimportedManifold);public sealed record FirmamentPmiInspectionDatum(string Label,diff --git a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.csindex 8ee27e7b..82a2516e 100644--- a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs+++ b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs@@ -90,10 +90,21 @@ public sealed record FirmamentV2FaceSelector(string Axis){public string Source => $"face({Axis})";}-public sealed record FirmamentV2ModifyBlock(string TargetSolid, IReadOnlyList<FirmamentV2RegionDecl> Regions, IReadOnlyList<FirmamentV2SemanticHoleDecl> SemanticHoles)+public sealed record FirmamentV2ModifyBlock(+ string TargetSolid,+ IReadOnlyList<FirmamentV2RegionDecl> Regions,+ IReadOnlyList<FirmamentV2SemanticHoleDecl> SemanticHoles,+ IReadOnlyList<FirmamentV2EdgeFinishDecl>? EdgeFinishes = null){public FirmamentV2ModifyBlock(string TargetSolid, IReadOnlyList<FirmamentV2RegionDecl> Regions) : this(TargetSolid, Regions, []) { }}+public sealed record FirmamentV2EdgeFinishDecl(+ string Name,+ string FaceAxis,+ string Target,+ string Kind,+ double Distance,+ FirmamentV2SourceSpan SourceSpan);public sealed record FirmamentV2RegionDecl(string Name, string Kind, FirmamentV2FaceTarget Attachment, FirmamentV2CutOperation Cut);public sealed record FirmamentV2CutOperation(string OperationKind, FirmamentV2CylinderTool Tool);public sealed record FirmamentV2CylinderTool(string ToolType, double Radius, FirmamentV2FaceLocalPoint2D? Center, FirmamentV2FaceTarget Through);diff --git a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.csindex 80b0e9a7..1e19df83 100644--- a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs+++ b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs@@ -38,6 +38,7 @@ public static class FirmamentV2Parserpublic const string RawBackendIdReferenceForbidden = "firmament-raw-backend-id-reference-forbidden";public const string DfmConceptUnitMismatch = "firmament-v2-dfm-concept-unit-mismatch";public const string DfmMinimumToolRadiusViolation = "firmament-v2-dfm-minimum-tool-radius-violation";+ public const string Phase3EdgeFinishSyntaxInvalid = "firmament-v2-phase3-edge-finish-syntax-invalid";public const string ConceptUnknownFamily = "firmament-v2-concept-unknown-family";public const string ConceptUnknownConcept = "firmament-v2-concept-unknown-concept";@@ -225,6 +226,9 @@ public static class FirmamentV2Parservar source = StripLineComments(sourceText);conceptCatalog ??= FirmamentV2ForgeConceptRegistry.Catalog;+ if (Regex.IsMatch(source, @"^\s*Model\b", RegexOptions.CultureInvariant))+ return ParsePhase3ModelingDocument(source, diagnostics);+if (ContainsRawBackendId(source)) diagnostics.Add(RawBackendIdReferenceForbidden);if (ContainsUnsupportedConstruct(source)) diagnostics.Add(UnsupportedConstruct);@@ -699,7 +703,65 @@ public static class FirmamentV2Parserreturn new(name, "Box", new FirmamentV2BoxRecord(values, []), baseName, new Dictionary<string, IReadOnlyList<double>>(StringComparer.Ordinal) { ["size"] = values });}- public static bool IsFatalDiagnosticCode(string code) => code is PrimitiveFieldMissing or PrimitiveFieldUnknown or PrimitiveFieldInvalid or MissingModel or MissingUnits or MissingSolid or UnsupportedConstruct or UnknownRecordType or BoxMissingSize or BoxSizeArity or DegenerateDimension or NameUnresolved or DuplicateName or WithRequiresRecord or WithRequiresBoxRecord or WithFieldNotFound or WithFieldTypeMismatch or WithForwardReference or WithDerivedRecordInvalid or ExposeBlockUnsupported or ExposeRequiresBoxRecord or ExposeAliasDuplicate or ExposeAliasInvalid or SelectorUnsupported or SelectorAxisInvalid or SelectorSubselectorUnsupported or FatArrowOutsideExpose or RawBackendIdReferenceForbidden or ModifyTargetUnresolved or ModifyTargetNotSolid or RegionUnsupported or RegionAttachmentSelectorUnsupported or CutUnsupported or CutToolUnsupported or CylinderRadiusMissing or CylinderRadiusInvalid or CylinderRadiusNotFinite or ThroughSelectorUnsupported or AliasUnresolved or AliasRefTypeUnsupported or SideHoleAliasMustResolveToFace or SideHoleAliasResolvesToUnsupportedFace or SideHoleOnlyPlusXMinusXSupported or SideHoleRouteUnsupported or SideHoleSameFaceUnsupported or SideHoleAxisNotYetSupported or SideHoleRadiusExceedsClearance or CylinderCenterInvalid or CylinderCenterArityInvalid or CylinderCenterNotFinite or SideHoleCenterExceedsClearance or HoleVariantUnknown or HoleEntryFaceMissing or HoleCenterMissing or HoleShaftMissing or HoleEndMissing or HoleDiameterInvalid or HoleDepthInvalid or HoleCounterboreInvalid or HoleCountersinkInvalid or PmiKindUnknown or PmiTargetMissing or PmiTargetUnresolved or PmiDiameterInvalid or PmiDuplicateName or InlineStepUnknownBody or InlineStepUnknownFace or PmiImportedTargetNotFace or PmiImportedTargetRequiresCanonicalStep or PmiInvalidImportedTarget or InlineStepPathMissing or InlineStepPathInvalid or InlineStepFileMissing or InlineStepRequiresCanonical or UnknownRecognitionBody or UnknownRecognitionFace or DuplicateRegion or UnknownRecognitionRegion or InvalidRecognitionKind or InvalidRecognitionConfidence or PmiRecognizedRegionKindMismatch or UnknownReplacementBody or UnknownReplacementRegion or ReplacementKindMismatch or ReplacementFaceUnresolved or ReplacementUnsupportedKind or ReplacementVerificationFailed or ReplacementRadiusInvalid or ReplacementEndUnsupported or LetDuplicateName or LetUnknownType or LetTypeMismatch or LetInvalidLiteral or LetUnitMismatch or LetLiteralOnly or LetRecordDuplicateName or LetRecordDuplicateField or LetReferenceUnknownRecord or LetReferenceUnknownField or LetReferenceNonRecord or LetReferenceRecordUsedAsValue or ExpressionUnknownSymbol or ExpressionUnknownRecord or ExpressionUnknownField or ExpressionRecordUsedAsValue or ExpressionScalarUsedAsRecord or ExpressionTypeMismatch or ExpressionInvalidOperator or ExpressionDivisionByZero or ExpressionCycle or ExpressionUnsupported or ToleranceInvalidType or ToleranceUnitMismatch or ToleranceInvalidLiteral or ToleranceNegativeBilateral or ToleranceMissingMinus or ToleranceMissingPlus or ToleranceUnsupported or RecognitionEvidenceRadiusInvalid or RecognitionEvidenceSurfaceFamilyUnknown or RecognitionEvidenceAxisInvalid or SemanticProposalKindMismatch or SemanticProposalRadiusInvalid or SemanticProposalTargetUnresolved or SemanticProposalEndUnsupported or ConceptUnknownFamily or ConceptUnknownConcept or ConceptMissingRequiredField or ConceptUnknownField or ConceptDuplicateField or ConceptFieldTypeMismatch or ConceptInvalidTarget or ConceptDescriptorUnavailable or PmiDuplicateBlock or PmiDuplicateRecord or PmiDuplicateDatum or PmiUnknownRecordKind or PmiMissingRequiredField or PmiUnknownField or PmiDuplicateField or PmiInvalidTarget or PmiUnknownDatum or PmiDimensionTypeMismatch or PmiDimensionMissingTolerance or PmiToleranceTypeMismatch;+ private static FirmamentV2ParseResult ParsePhase3ModelingDocument(string source, List<string> diagnostics)+ {+ var model = Regex.Match(source, @"^\s*Model\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s+(?<units>[A-Za-z_][A-Za-z0-9_]*)\b", RegexOptions.CultureInvariant);+ var box = Regex.Match(source, @"\bBox\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);+ var modify = Regex.Match(source, @"\bModify\s+(?<target>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);+ var edge = Regex.Match(source, @"\bEdgeFinish\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);+ if (!model.Success || !box.Success || !modify.Success || !edge.Success || model.Groups["units"].Value != "mm"+ || Regex.Matches(source, @"\bBox\s+[A-Za-z_]", RegexOptions.CultureInvariant).Count != 1+ || Regex.Matches(source, @"\bModify\s+[A-Za-z_]", RegexOptions.CultureInvariant).Count != 1+ || Regex.Matches(source, @"\bEdgeFinish\s+[A-Za-z_]", RegexOptions.CultureInvariant).Count != 1)+ diagnostics.Add(Phase3EdgeFinishSyntaxInvalid);++ if (diagnostics.Contains(Phase3EdgeFinishSyntaxInvalid))+ return FirmamentV2ParseResult.Failure(diagnostics.Append("firmament-v2-parse-failed").Order().ToArray());++ var boxOpen = source.IndexOf('{', box.Index);+ var boxClose = FindMatchingBrace(source, boxOpen);+ var modifyOpen = source.IndexOf('{', modify.Index);+ var modifyClose = FindMatchingBrace(source, modifyOpen);+ var edgeOpen = source.IndexOf('{', edge.Index);+ var edgeClose = FindMatchingBrace(source, edgeOpen);+ if (boxClose < 0 || modifyClose < 0 || edgeClose < 0 || edge.Index < modifyOpen || edgeClose > modifyClose)+ {+ diagnostics.Add(Phase3EdgeFinishSyntaxInvalid);+ return FirmamentV2ParseResult.Failure(diagnostics.Append("firmament-v2-parse-failed").Order().ToArray());+ }++ var sizeMatch = Regex.Match(source[(boxOpen + 1)..boxClose], @"\bSize\s*:\s*\[(?<values>[^\]]+)\]", RegexOptions.CultureInvariant);+ var values = sizeMatch.Success ? sizeMatch.Groups["values"].Value.Split(',').Select(ParsePhase3Length).ToArray() : [];+ var edgeBody = source[(edgeOpen + 1)..edgeClose];+ var face = Regex.Match(edgeBody, @"\bFace\s*:\s*(?<value>[+-][XYZ])", RegexOptions.CultureInvariant);+ var target = Regex.Match(edgeBody, @"\bTarget\s*:\s*(?<value>[A-Za-z_][A-Za-z0-9_]*)", RegexOptions.CultureInvariant);+ var kind = Regex.Match(edgeBody, @"\bKind\s*:\s*(?<value>[A-Za-z_][A-Za-z0-9_]*)", RegexOptions.CultureInvariant);+ var distance = Regex.Match(edgeBody, @"\bDistance\s*:\s*(?<value>[-+0-9.eE]+)mm\b", RegexOptions.CultureInvariant);+ if (values.Length != 3 || values.Any(v => !double.IsFinite(v) || v <= 0d) || !face.Success || !target.Success || !kind.Success || !distance.Success+ || !double.TryParse(distance.Groups["value"].Value, NumberStyles.Float, CultureInfo.InvariantCulture, out var distanceValue) || !double.IsFinite(distanceValue)+ || box.Groups["name"].Value != modify.Groups["target"].Value)+ {+ diagnostics.Add(Phase3EdgeFinishSyntaxInvalid);+ return FirmamentV2ParseResult.Failure(diagnostics.Append("firmament-v2-parse-failed").Order().ToArray());+ }++ var solid = new FirmamentV2SolidBinding(box.Groups["name"].Value, "Box", new FirmamentV2BoxRecord(values, []));+ var finish = new FirmamentV2EdgeFinishDecl(edge.Groups["name"].Value, face.Groups["value"].Value, target.Groups["value"].Value, kind.Groups["value"].Value, distanceValue, new FirmamentV2SourceSpan(edge.Index, edgeClose - edge.Index + 1));+ var document = new FirmamentV2Document(model.Groups["name"].Value, "mm", [solid], [new FirmamentV2ModifyBlock(solid.Name, [], [], [finish])]);+ diagnostics.Add("firmament-v2-phase3-edge-finish-parsed");+ diagnostics.Add("firmament-v2-parse-succeeded");+ diagnostics.Sort(StringComparer.Ordinal);+ return FirmamentV2ParseResult.Success(document, diagnostics);+ }++ private static double ParsePhase3Length(string source)+ {+ source = source.Trim();+ if (!source.EndsWith("mm", StringComparison.Ordinal)) return double.NaN;+ return double.TryParse(source[..^2], NumberStyles.Float, CultureInfo.InvariantCulture, out var value) ? value : double.NaN;+ }++ public static bool IsFatalDiagnosticCode(string code) => code is Phase3EdgeFinishSyntaxInvalid or PrimitiveFieldMissing or PrimitiveFieldUnknown or PrimitiveFieldInvalid or MissingModel or MissingUnits or MissingSolid or UnsupportedConstruct or UnknownRecordType or BoxMissingSize or BoxSizeArity or DegenerateDimension or NameUnresolved or DuplicateName or WithRequiresRecord or WithRequiresBoxRecord or WithFieldNotFound or WithFieldTypeMismatch or WithForwardReference or WithDerivedRecordInvalid or ExposeBlockUnsupported or ExposeRequiresBoxRecord or ExposeAliasDuplicate or ExposeAliasInvalid or SelectorUnsupported or SelectorAxisInvalid or SelectorSubselectorUnsupported or FatArrowOutsideExpose or RawBackendIdReferenceForbidden or ModifyTargetUnresolved or ModifyTargetNotSolid or RegionUnsupported or RegionAttachmentSelectorUnsupported or CutUnsupported or CutToolUnsupported or CylinderRadiusMissing or CylinderRadiusInvalid or CylinderRadiusNotFinite or ThroughSelectorUnsupported or AliasUnresolved or AliasRefTypeUnsupported or SideHoleAliasMustResolveToFace or SideHoleAliasResolvesToUnsupportedFace or SideHoleOnlyPlusXMinusXSupported or SideHoleRouteUnsupported or SideHoleSameFaceUnsupported or SideHoleAxisNotYetSupported or SideHoleRadiusExceedsClearance or CylinderCenterInvalid or CylinderCenterArityInvalid or CylinderCenterNotFinite or SideHoleCenterExceedsClearance or HoleVariantUnknown or HoleEntryFaceMissing or HoleCenterMissing or HoleShaftMissing or HoleEndMissing or HoleDiameterInvalid or HoleDepthInvalid or HoleCounterboreInvalid or HoleCountersinkInvalid or PmiKindUnknown or PmiTargetMissing or PmiTargetUnresolved or PmiDiameterInvalid or PmiDuplicateName or InlineStepUnknownBody or InlineStepUnknownFace or PmiImportedTargetNotFace or PmiImportedTargetRequiresCanonicalStep or PmiInvalidImportedTarget or InlineStepPathMissing or InlineStepPathInvalid or InlineStepFileMissing or InlineStepRequiresCanonical or UnknownRecognitionBody or UnknownRecognitionFace or DuplicateRegion or UnknownRecognitionRegion or InvalidRecognitionKind or InvalidRecognitionConfidence or PmiRecognizedRegionKindMismatch or UnknownReplacementBody or UnknownReplacementRegion or ReplacementKindMismatch or ReplacementFaceUnresolved or ReplacementUnsupportedKind or ReplacementVerificationFailed or ReplacementRadiusInvalid or ReplacementEndUnsupported or LetDuplicateName or LetUnknownType or LetTypeMismatch or LetInvalidLiteral or LetUnitMismatch or LetLiteralOnly or LetRecordDuplicateName or LetRecordDuplicateField or LetReferenceUnknownRecord or LetReferenceUnknownField or LetReferenceNonRecord or LetReferenceRecordUsedAsValue or ExpressionUnknownSymbol or ExpressionUnknownRecord or ExpressionUnknownField or ExpressionRecordUsedAsValue or ExpressionScalarUsedAsRecord or ExpressionTypeMismatch or ExpressionInvalidOperator or ExpressionDivisionByZero or ExpressionCycle or ExpressionUnsupported or ToleranceInvalidType or ToleranceUnitMismatch or ToleranceInvalidLiteral or ToleranceNegativeBilateral or ToleranceMissingMinus or ToleranceMissingPlus or ToleranceUnsupported or RecognitionEvidenceRadiusInvalid or RecognitionEvidenceSurfaceFamilyUnknown or RecognitionEvidenceAxisInvalid or SemanticProposalKindMismatch or SemanticProposalRadiusInvalid or SemanticProposalTargetUnresolved or SemanticProposalEndUnsupported or ConceptUnknownFamily or ConceptUnknownConcept or ConceptMissingRequiredField or ConceptUnknownField or ConceptDuplicateField or ConceptFieldTypeMismatch or ConceptInvalidTarget or ConceptDescriptorUnavailable or PmiDuplicateBlock or PmiDuplicateRecord or PmiDuplicateDatum or PmiUnknownRecordKind or PmiMissingRequiredField or PmiUnknownField or PmiDuplicateField or PmiInvalidTarget or PmiUnknownDatum or PmiDimensionTypeMismatch or PmiDimensionMissingTolerance or PmiToleranceTypeMismatch;private static IReadOnlyList<FirmamentV2Exposure> ParseExposures(string body, List<string> diagnostics){diff --git a/docs/implementation/air-chamfer-production-m1.md b/docs/implementation/air-chamfer-production-m1.mdnew file mode 100644index 00000000..df283c72--- /dev/null+++ b/docs/implementation/air-chamfer-production-m1.md@@ -0,0 +1,93 @@+# AIR-CHAMFER-PRODUCTION-M1 — authoritative bounded top-boundary chamfer++Status: implemented+Date: 2026-08-03++## Implemented pipeline++The production path is now:++```text+Firmament V2 PascalCase source+ -> FirmamentV2EdgeFinishDecl+ -> AirChamferFeature+ -> AirPlanarProfileNode[3] + AirSectionTransitionNode+ -> AirBRepPlan containing PrismaticSectionTransitionTopologyPlan+ -> PrismaticSectionTransitionEmitter.Emit(authoritativePlan)+ -> BrepBody+ -> Step242Exporter+ -> Step242Importer verification+```++`TopFaceLoopChamfer` remains semantic Feature AIR intent. Construction AIR contains only ordered planar profiles, identity correspondence, and a split-preserving section transition. STEP performs serialization only.++## Source contract++The admitted syntax is:++```firmament+Model AirChamferCanonical mm++Box Base {+ Size: [10mm, 8mm, 6mm]+}++Modify Base {+ EdgeFinish TopBreak {+ Face: +Z+ Target: Boundary+ Kind: Chamfer+ Distance: 1mm+ }+}+```++This PascalCase form is intentionally narrow and does not rewrite or reinterpret older V1/V2 fixtures.++## Layer contracts++Feature AIR preserves body and feature identity, `FaceBoundary(+Z)`, equal distance in millimetres, source span, construction-history classification, and an explicit admitted/rejected/deferred reason. It contains no coedge, STEP, or materializer topology identifiers.++Construction AIR contains three immutable profiles:++- the original rectangle at `z = 0`;+- the original rectangle at `z = height - distance`;+- the inset rectangle at `z = height`.++The `AirSectionTransitionNode` references these profiles in order and records identity-by-profile-index correspondence plus `preserve-section-splits` policy.++`PrismaticSectionTransitionTopologyPlan` is the topology authority. It deterministically owns planned vertices, section and transition edges, cap/side/transition faces, boundary edge uses and orientation, ordering, expected loops/coedges, split policy, and a stable geometry/topology signature. `AirBRepPlan.RealizationPlan` stores that object, while the emitter consumes the same instance. The former independent prediction/emission relationship is no longer used by this production route.++## Admission and rejection++Admitted:++- one history-known axis-aligned rectangular-prism `Box`;+- its planar `+Z` complete outer boundary;+- uniform symmetric equal-distance chamfer;+- `distance > 0`, `distance < width/2`, `distance < depth/2`, and `distance < height`.++Explicitly rejected or deferred:++- zero/non-finite/oversized distances;+- faces other than `+Z`;+- targets other than `Boundary`;+- edge-finish kinds other than `Chamfer`;+- imported/no-history bodies;+- multiple finishes, holes combined with this first route, inner/open/single-edge/arbitrary selections, nonuniform/asymmetric rules, non-planar or curved support, and arbitrary corner networks.++An input that reaches the bounded AIR route never silently falls back to legacy materialization.++## Validation and evidence++The build report exposes Feature AIR, Construction AIR, authoritative BRepPlan, materialization route, manifold status, expected and actual topology, measured X/Y top inset, STEP SHA-256, and immediate STEP reimport topology/bounds/manifold status.++The canonical rectangle produces 12 vertices, 20 edges, 10 planar faces, 10 loops, and 40 coedges. These are validation consequences of the three-section four-vertex topology plan, not a geometry algorithm. Geometry tests inspect the four reimported vertices at `z = height` and verify their X/Y extrema equal the requested inset.++The fixture is `fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer.valid.firmament`.++## Remaining limitations and legacy paths++This is not general chamfer support. It does not perform arbitrary BRep edge surgery or recognize imported history. `BrepBoundedChamfer` remains available for unrelated legacy behavior. `AirChamferRealBodyPrototype`, `AirChamferClosedWitnessLab`, and `AirChamferStepArtifactLab.WriteControlledCubeOneEdgeStep` remain lab/negative evidence and are not called by this route.++The next bounded step should add a second history-known construction family or a named face-pair single-edge selection only after giving it its own geometric construction and topology-plan proof; it should not reuse the false-positive cube relabeling chain.diff --git a/docs/v2/aetheris-v2-phase3-air-chamfer-mvp-scope-contract.md b/docs/v2/aetheris-v2-phase3-air-chamfer-mvp-scope-contract.mdindex 080440f3..a86926e7 100644--- a/docs/v2/aetheris-v2-phase3-air-chamfer-mvp-scope-contract.md+++ b/docs/v2/aetheris-v2-phase3-air-chamfer-mvp-scope-contract.md@@ -1,6 +1,8 @@# Aetheris V2.0 Phase 3 AIR chamfer MVP scope contract-Milestone: **PHASE3-L0**+Milestone: **PHASE3-L0**; bounded implementation completed by **AIR-CHAMFER-PRODUCTION-M1**++Implementation note (2026-08-03): the PascalCase `Box` plus `Modify`/`EdgeFinish` source form described here is now implemented for the exact `Face: +Z`, `Target: Boundary`, uniform equal-distance domain. The final path uses Feature AIR, ordered-profile Construction AIR, an authoritative shared topology realization plan, real changed BRep geometry, AP242 export, and immediate reimport verification. See `docs/implementation/air-chamfer-production-m1.md`. Broader chamfer claims remain out of scope.This document opens Aetheris V2.0 Phase 3 with a documentation-only scope contract for productionizing the AIR chamfer MVP.diff --git a/docs/v2/aetheris-v2-phase3-air-compiler-architecture-addendum.md b/docs/v2/aetheris-v2-phase3-air-compiler-architecture-addendum.mdindex fcb478de..9d93717f 100644--- a/docs/v2/aetheris-v2-phase3-air-compiler-architecture-addendum.md+++ b/docs/v2/aetheris-v2-phase3-air-compiler-architecture-addendum.md@@ -1,8 +1,10 @@# PHASE3-ARCH-A0 — AIR compiler architecture investigation addendum-Status: investigation result; not production doctrine+Status: investigation result; production follow-through implemented by AIR-CHAMFER-PRODUCTION-M1Date: 2026-08-03+> Implementation update (2026-08-03): the bounded rectangular-prism `+Z` outer-boundary chamfer now follows the corrected architecture in this addendum. `PrismaticSectionTransitionTopologyPlan` is shared authority for `AirBRepPlan` and `PrismaticSectionTransitionEmitter`; the production emitter consumes the plan rather than being independently predicted after emission. See `docs/implementation/air-chamfer-production-m1.md`.+This addendum tests, rather than assumes, the proposed pipeline:```textdiff --git a/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer-distance-2.valid.firmament b/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer-distance-2.valid.firmamentnew file mode 100644index 00000000..3d8cead7--- /dev/null+++ b/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer-distance-2.valid.firmament@@ -0,0 +1,14 @@+Model AirChamferDistance2 mm++Box Base {+ Size: [10mm, 8mm, 6mm]+}++Modify Base {+ EdgeFinish TopBreak {+ Face: +Z+ Target: Boundary+ Kind: Chamfer+ Distance: 2mm+ }+}diff --git a/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer-non-square.valid.firmament b/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer-non-square.valid.firmamentnew file mode 100644index 00000000..fe1e3eb3--- /dev/null+++ b/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer-non-square.valid.firmament@@ -0,0 +1,14 @@+Model AirChamferNonSquare mm++Box Base {+ Size: [12mm, 5mm, 7mm]+}++Modify Base {+ EdgeFinish TopBreak {+ Face: +Z+ Target: Boundary+ Kind: Chamfer+ Distance: 1mm+ }+}diff --git a/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer.valid.firmament b/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer.valid.firmamentnew file mode 100644index 00000000..02e6639c--- /dev/null+++ b/fixtures/FirmamentV2/Chamfer/valid/air-top-boundary-chamfer.valid.firmament@@ -0,0 +1,14 @@+Model AirChamferCanonical mm++Box Base {+ Size: [10mm, 8mm, 6mm]+}++Modify Base {+ EdgeFinish TopBreak {+ Face: +Z+ Target: Boundary+ Kind: Chamfer+ Distance: 1mm+ }+}