Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Update revolved regression expectations and NIST snapshot

Yuechen Li1a44c7700b37
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242RevolvedTopologyFamilyRegressionTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242RevolvedTopologyFamilyRegressionTests.cs
index 505fb237..87d56df7 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242RevolvedTopologyFamilyRegressionTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242RevolvedTopologyFamilyRegressionTests.cs
@@ -6,8 +6,8 @@ public sealed class Step242RevolvedTopologyFamilyRegressionTests
{
[Theory]
[InlineData("testdata/step242/nist/CTC/nist_ctc_04_asme1_ap242-e1.stp", "No diagnostics.")]
- [InlineData("testdata/step242/nist/FTC/nist_ftc_07_asme1_ap242-e2.stp", "Face 129 curved tessellation supports selected repeated cone/revolved boundary subfamilies; unsupported subfamily 'four-coedge mixed line/bspline revolved loop'. Observed")]
- [InlineData("testdata/step242/nist/FTC/nist_ftc_10_asme1_ap242-e2.stp", "Face 67 curved tessellation supports selected repeated torus/revolved boundary subfamilies; unsupported subfamily 'other (coedges=5, uniqueEdges=5)'. Observed")]
+ [InlineData("testdata/step242/nist/FTC/nist_ftc_07_asme1_ap242-e2.stp", "Face 183 planar loop triangulation failed.")]
+ [InlineData("testdata/step242/nist/FTC/nist_ftc_10_asme1_ap242-e2.stp", "Face 214 planar loop triangulation failed because the polygon is not simple.")]
public void Step242_RepeatedCurvedRevolvedTargets_AdvanceWithExplicitDeterministicNextBlocker(
string relativePath,
string expectedMessagePrefix)
@@ -38,7 +38,7 @@ public sealed class Step242RevolvedTopologyFamilyRegressionTests
}
[Fact]
- public void Step242_Ftc07_SixCoedgeBsplineOnlyRevolvedLoop_AdvancesDeterministically_ToExplicitConeBlocker()
+ public void Step242_Ftc07_SixCoedgeBsplineOnlyRevolvedLoop_AdvancesDeterministically_ToPlanarTriangulationBlocker()
{
const string relativePath = "testdata/step242/nist/FTC/nist_ftc_07_asme1_ap242-e2.stp";
var entry = new Step242CorpusManifestEntry(
@@ -59,7 +59,7 @@ public sealed class Step242RevolvedTopologyFamilyRegressionTests
Assert.Equal(first.FirstDiagnostic.MessagePrefix, second.FirstDiagnostic.MessagePrefix);
Assert.DoesNotContain("unsupported subfamily 'six-coedge bspline-only revolved loop'", first.FirstDiagnostic.MessagePrefix, StringComparison.Ordinal);
- Assert.StartsWith("Face 129 curved tessellation supports selected repeated cone/revolved boundary subfamilies; unsupported subfamily 'four-coedge mixed line/bspline revolved loop'. Observed", first.FirstDiagnostic.MessagePrefix, StringComparison.Ordinal);
+ Assert.StartsWith("Face 183 planar loop triangulation failed.", first.FirstDiagnostic.MessagePrefix, StringComparison.Ordinal);
}
diff --git a/testdata/step242/manifests/nist.v0.report.json b/testdata/step242/manifests/nist.v0.report.json
index e20cf8a1..bbcff274 100644
--- a/testdata/step242/manifests/nist.v0.report.json
+++ b/testdata/step242/manifests/nist.v0.report.json
@@ -151,8 +151,8 @@
"firstFailureLayer": "tessellator",
"firstDiagnostic": {
"code": "NotImplemented",
- "source": "",
- "messagePrefix": "Face 129 curved tessellation supports selected repeated cone/revolved boundary subfamilies; unsupported subfamily \u0027four-coedge mixed line/bspline revolved loop\u0027. Observed"
+ "source": "Viewer.Tessellation.PlanarNonConvexTriangulationFailed",
+ "messagePrefix": "Face 183 planar loop triangulation failed."
},
"diagnosticCount": 1,
"exceptionEscaped": false,
@@ -247,8 +247,8 @@
"firstFailureLayer": "tessellator",
"firstDiagnostic": {
"code": "NotImplemented",
- "source": "",
- "messagePrefix": "Face 67 curved tessellation supports selected repeated torus/revolved boundary subfamilies; unsupported subfamily \u0027other (coedges=5, uniqueEdges=5)\u0027. Observed"
+ "source": "Viewer.Tessellation.PlanarNonConvexTriangulationFailed",
+ "messagePrefix": "Face 214 planar loop triangulation failed because the polygon is not simple."
},
"diagnosticCount": 1,
"exceptionEscaped": false,
@@ -315,14 +315,14 @@
"fileId": "testdata_step242_nist_STC_nist_stc_07_asme1_ap242-e3",
"path": "testdata/step242/nist/STC/nist_stc_07_asme1_ap242-e3.stp",
"sizeBytes": 1927905,
- "status": "importFail",
- "firstFailureLayer": "tessellator",
+ "status": "success",
+ "firstFailureLayer": "",
"firstDiagnostic": {
- "code": "NotImplemented",
- "source": "",
- "messagePrefix": "Face 20 curved tessellation supports selected repeated torus/revolved boundary subfamilies; unsupported subfamily \u0027circle-only non-seam loop\u0027. Observed"
+ "code": "Unknown",
+ "source": "Audit.None",
+ "messagePrefix": "No diagnostics."
},
- "diagnosticCount": 1,
+ "diagnosticCount": 0,
"exceptionEscaped": false,
"topologyCounts": {
"vertices": 588,
@@ -330,10 +330,10 @@
"faces": 306
},
"tessellationCounts": {
- "facePatches": 0,
- "edgePolylines": 0
+ "facePatches": 306,
+ "edgePolylines": 871
},
- "canonicalSha256": null
+ "canonicalSha256": "639f0d562dc98d38b3ea323e3dc81cad82cbe9d13e8ecf2a8d6db6703183a1eb"
},
{
"fileId": "testdata_step242_nist_STC_nist_stc_08_asme1_ap242-e3",