Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Refresh cylindrical hole expectations after runtime progression

Yuechen Li1c27444df636
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
index f8437189..f95a4dc5 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
@@ -80,7 +80,7 @@ public sealed class Step242HoleSemanticsTests
}
[Fact]
- public void ImportBody_MultiLoopCylindricalFace_Imports_ThenFailsDeterministicallyAtCylinderTrimAxialSpanDegenerateTessellation()
+ public void ImportBody_MultiLoopCylindricalFace_Imports_ThenTessellatesDeterministically()
{
var import = Step242Importer.ImportBody(Step242FixtureCorpus.CylindricalFaceWithTwoLoops);
@@ -95,10 +95,9 @@ public sealed class Step242HoleSemanticsTests
Assert.Equal(2, cylindricalFace.LoopIds.Count);
var tessellation = BrepDisplayTessellator.Tessellate(body);
- Assert.False(tessellation.IsSuccess);
- var diagnostic = Assert.Single(tessellation.Diagnostics);
- Assert.Equal(KernelDiagnosticCode.InvalidArgument, diagnostic.Code);
- Assert.Equal("Viewer.Tessellation.CylinderTrimDegenerate", diagnostic.Source);
- Assert.Contains("degenerate trim patch", diagnostic.Message, StringComparison.Ordinal);
+ Assert.True(tessellation.IsSuccess);
+ Assert.Empty(tessellation.Diagnostics);
+ Assert.NotEmpty(tessellation.Value.FacePatches);
+ Assert.Contains(tessellation.Value.FacePatches, patch => patch.TriangleIndices.Count > 0);
}
}
diff --git a/testdata/step242/manifests/v0.corpus.json b/testdata/step242/manifests/v0.corpus.json
index 21f6a61c..ff9c0a03 100644
--- a/testdata/step242/manifests/v0.corpus.json
+++ b/testdata/step242/manifests/v0.corpus.json
@@ -51,12 +51,8 @@
{
"id": "exp_cylinder_hole_unsupported",
"path": "testdata/step242/generated/v0-expectedfail/cylinder_hole_unsupported.step",
- "group": "expectedFail",
- "expectedFirstDiagnostic": {
- "code": "InvalidArgument",
- "source": "Viewer.Tessellation.CylinderTrimDegenerate",
- "messagePrefix": "Cylindrical face tessellation derived a degenerate trim patch."
- }
+ "group": "passRequired",
+ "notes": "Cylindrical multi-loop case now imports+tessellates successfully; promoted from expectedFail."
},
{
"id": "exp_parser_missing_paren",
@@ -75,4 +71,4 @@
"notes": "Representative NIST deferred item retained in report output"
}
]
-}
+}
\ No newline at end of file