Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Update STC10 regression expectations after circle fallback fix

Yuechen Li1d33344f6022
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242ConicalSurfaceRegressionTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242ConicalSurfaceRegressionTests.cs
index d2271f9d..615677a1 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242ConicalSurfaceRegressionTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242ConicalSurfaceRegressionTests.cs
@@ -150,9 +150,9 @@ public sealed class Step242ConicalSurfaceRegressionTests
"No diagnostics.")]
[InlineData(
"testdata/step242/nist/STC/nist_stc_10_asme1_ap242-e2.stp",
- "tessellator",
- "Viewer.Tessellation.PlanarNonConvexTriangulationFailed",
- "Face 225 planar loop triangulation failed")]
+ "",
+ "Audit.None",
+ "No diagnostics.")]
public void Step242_NistTargets_AdvancePastCircleTrim_AndKeepDeterministicNextBlocker(
string relativePath,
string expectedLayer,
diff --git a/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs b/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
index 95963db8..ce34ed46 100644
--- a/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
+++ b/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs
@@ -2715,7 +2715,7 @@ public static class BrepDisplayTessellator
if (body.Bindings.TryGetEdgeBinding(coedge.EdgeId, out var binding) && binding.TrimInterval is ParameterInterval trim)
{
- var effectiveIsReversed = coedge.IsReversed ^ traversalSwapped;
+ var effectiveIsReversed = coedge.IsReversed ^ traversalSwapped ^ !binding.OrientedEdgeSense;
var trimStart = effectiveIsReversed ? trim.End : trim.Start;
var trimEnd = effectiveIsReversed ? trim.Start : trim.End;
var trimDelta = trimEnd - trimStart;
diff --git a/testdata/step242/manifests/nist.v0.report.json b/testdata/step242/manifests/nist.v0.report.json
index 3998cc78..e20cf8a1 100644
--- a/testdata/step242/manifests/nist.v0.report.json
+++ b/testdata/step242/manifests/nist.v0.report.json
@@ -387,14 +387,14 @@
"fileId": "testdata_step242_nist_STC_nist_stc_10_asme1_ap242-e2",
"path": "testdata/step242/nist/STC/nist_stc_10_asme1_ap242-e2.stp",
"sizeBytes": 4807322,
- "status": "importFail",
- "firstFailureLayer": "tessellator",
+ "status": "success",
+ "firstFailureLayer": "",
"firstDiagnostic": {
- "code": "NotImplemented",
- "source": "Viewer.Tessellation.PlanarNonConvexTriangulationFailed",
- "messagePrefix": "Face 225 planar loop triangulation failed because the polygon is not simple."
+ "code": "Unknown",
+ "source": "Audit.None",
+ "messagePrefix": "No diagnostics."
},
- "diagnosticCount": 1,
+ "diagnosticCount": 0,
"exceptionEscaped": false,
"topologyCounts": {
"vertices": 368,
@@ -402,9 +402,9 @@
"faces": 256
},
"tessellationCounts": {
- "facePatches": 0,
- "edgePolylines": 0
+ "facePatches": 256,
+ "edgePolylines": 551
},
- "canonicalSha256": null
+ "canonicalSha256": "3703906cba81c4fba8e935a298fcdb89bbd74c151552ea0d1324eccf429e98a9"
}
]