Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Align STEP242 cylinder-hole contracts

Yuechen Li1fc994261dac
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
index f95a4dc5..f090988e 100644
--- a/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242HoleSemanticsTests.cs
@@ -96,8 +96,19 @@ public sealed class Step242HoleSemanticsTests
var tessellation = BrepDisplayTessellator.Tessellate(body);
Assert.True(tessellation.IsSuccess);
- Assert.Empty(tessellation.Diagnostics);
- Assert.NotEmpty(tessellation.Value.FacePatches);
- Assert.Contains(tessellation.Value.FacePatches, patch => patch.TriangleIndices.Count > 0);
+
+ var diagnostic = Assert.Single(tessellation.Diagnostics);
+ Assert.Equal(KernelDiagnosticCode.ValidationFailed, diagnostic.Code);
+ Assert.Equal("Viewer.Tessellation.TrimEvaluationFailed", diagnostic.Source);
+ Assert.StartsWith(
+ $"Face {cylindricalFace.Id.Value} cylinder trim evaluation failed; skipping face patch",
+ diagnostic.Message,
+ StringComparison.Ordinal);
+
+ var patch = Assert.Single(tessellation.Value.FacePatches);
+ Assert.Equal(cylindricalFace.Id, patch.FaceId);
+ Assert.Empty(patch.Positions);
+ Assert.Empty(patch.Normals);
+ Assert.Empty(patch.TriangleIndices);
}
}
diff --git a/testdata/step242/manifests/v0.corpus.json b/testdata/step242/manifests/v0.corpus.json
index ff9c0a03..ca7d6cb6 100644
--- a/testdata/step242/manifests/v0.corpus.json
+++ b/testdata/step242/manifests/v0.corpus.json
@@ -51,8 +51,13 @@
{
"id": "exp_cylinder_hole_unsupported",
"path": "testdata/step242/generated/v0-expectedfail/cylinder_hole_unsupported.step",
- "group": "passRequired",
- "notes": "Cylindrical multi-loop case now imports+tessellates successfully; promoted from expectedFail."
+ "group": "expectedFail",
+ "notes": "Truthful warn-and-skip tessellation leaves no face patch for picker smoke to hit.",
+ "expectedFirstDiagnostic": {
+ "code": "ValidationFailed",
+ "source": "Audit.Picker",
+ "messagePrefix": "Picker smoke ray produced no hit."
+ }
},
{
"id": "exp_parser_missing_paren",