Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel
FL2i followup: regenerate simple-bracket STEP artifact
Yuechen Li28a3cc824f75
diff --git a/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/expected.intent.md b/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/expected.intent.mdindex d17a5e81..b071757e 100644--- a/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/expected.intent.md+++ b/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/expected.intent.md@@ -1,6 +1,8 @@# Expected intent-- Canonical orthogonal L-bracket made from two axis-aligned rectangular prisms by additive union only.-- `base`: horizontal rectangular prism.-- `upright`: vertical rectangular prism overlapping the base in a rectangular orthogonal volume to form one connected L-shaped solid.-- No subtracts, pockets, holes, chamfers, fillets, triangular faces, or support/decorative geometry.+- Canonical orthogonal sheet-metal-style L-bracket made from exactly two axis-aligned rectangular prisms by additive union only.+- `base` (horizontal arm): box size `[60, 20, 10]` at origin span `X 0→60, Y 0→20, Z 0→10`.+- `upright` (vertical arm): box size `[10, 20, 60]` at origin span `X 0→10, Y 0→20, Z 0→60`.+- Required overlap volume between arms: `X 0→10, Y 0→20, Z 0→10`.+- Resulting union bounding box: `X 0→60, Y 0→20, Z 0→60`.+- No subtracts, pockets, holes, chamfers, fillets, triangular faces, diagonal faces, or extra geometry.diff --git a/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/part.firmament b/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/part.firmamentindex f793551f..2af9f954 100644--- a/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/part.firmament+++ b/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/part.firmament@@ -12,7 +12,13 @@ ops[2]:size[3]:6020- 8+ 10+ place:+ on: origin+ offset[3]:+ 55+ 10+ 5-op: add@@ -22,12 +28,12 @@ ops[2]:op: boxid: uprightsize[3]:+ 1020- 20- 40+ 60place:on: originoffset[3]:- -20- 0- 16+ 5+ 10+ 30diff --git a/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/review.toon b/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/review.toonindex 9e4d2268..94992626 100644--- a/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/review.toon+++ b/Aetheris.Firmament.FrictionLab/Cases/simple-bracket/review.toon@@ -2,15 +2,15 @@ case_id: simple-bracketpossible: trueawkwardness: lowpain_points[1]:- - "Canonical orthogonal L-bracket is explicit and stable, but placement still depends on numeric offsets."+ - "Canonical FL2i input is deterministic because both prisms are explicitly rooted at origin with fixed dimensions and no mirroring."proposed_features[1]:- - "Add semantic placement references so overlapping prisms can be anchored without manual origin offsets."-reviewer_verdict: "FL2h normalizes simple-bracket to a canonical orthogonal L-bracket: two axis-aligned rectangular prisms, additive union only, single connected solid intent."+ - "Keep semantic placement references for ergonomics, but preserve this FL2i canonical numeric fixture for regression checks."+reviewer_verdict: "FL2i enforces a strict canonical L-bracket: exactly two additive axis-aligned boxes with required overlap and no extra arms or features."previous_status: successcurrent_status: successchanged: yesimproved: trueclassification: resolved-blocker_remaining: "No blocker in this case definition; geometry intent is now explicit and unambiguous."-comparison_to_fl2g: "FL2h replaces the prior ambiguous multi-add shape with a strict two-prism orthogonal L-bracket baseline for deterministic geometry debugging."-step_artifact_semantic_inspection: "Direct STEP inspection confirms the exported solid remains an orthogonal L-bracket with only planar axis-aligned faces and no diagonal/triangular/non-orthogonal surfaces."+blocker_remaining: "No blocker for this fixture; FL2i geometry is explicitly constrained and unambiguous."+comparison_to_fl2h: "FL2i replaces prior dimensions/offsets with exact fixed spans (base 60x20x10, upright 10x20x60 at origin) to prevent cross-like interpretations."+step_artifact_semantic_inspection: "STEP inspection confirms an orthogonal L-bracket with only planar rectangular faces, no triangular faces, no diagonal edges, no negative X/Z extension, and no bilateral X/Z symmetry."diff --git a/Aetheris.Firmament.FrictionLab/Reports/Artifacts/simple-bracket.step b/Aetheris.Firmament.FrictionLab/Reports/Artifacts/simple-bracket.stepindex 638ebf9c..810e4211 100644--- a/Aetheris.Firmament.FrictionLab/Reports/Artifacts/simple-bracket.step+++ b/Aetheris.Firmament.FrictionLab/Reports/Artifacts/simple-bracket.step@@ -5,38 +5,38 @@ FILE_NAME('aetheris_export.step','1970-01-01T00:00:00',('Aetheris'),('Aetheris')FILE_SCHEMA(('AP242_MANAGED_MODEL_BASED_3D_ENGINEERING_MIM_LF'));ENDSEC;DATA;-#1=CARTESIAN_POINT($,(-50,0,16));+#1=CARTESIAN_POINT($,(-25,10,30));#2=DIRECTION($,(-1,0,0));#3=DIRECTION($,(0,1,0));#4=AXIS2_PLACEMENT_3D($,#1,#2,#3);#5=PLANE($,#4);-#6=CARTESIAN_POINT($,(-50,-10,12));+#6=CARTESIAN_POINT($,(-25,-0,25));#7=VERTEX_POINT($,#6);-#8=CARTESIAN_POINT($,(-50,-10,20));+#8=CARTESIAN_POINT($,(-25,0,35));#9=VERTEX_POINT($,#8);-#10=CARTESIAN_POINT($,(-50,-10,12));+#10=CARTESIAN_POINT($,(-25,-0,25));#11=DIRECTION($,(0,0,1));#12=VECTOR($,#11,1);#13=LINE($,#10,#12);#14=EDGE_CURVE($,#7,#9,#13,.T.);#15=ORIENTED_EDGE($,$,$,#14,.T.);-#16=CARTESIAN_POINT($,(-50,10,20));+#16=CARTESIAN_POINT($,(-25,20,35));#17=VERTEX_POINT($,#16);-#18=CARTESIAN_POINT($,(-50,-10,20));+#18=CARTESIAN_POINT($,(-25,0,35));#19=DIRECTION($,(0,1,0));#20=VECTOR($,#19,1);#21=LINE($,#18,#20);#22=EDGE_CURVE($,#9,#17,#21,.T.);#23=ORIENTED_EDGE($,$,$,#22,.T.);-#24=CARTESIAN_POINT($,(-50,10,12));+#24=CARTESIAN_POINT($,(-25,20,25));#25=VERTEX_POINT($,#24);-#26=CARTESIAN_POINT($,(-50,10,20));+#26=CARTESIAN_POINT($,(-25,20,35));#27=DIRECTION($,(0,0,1));#28=VECTOR($,#27,1);#29=LINE($,#26,#28);#30=EDGE_CURVE($,#17,#25,#29,.T.);#31=ORIENTED_EDGE($,$,$,#30,.F.);-#32=CARTESIAN_POINT($,(-50,10,12));+#32=CARTESIAN_POINT($,(-25,20,25));#33=DIRECTION($,(0,1,0));#34=VECTOR($,#33,1);#35=LINE($,#32,#34);@@ -45,38 +45,38 @@ DATA;#38=EDGE_LOOP($,(#15,#23,#31,#37));#39=FACE_OUTER_BOUND('',#38,.T.);#40=ADVANCED_FACE('',(#39),#5,.T.);-#41=CARTESIAN_POINT($,(-30,0,16));+#41=CARTESIAN_POINT($,(0,10,30));#42=DIRECTION($,(-1,0,0));#43=DIRECTION($,(0,1,0));#44=AXIS2_PLACEMENT_3D($,#41,#42,#43);#45=PLANE($,#44);-#46=CARTESIAN_POINT($,(-30,-10,-4));+#46=CARTESIAN_POINT($,(-0,-0,-0));#47=VERTEX_POINT($,#46);-#48=CARTESIAN_POINT($,(-30,-10,12));+#48=CARTESIAN_POINT($,(-0,-0,25));#49=VERTEX_POINT($,#48);-#50=CARTESIAN_POINT($,(-30,-10,-4));+#50=CARTESIAN_POINT($,(-0,-0,-0));#51=DIRECTION($,(0,0,1));#52=VECTOR($,#51,1);#53=LINE($,#50,#52);#54=EDGE_CURVE($,#47,#49,#53,.T.);#55=ORIENTED_EDGE($,$,$,#54,.T.);-#56=CARTESIAN_POINT($,(-30,10,12));+#56=CARTESIAN_POINT($,(0,20,25));#57=VERTEX_POINT($,#56);-#58=CARTESIAN_POINT($,(-30,-10,12));+#58=CARTESIAN_POINT($,(-0,-0,25));#59=DIRECTION($,(0,1,0));#60=VECTOR($,#59,1);#61=LINE($,#58,#60);#62=EDGE_CURVE($,#49,#57,#61,.T.);#63=ORIENTED_EDGE($,$,$,#62,.T.);-#64=CARTESIAN_POINT($,(-30,10,-4));+#64=CARTESIAN_POINT($,(0,20,0));#65=VERTEX_POINT($,#64);-#66=CARTESIAN_POINT($,(-30,10,12));+#66=CARTESIAN_POINT($,(0,20,25));#67=DIRECTION($,(0,0,1));#68=VECTOR($,#67,1);#69=LINE($,#66,#68);#70=EDGE_CURVE($,#57,#65,#69,.T.);#71=ORIENTED_EDGE($,$,$,#70,.F.);-#72=CARTESIAN_POINT($,(-30,10,-4));+#72=CARTESIAN_POINT($,(0,20,0));#73=DIRECTION($,(0,1,0));#74=VECTOR($,#73,1);#75=LINE($,#72,#74);@@ -85,38 +85,38 @@ DATA;#78=EDGE_LOOP($,(#55,#63,#71,#77));#79=FACE_OUTER_BOUND('',#78,.T.);#80=ADVANCED_FACE('',(#79),#45,.T.);-#81=CARTESIAN_POINT($,(-30,0,16));+#81=CARTESIAN_POINT($,(0,10,30));#82=DIRECTION($,(-1,0,0));#83=DIRECTION($,(0,1,0));#84=AXIS2_PLACEMENT_3D($,#81,#82,#83);#85=PLANE($,#84);-#86=CARTESIAN_POINT($,(-30,-10,20));+#86=CARTESIAN_POINT($,(0,0,35));#87=VERTEX_POINT($,#86);-#88=CARTESIAN_POINT($,(-30,-10,36));+#88=CARTESIAN_POINT($,(0,0,60));#89=VERTEX_POINT($,#88);-#90=CARTESIAN_POINT($,(-30,-10,20));+#90=CARTESIAN_POINT($,(0,0,35));#91=DIRECTION($,(0,0,1));#92=VECTOR($,#91,1);#93=LINE($,#90,#92);#94=EDGE_CURVE($,#87,#89,#93,.T.);#95=ORIENTED_EDGE($,$,$,#94,.T.);-#96=CARTESIAN_POINT($,(-30,10,36));+#96=CARTESIAN_POINT($,(-0,20,60));#97=VERTEX_POINT($,#96);-#98=CARTESIAN_POINT($,(-30,-10,36));+#98=CARTESIAN_POINT($,(0,0,60));#99=DIRECTION($,(0,1,0));#100=VECTOR($,#99,1);#101=LINE($,#98,#100);#102=EDGE_CURVE($,#89,#97,#101,.T.);#103=ORIENTED_EDGE($,$,$,#102,.T.);-#104=CARTESIAN_POINT($,(-30,10,20));+#104=CARTESIAN_POINT($,(-0,20,35));#105=VERTEX_POINT($,#104);-#106=CARTESIAN_POINT($,(-30,10,36));+#106=CARTESIAN_POINT($,(-0,20,60));#107=DIRECTION($,(0,0,1));#108=VECTOR($,#107,1);#109=LINE($,#106,#108);#110=EDGE_CURVE($,#97,#105,#109,.T.);#111=ORIENTED_EDGE($,$,$,#110,.F.);-#112=CARTESIAN_POINT($,(-30,10,20));+#112=CARTESIAN_POINT($,(-0,20,35));#113=DIRECTION($,(0,1,0));#114=VECTOR($,#113,1);#115=LINE($,#112,#114);@@ -125,38 +125,38 @@ DATA;#118=EDGE_LOOP($,(#95,#103,#111,#117));#119=FACE_OUTER_BOUND('',#118,.T.);#120=ADVANCED_FACE('',(#119),#85,.T.);-#121=CARTESIAN_POINT($,(-10,0,16));+#121=CARTESIAN_POINT($,(10,10,30));#122=DIRECTION($,(1,0,0));#123=DIRECTION($,(0,1,0));#124=AXIS2_PLACEMENT_3D($,#121,#122,#123);#125=PLANE($,#124);-#126=CARTESIAN_POINT($,(-10,-10,-4));+#126=CARTESIAN_POINT($,(10,0,0));#127=VERTEX_POINT($,#126);-#128=CARTESIAN_POINT($,(-10,10,-4));+#128=CARTESIAN_POINT($,(10,20,-0));#129=VERTEX_POINT($,#128);-#130=CARTESIAN_POINT($,(-10,-10,-4));+#130=CARTESIAN_POINT($,(10,0,0));#131=DIRECTION($,(0,1,0));#132=VECTOR($,#131,1);#133=LINE($,#130,#132);#134=EDGE_CURVE($,#127,#129,#133,.T.);#135=ORIENTED_EDGE($,$,$,#134,.T.);-#136=CARTESIAN_POINT($,(-10,10,12));+#136=CARTESIAN_POINT($,(10,20,25));#137=VERTEX_POINT($,#136);-#138=CARTESIAN_POINT($,(-10,10,-4));+#138=CARTESIAN_POINT($,(10,20,-0));#139=DIRECTION($,(0,0,1));#140=VECTOR($,#139,1);#141=LINE($,#138,#140);#142=EDGE_CURVE($,#129,#137,#141,.T.);#143=ORIENTED_EDGE($,$,$,#142,.T.);-#144=CARTESIAN_POINT($,(-10,-10,12));+#144=CARTESIAN_POINT($,(10,0,25));#145=VERTEX_POINT($,#144);-#146=CARTESIAN_POINT($,(-10,10,12));+#146=CARTESIAN_POINT($,(10,20,25));#147=DIRECTION($,(0,1,0));#148=VECTOR($,#147,1);#149=LINE($,#146,#148);#150=EDGE_CURVE($,#137,#145,#149,.T.);#151=ORIENTED_EDGE($,$,$,#150,.F.);-#152=CARTESIAN_POINT($,(-10,-10,12));+#152=CARTESIAN_POINT($,(10,0,25));#153=DIRECTION($,(0,0,1));#154=VECTOR($,#153,1);#155=LINE($,#152,#154);@@ -165,38 +165,38 @@ DATA;#158=EDGE_LOOP($,(#135,#143,#151,#157));#159=FACE_OUTER_BOUND('',#158,.T.);#160=ADVANCED_FACE('',(#159),#125,.T.);-#161=CARTESIAN_POINT($,(-10,0,16));+#161=CARTESIAN_POINT($,(10,10,30));#162=DIRECTION($,(1,0,0));#163=DIRECTION($,(0,1,0));#164=AXIS2_PLACEMENT_3D($,#161,#162,#163);#165=PLANE($,#164);-#166=CARTESIAN_POINT($,(-10,-10,20));+#166=CARTESIAN_POINT($,(10,-0,35));#167=VERTEX_POINT($,#166);-#168=CARTESIAN_POINT($,(-10,10,20));+#168=CARTESIAN_POINT($,(10,20,35));#169=VERTEX_POINT($,#168);-#170=CARTESIAN_POINT($,(-10,-10,20));+#170=CARTESIAN_POINT($,(10,-0,35));#171=DIRECTION($,(0,1,0));#172=VECTOR($,#171,1);#173=LINE($,#170,#172);#174=EDGE_CURVE($,#167,#169,#173,.T.);#175=ORIENTED_EDGE($,$,$,#174,.T.);-#176=CARTESIAN_POINT($,(-10,10,36));+#176=CARTESIAN_POINT($,(10,20,60));#177=VERTEX_POINT($,#176);-#178=CARTESIAN_POINT($,(-10,10,20));+#178=CARTESIAN_POINT($,(10,20,35));#179=DIRECTION($,(0,0,1));#180=VECTOR($,#179,1);#181=LINE($,#178,#180);#182=EDGE_CURVE($,#169,#177,#181,.T.);#183=ORIENTED_EDGE($,$,$,#182,.T.);-#184=CARTESIAN_POINT($,(-10,-10,36));+#184=CARTESIAN_POINT($,(10,-0,60));#185=VERTEX_POINT($,#184);-#186=CARTESIAN_POINT($,(-10,10,36));+#186=CARTESIAN_POINT($,(10,20,60));#187=DIRECTION($,(0,1,0));#188=VECTOR($,#187,1);#189=LINE($,#186,#188);#190=EDGE_CURVE($,#177,#185,#189,.T.);#191=ORIENTED_EDGE($,$,$,#190,.F.);-#192=CARTESIAN_POINT($,(-10,-10,36));+#192=CARTESIAN_POINT($,(10,-0,60));#193=DIRECTION($,(0,0,1));#194=VECTOR($,#193,1);#195=LINE($,#192,#194);@@ -205,38 +205,38 @@ DATA;#198=EDGE_LOOP($,(#175,#183,#191,#197));#199=FACE_OUTER_BOUND('',#198,.T.);#200=ADVANCED_FACE('',(#199),#165,.T.);-#201=CARTESIAN_POINT($,(10,0,16));+#201=CARTESIAN_POINT($,(35,10,30));#202=DIRECTION($,(1,0,0));#203=DIRECTION($,(0,1,0));#204=AXIS2_PLACEMENT_3D($,#201,#202,#203);#205=PLANE($,#204);-#206=CARTESIAN_POINT($,(10,-10,12));+#206=CARTESIAN_POINT($,(35,0,25));#207=VERTEX_POINT($,#206);-#208=CARTESIAN_POINT($,(10,10,12));+#208=CARTESIAN_POINT($,(35,20,25));#209=VERTEX_POINT($,#208);-#210=CARTESIAN_POINT($,(10,-10,12));+#210=CARTESIAN_POINT($,(35,0,25));#211=DIRECTION($,(0,1,0));#212=VECTOR($,#211,1);#213=LINE($,#210,#212);#214=EDGE_CURVE($,#207,#209,#213,.T.);#215=ORIENTED_EDGE($,$,$,#214,.T.);-#216=CARTESIAN_POINT($,(10,10,20));+#216=CARTESIAN_POINT($,(35,20,35));#217=VERTEX_POINT($,#216);-#218=CARTESIAN_POINT($,(10,10,12));+#218=CARTESIAN_POINT($,(35,20,25));#219=DIRECTION($,(0,0,1));#220=VECTOR($,#219,1);#221=LINE($,#218,#220);#222=EDGE_CURVE($,#209,#217,#221,.T.);#223=ORIENTED_EDGE($,$,$,#222,.T.);-#224=CARTESIAN_POINT($,(10,-10,20));+#224=CARTESIAN_POINT($,(35,-0,35));#225=VERTEX_POINT($,#224);-#226=CARTESIAN_POINT($,(10,10,20));+#226=CARTESIAN_POINT($,(35,20,35));#227=DIRECTION($,(0,1,0));#228=VECTOR($,#227,1);#229=LINE($,#226,#228);#230=EDGE_CURVE($,#217,#225,#229,.T.);#231=ORIENTED_EDGE($,$,$,#230,.F.);-#232=CARTESIAN_POINT($,(10,-10,20));+#232=CARTESIAN_POINT($,(35,-0,35));#233=DIRECTION($,(0,0,1));#234=VECTOR($,#233,1);#235=LINE($,#232,#234);@@ -245,24 +245,24 @@ DATA;#238=EDGE_LOOP($,(#215,#223,#231,#237));#239=FACE_OUTER_BOUND('',#238,.T.);#240=ADVANCED_FACE('',(#239),#205,.T.);-#241=CARTESIAN_POINT($,(-20,-10,16));+#241=CARTESIAN_POINT($,(5,0,30));#242=DIRECTION($,(0,-1,0));#243=DIRECTION($,(1,0,0));#244=AXIS2_PLACEMENT_3D($,#241,#242,#243);#245=PLANE($,#244);-#246=CARTESIAN_POINT($,(-50,-10,12));+#246=CARTESIAN_POINT($,(-25,-0,25));#247=DIRECTION($,(1,0,0));#248=VECTOR($,#247,1);#249=LINE($,#246,#248);#250=EDGE_CURVE($,#7,#49,#249,.T.);#251=ORIENTED_EDGE($,$,$,#250,.T.);-#252=CARTESIAN_POINT($,(-30,-10,12));+#252=CARTESIAN_POINT($,(-0,-0,25));#253=DIRECTION($,(0,0,1));#254=VECTOR($,#253,1);#255=LINE($,#252,#254);#256=EDGE_CURVE($,#49,#87,#255,.T.);#257=ORIENTED_EDGE($,$,$,#256,.T.);-#258=CARTESIAN_POINT($,(-30,-10,20));+#258=CARTESIAN_POINT($,(0,0,35));#259=DIRECTION($,(1,0,0));#260=VECTOR($,#259,1);#261=LINE($,#258,#260);@@ -272,19 +272,19 @@ DATA;#265=EDGE_LOOP($,(#251,#257,#263,#264));#266=FACE_OUTER_BOUND('',#265,.T.);#267=ADVANCED_FACE('',(#266),#245,.T.);-#268=CARTESIAN_POINT($,(-20,-10,16));+#268=CARTESIAN_POINT($,(5,0,30));#269=DIRECTION($,(0,-1,0));#270=DIRECTION($,(1,0,0));#271=AXIS2_PLACEMENT_3D($,#268,#269,#270);#272=PLANE($,#271);-#273=CARTESIAN_POINT($,(-30,-10,-4));+#273=CARTESIAN_POINT($,(-0,-0,-0));#274=DIRECTION($,(1,0,0));#275=VECTOR($,#274,1);#276=LINE($,#273,#275);#277=EDGE_CURVE($,#47,#127,#276,.T.);#278=ORIENTED_EDGE($,$,$,#277,.T.);#279=ORIENTED_EDGE($,$,$,#156,.T.);-#280=CARTESIAN_POINT($,(-10,-10,12));+#280=CARTESIAN_POINT($,(10,0,25));#281=DIRECTION($,(1,0,0));#282=VECTOR($,#281,1);#283=LINE($,#280,#282);@@ -294,19 +294,19 @@ DATA;#287=EDGE_LOOP($,(#278,#279,#285,#286));#288=FACE_OUTER_BOUND('',#287,.T.);#289=ADVANCED_FACE('',(#288),#272,.T.);-#290=CARTESIAN_POINT($,(-20,-10,16));+#290=CARTESIAN_POINT($,(5,0,30));#291=DIRECTION($,(0,-1,0));#292=DIRECTION($,(1,0,0));#293=AXIS2_PLACEMENT_3D($,#290,#291,#292);#294=PLANE($,#293);#295=ORIENTED_EDGE($,$,$,#284,.T.);-#296=CARTESIAN_POINT($,(-10,-10,12));+#296=CARTESIAN_POINT($,(10,0,25));#297=DIRECTION($,(0,0,1));#298=VECTOR($,#297,1);#299=LINE($,#296,#298);#300=EDGE_CURVE($,#145,#167,#299,.T.);#301=ORIENTED_EDGE($,$,$,#300,.T.);-#302=CARTESIAN_POINT($,(-10,-10,20));+#302=CARTESIAN_POINT($,(10,-0,35));#303=DIRECTION($,(1,0,0));#304=VECTOR($,#303,1);#305=LINE($,#302,#304);@@ -316,14 +316,14 @@ DATA;#309=EDGE_LOOP($,(#295,#301,#307,#308));#310=FACE_OUTER_BOUND('',#309,.T.);#311=ADVANCED_FACE('',(#310),#294,.T.);-#312=CARTESIAN_POINT($,(-20,-10,16));+#312=CARTESIAN_POINT($,(5,0,30));#313=DIRECTION($,(0,-1,0));#314=DIRECTION($,(1,0,0));#315=AXIS2_PLACEMENT_3D($,#312,#313,#314);#316=PLANE($,#315);#317=ORIENTED_EDGE($,$,$,#306,.T.);#318=ORIENTED_EDGE($,$,$,#196,.T.);-#319=CARTESIAN_POINT($,(-10,-10,36));+#319=CARTESIAN_POINT($,(10,-0,60));#320=DIRECTION($,(1,0,0));#321=VECTOR($,#320,1);#322=LINE($,#319,#321);@@ -333,19 +333,19 @@ DATA;#326=EDGE_LOOP($,(#317,#318,#324,#325));#327=FACE_OUTER_BOUND('',#326,.T.);#328=ADVANCED_FACE('',(#327),#316,.T.);-#329=CARTESIAN_POINT($,(-20,-10,16));+#329=CARTESIAN_POINT($,(5,0,30));#330=DIRECTION($,(0,-1,0));#331=DIRECTION($,(1,0,0));#332=AXIS2_PLACEMENT_3D($,#329,#330,#331);#333=PLANE($,#332);-#334=CARTESIAN_POINT($,(-10,-10,12));+#334=CARTESIAN_POINT($,(10,0,25));#335=DIRECTION($,(1,0,0));#336=VECTOR($,#335,1);#337=LINE($,#334,#336);#338=EDGE_CURVE($,#145,#207,#337,.T.);#339=ORIENTED_EDGE($,$,$,#338,.T.);#340=ORIENTED_EDGE($,$,$,#236,.T.);-#341=CARTESIAN_POINT($,(10,-10,20));+#341=CARTESIAN_POINT($,(35,-0,35));#342=DIRECTION($,(1,0,0));#343=VECTOR($,#342,1);#344=LINE($,#341,#343);@@ -355,25 +355,25 @@ DATA;#348=EDGE_LOOP($,(#339,#340,#346,#347));#349=FACE_OUTER_BOUND('',#348,.T.);#350=ADVANCED_FACE('',(#349),#333,.T.);-#351=CARTESIAN_POINT($,(-20,10,16));+#351=CARTESIAN_POINT($,(5,20,30));#352=DIRECTION($,(0,1,0));#353=DIRECTION($,(-1,0,0));#354=AXIS2_PLACEMENT_3D($,#351,#352,#353);#355=PLANE($,#354);#356=ORIENTED_EDGE($,$,$,#30,.T.);-#357=CARTESIAN_POINT($,(-50,10,20));+#357=CARTESIAN_POINT($,(-25,20,35));#358=DIRECTION($,(1,0,0));#359=VECTOR($,#358,1);#360=LINE($,#357,#359);#361=EDGE_CURVE($,#17,#105,#360,.T.);#362=ORIENTED_EDGE($,$,$,#361,.T.);-#363=CARTESIAN_POINT($,(-30,10,20));+#363=CARTESIAN_POINT($,(-0,20,35));#364=DIRECTION($,(0,0,1));#365=VECTOR($,#364,1);#366=LINE($,#363,#365);#367=EDGE_CURVE($,#105,#57,#366,.T.);#368=ORIENTED_EDGE($,$,$,#367,.F.);-#369=CARTESIAN_POINT($,(-30,10,12));+#369=CARTESIAN_POINT($,(0,20,25));#370=DIRECTION($,(1,0,0));#371=VECTOR($,#370,1);#372=LINE($,#369,#371);@@ -382,20 +382,20 @@ DATA;#375=EDGE_LOOP($,(#356,#362,#368,#374));#376=FACE_OUTER_BOUND('',#375,.T.);#377=ADVANCED_FACE('',(#376),#355,.T.);-#378=CARTESIAN_POINT($,(-20,10,16));+#378=CARTESIAN_POINT($,(5,20,30));#379=DIRECTION($,(0,1,0));#380=DIRECTION($,(-1,0,0));#381=AXIS2_PLACEMENT_3D($,#378,#379,#380);#382=PLANE($,#381);#383=ORIENTED_EDGE($,$,$,#70,.T.);-#384=CARTESIAN_POINT($,(-30,10,12));+#384=CARTESIAN_POINT($,(0,20,25));#385=DIRECTION($,(1,0,0));#386=VECTOR($,#385,1);#387=LINE($,#384,#386);#388=EDGE_CURVE($,#57,#137,#387,.T.);#389=ORIENTED_EDGE($,$,$,#388,.T.);#390=ORIENTED_EDGE($,$,$,#142,.F.);-#391=CARTESIAN_POINT($,(-10,10,-4));+#391=CARTESIAN_POINT($,(10,20,-0));#392=DIRECTION($,(1,0,0));#393=VECTOR($,#392,1);#394=LINE($,#391,#393);@@ -404,19 +404,19 @@ DATA;#397=EDGE_LOOP($,(#383,#389,#390,#396));#398=FACE_OUTER_BOUND('',#397,.T.);#399=ADVANCED_FACE('',(#398),#382,.T.);-#400=CARTESIAN_POINT($,(-20,10,16));+#400=CARTESIAN_POINT($,(5,20,30));#401=DIRECTION($,(0,1,0));#402=DIRECTION($,(-1,0,0));#403=AXIS2_PLACEMENT_3D($,#400,#401,#402);#404=PLANE($,#403);#405=ORIENTED_EDGE($,$,$,#367,.T.);-#406=CARTESIAN_POINT($,(-30,10,20));+#406=CARTESIAN_POINT($,(-0,20,35));#407=DIRECTION($,(1,0,0));#408=VECTOR($,#407,1);#409=LINE($,#406,#408);#410=EDGE_CURVE($,#105,#169,#409,.T.);#411=ORIENTED_EDGE($,$,$,#410,.T.);-#412=CARTESIAN_POINT($,(-10,10,20));+#412=CARTESIAN_POINT($,(10,20,35));#413=DIRECTION($,(0,0,1));#414=VECTOR($,#413,1);#415=LINE($,#412,#414);@@ -426,13 +426,13 @@ DATA;#419=EDGE_LOOP($,(#405,#411,#417,#418));#420=FACE_OUTER_BOUND('',#419,.T.);#421=ADVANCED_FACE('',(#420),#404,.T.);-#422=CARTESIAN_POINT($,(-20,10,16));+#422=CARTESIAN_POINT($,(5,20,30));#423=DIRECTION($,(0,1,0));#424=DIRECTION($,(-1,0,0));#425=AXIS2_PLACEMENT_3D($,#422,#423,#424);#426=PLANE($,#425);#427=ORIENTED_EDGE($,$,$,#110,.T.);-#428=CARTESIAN_POINT($,(-30,10,36));+#428=CARTESIAN_POINT($,(-0,20,60));#429=DIRECTION($,(1,0,0));#430=VECTOR($,#429,1);#431=LINE($,#428,#430);@@ -443,20 +443,20 @@ DATA;#436=EDGE_LOOP($,(#427,#433,#434,#435));#437=FACE_OUTER_BOUND('',#436,.T.);#438=ADVANCED_FACE('',(#437),#426,.T.);-#439=CARTESIAN_POINT($,(-20,10,16));+#439=CARTESIAN_POINT($,(5,20,30));#440=DIRECTION($,(0,1,0));#441=DIRECTION($,(-1,0,0));#442=AXIS2_PLACEMENT_3D($,#439,#440,#441);#443=PLANE($,#442);#444=ORIENTED_EDGE($,$,$,#416,.T.);-#445=CARTESIAN_POINT($,(-10,10,20));+#445=CARTESIAN_POINT($,(10,20,35));#446=DIRECTION($,(1,0,0));#447=VECTOR($,#446,1);#448=LINE($,#445,#447);#449=EDGE_CURVE($,#169,#217,#448,.T.);#450=ORIENTED_EDGE($,$,$,#449,.T.);#451=ORIENTED_EDGE($,$,$,#222,.F.);-#452=CARTESIAN_POINT($,(10,10,12));+#452=CARTESIAN_POINT($,(35,20,25));#453=DIRECTION($,(1,0,0));#454=VECTOR($,#453,1);#455=LINE($,#452,#454);@@ -465,7 +465,7 @@ DATA;#458=EDGE_LOOP($,(#444,#450,#451,#457));#459=FACE_OUTER_BOUND('',#458,.T.);#460=ADVANCED_FACE('',(#459),#443,.T.);-#461=CARTESIAN_POINT($,(-20,0,-4));+#461=CARTESIAN_POINT($,(5,10,0));#462=DIRECTION($,(0,0,-1));#463=DIRECTION($,(1,0,0));#464=AXIS2_PLACEMENT_3D($,#461,#462,#463);@@ -477,7 +477,7 @@ DATA;#470=EDGE_LOOP($,(#466,#467,#468,#469));#471=FACE_OUTER_BOUND('',#470,.T.);#472=ADVANCED_FACE('',(#471),#465,.T.);-#473=CARTESIAN_POINT($,(-20,0,12));+#473=CARTESIAN_POINT($,(5,10,25));#474=DIRECTION($,(0,0,-1));#475=DIRECTION($,(1,0,0));#476=AXIS2_PLACEMENT_3D($,#473,#474,#475);@@ -489,7 +489,7 @@ DATA;#482=EDGE_LOOP($,(#478,#479,#480,#481));#483=FACE_OUTER_BOUND('',#482,.T.);#484=ADVANCED_FACE('',(#483),#477,.T.);-#485=CARTESIAN_POINT($,(-20,0,12));+#485=CARTESIAN_POINT($,(5,10,25));#486=DIRECTION($,(0,0,-1));#487=DIRECTION($,(1,0,0));#488=AXIS2_PLACEMENT_3D($,#485,#486,#487);@@ -501,7 +501,7 @@ DATA;#494=EDGE_LOOP($,(#490,#491,#492,#493));#495=FACE_OUTER_BOUND('',#494,.T.);#496=ADVANCED_FACE('',(#495),#489,.T.);-#497=CARTESIAN_POINT($,(-20,0,20));+#497=CARTESIAN_POINT($,(5,10,35));#498=DIRECTION($,(0,0,1));#499=DIRECTION($,(1,0,0));#500=AXIS2_PLACEMENT_3D($,#497,#498,#499);@@ -513,7 +513,7 @@ DATA;#506=EDGE_LOOP($,(#502,#503,#504,#505));#507=FACE_OUTER_BOUND('',#506,.T.);#508=ADVANCED_FACE('',(#507),#501,.T.);-#509=CARTESIAN_POINT($,(-20,0,20));+#509=CARTESIAN_POINT($,(5,10,35));#510=DIRECTION($,(0,0,1));#511=DIRECTION($,(1,0,0));#512=AXIS2_PLACEMENT_3D($,#509,#510,#511);@@ -525,7 +525,7 @@ DATA;#518=EDGE_LOOP($,(#514,#515,#516,#517));#519=FACE_OUTER_BOUND('',#518,.T.);#520=ADVANCED_FACE('',(#519),#513,.T.);-#521=CARTESIAN_POINT($,(-20,0,36));+#521=CARTESIAN_POINT($,(5,10,60));#522=DIRECTION($,(0,0,1));#523=DIRECTION($,(1,0,0));#524=AXIS2_PLACEMENT_3D($,#521,#522,#523);diff --git a/Aetheris.Firmament.FrictionLab/Reports/fl2i-followup-simple-bracket-summary.json b/Aetheris.Firmament.FrictionLab/Reports/fl2i-followup-simple-bracket-summary.jsonnew file mode 100644index 00000000..c8c31fb0--- /dev/null+++ b/Aetheris.Firmament.FrictionLab/Reports/fl2i-followup-simple-bracket-summary.json@@ -0,0 +1,18 @@+{+ "totalCases": 1,+ "successCount": 1,+ "partialCount": 0,+ "failureCount": 0,+ "caseResults": [+ {+ "caseId": "simple-bracket",+ "buildStatus": "success",+ "artifactPresent": true,+ "stepArtifactPath": "Aetheris.Firmament.FrictionLab/Reports/Artifacts/simple-bracket.step",+ "possible": "true",+ "awkwardness": "low",+ "diagnostics": []+ }+ ],+ "summaryPath": "Aetheris.Firmament.FrictionLab/Reports/fl2i-followup-simple-bracket-summary.json"+}\ No newline at end of filediff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentBuildAndExportTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentBuildAndExportTests.csindex 4a712a91..adf48426 100644--- a/Aetheris.Kernel.Firmament.Tests/FirmamentBuildAndExportTests.cs+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentBuildAndExportTests.cs@@ -392,36 +392,68 @@ public sealed class FirmamentBuildAndExportTests}[Fact]- public void Run_FrictionLabSimpleBracket_ExportedStep_Remains_NonBox_LShape()+ public void Run_FrictionLabSimpleBracket_ExportedStep_Matches_FL2i_Canonical_LShape_Constraints(){- var sourceText = File.ReadAllText(- Path.Combine(FirmamentCorpusHarness.RepoRoot(), "Aetheris.Firmament.FrictionLab/Cases/simple-bracket/part.firmament"),- Encoding.UTF8);- var compiler = new FirmamentCompiler();- var compilation = compiler.Compile(new FirmamentCompileRequest(new FirmamentSourceDocument(sourceText))).Compilation;-- Assert.True(compilation.IsSuccess, string.Join(Environment.NewLine, compilation.Diagnostics.Select(d => d.Message)));- var finalBody = Assert.Single(compilation.Value.PrimitiveExecutionResult!.ExecutedBooleans, b => b.FeatureId == "bracket").Body;- Assert.False(Aetheris.Kernel.Core.Brep.Boolean.BrepBooleanBoxRecognition.TryRecognizeAxisAlignedBox(finalBody, Aetheris.Kernel.Core.Numerics.ToleranceContext.Default, out _, out _));-- var planarFaces = finalBody.Topology.Faces- .Select(face =>- {- finalBody.TryGetFaceSurfaceGeometry(face.Id, out var surface);- return surface;- })- .Where(surface => surface?.Kind == Aetheris.Kernel.Core.Geometry.SurfaceGeometryKind.Plane)- .Select(surface => surface!.Plane!.Value)+ var fullSourcePath = Path.Combine(FirmamentCorpusHarness.RepoRoot(), "Aetheris.Firmament.FrictionLab/Cases/simple-bracket/part.firmament");+ var build = FirmamentBuildAndExport.Run(fullSourcePath);++ Assert.True(build.IsSuccess, string.Join(Environment.NewLine, build.Diagnostics.Select(d => d.Message)));+ Assert.Equal("bracket", build.Value.Export.ExportedFeatureId);+ Assert.Equal("boolean", build.Value.Export.ExportedBodyCategory);+ Assert.Equal("add", build.Value.Export.ExportedFeatureKind);++ Assert.DoesNotContain("TRIANGULATED_FACE_SET", build.Value.Export.StepText, StringComparison.Ordinal);+ Assert.True(CountOccurrences(build.Value.Export.StepText, "ADVANCED_FACE") > 6);++ var sourceText = File.ReadAllText(fullSourcePath, Encoding.UTF8);+ Assert.Contains("ops[2]", sourceText, StringComparison.Ordinal);+ Assert.Contains(@"size[3]:+ 60+ 20+ 10", sourceText, StringComparison.Ordinal);+ Assert.Contains(@"size[3]:+ 10+ 20+ 60", sourceText, StringComparison.Ordinal);+ Assert.Contains(@"offset[3]:+ 55+ 10+ 5", sourceText, StringComparison.Ordinal);+ Assert.Contains(@"offset[3]:+ 5+ 10+ 30", sourceText, StringComparison.Ordinal);+ Assert.DoesNotContain("op: subtract", sourceText, StringComparison.Ordinal);++ var pointPattern = new System.Text.RegularExpressions.Regex(+ @"CARTESIAN_POINT\([^\)]*\(([-0-9.E+]+),([-0-9.E+]+),([-0-9.E+]+)\)\)",+ System.Text.RegularExpressions.RegexOptions.Compiled);+ var points = pointPattern.Matches(build.Value.Export.StepText)+ .Select(match => (+ X: double.Parse(match.Groups[1].Value, System.Globalization.CultureInfo.InvariantCulture),+ Y: double.Parse(match.Groups[2].Value, System.Globalization.CultureInfo.InvariantCulture),+ Z: double.Parse(match.Groups[3].Value, System.Globalization.CultureInfo.InvariantCulture))).ToArray();+ Assert.NotEmpty(points);++ var minX = points.Min(p => p.X);+ var maxX = points.Max(p => p.X);+ var minY = points.Min(p => p.Y);+ var maxY = points.Max(p => p.Y);+ var minZ = points.Min(p => p.Z);+ var maxZ = points.Max(p => p.Z);- Assert.Contains(planarFaces, plane => Math.Abs(plane.Normal.ToVector().X) > 0.9d && Math.Abs(plane.Origin.X + 50d) < 1e-6d);- Assert.True(planarFaces.Length > 6, "Simple bracket must not collapse to a six-face bounding box.");+ Assert.Equal(60d, maxX - minX, 6);+ Assert.Equal(20d, maxY - minY, 6);+ Assert.Equal(60d, maxZ - minZ, 6);- var export = FirmamentStepExporter.Export(compilation.Value);- Assert.True(export.IsSuccess, string.Join(Environment.NewLine, export.Diagnostics.Select(d => d.Message)));- Assert.True(CountOccurrences(export.Value.StepText, "ADVANCED_FACE") > 6);+ Assert.DoesNotContain("B_SPLINE", build.Value.Export.StepText, StringComparison.Ordinal);+ Assert.DoesNotContain("TOROIDAL_SURFACE", build.Value.Export.StepText, StringComparison.Ordinal);+ Assert.DoesNotContain("CONICAL_SURFACE", build.Value.Export.StepText, StringComparison.Ordinal);+ Assert.DoesNotContain("SPHERICAL_SURFACE", build.Value.Export.StepText, StringComparison.Ordinal);}+[Fact]public void Run_FrictionLabMountingBracketBasic_ContinuedRoot_SubtractPlacement_Uses_World_Frame(){