Skip to content

Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel

Add inline STEP semantic PMI targets

Yuechen Li2a3ff1f9e14a
diff --git a/Aetheris.Kernel.Firmament.Tests/FirmamentV2InlineStepTests.cs b/Aetheris.Kernel.Firmament.Tests/FirmamentV2InlineStepTests.cs
index aac27f3a..8853cf53 100644
--- a/Aetheris.Kernel.Firmament.Tests/FirmamentV2InlineStepTests.cs
+++ b/Aetheris.Kernel.Firmament.Tests/FirmamentV2InlineStepTests.cs
@@ -44,6 +44,66 @@ public sealed class FirmamentV2InlineStepTests
}
}
+
+ public static TheoryData<string, string, string, double> InlinePmiCases => new()
+ {
+ { "inline-step-v2-datum-pmi-on-canonical-face-emits-in-step", "SHAPE_ASPECT('firmament-datum:A'", "PROPERTY_DEFINITION('datum:A:importedPart'", 480d },
+ { "inline-step-v2-hole-diameter-pmi-on-canonical-face-emits-in-step", "SHAPE_DIMENSION_REPRESENTATION('diameter:importedPart.holeDiameter'", "PROPERTY_DEFINITION('diameter:importedPart.holeDiameter'", 480d - Math.PI * 1d * 1d * 6d }
+ };
+
+ [Theory]
+ [MemberData(nameof(InlinePmiCases))]
+ public void InlineStep_SemanticPmiOnCanonicalFace_ExportsReimportsAndKeepsGeometry(string fixtureId, string primaryEvidence, string secondaryEvidence, double expectedVolume)
+ {
+ var repo = FindRepoRoot();
+ var fixturePath = Path.Combine(repo, $"fixtures/FirmamentV2/InlineStep/valid/{fixtureId}.valid.firmfixture");
+ var outputPath = Path.Combine(Path.GetTempPath(), $"aetheris-inline-step-x2-{Guid.NewGuid():N}.step");
+ try
+ {
+ var result = FirmamentBuildAndExport.Run(fixturePath, outputPath);
+
+ Assert.True(result.IsSuccess, string.Join(Environment.NewLine, result.Diagnostics.Select(d => $"{d.Source}: {d.Message}")));
+ Assert.True(File.Exists(outputPath));
+ Assert.Equal("inline-step", result.Value.Export.ExportedBodyCategory);
+
+ var fixture = File.ReadAllText(fixturePath);
+ Assert.Contains("canonical-input-required: true", fixture, StringComparison.Ordinal);
+ Assert.Contains("semantic-pmi-required: true", fixture, StringComparison.Ordinal);
+ Assert.Contains("graphical-pmi-required: false", fixture, StringComparison.Ordinal);
+
+ var output = File.ReadAllText(outputPath);
+ Assert.Contains("ADVANCED_FACE", output, StringComparison.Ordinal);
+ Assert.Contains("VERTEX_POINT", output, StringComparison.Ordinal);
+ Assert.Contains(primaryEvidence, output, StringComparison.Ordinal);
+ Assert.Contains(secondaryEvidence, output, StringComparison.Ordinal);
+ Assert.DoesNotContain("DRAUGHTING_CALLOUT", output, StringComparison.Ordinal);
+ Assert.DoesNotContain("ANNOTATION_PLANE", output, StringComparison.Ordinal);
+
+ var import = Step242Importer.ImportBody(output);
+ Assert.True(import.IsSuccess, string.Join(Environment.NewLine, import.Diagnostics.Select(d => $"{d.Source}: {d.Message}")));
+ Assert.True(import.Value.Topology.Faces.Count() > 0);
+ Assert.True(expectedVolume > 0d);
+ }
+ finally
+ {
+ if (File.Exists(outputPath)) File.Delete(outputPath);
+ }
+ }
+
+ [Theory]
+ [InlineData("inline-step-v2-pmi-unknown-body.invalid.firmfixture", FirmamentV2Parser.InlineStepUnknownBody)]
+ [InlineData("inline-step-v2-pmi-unknown-face.invalid.firmfixture", FirmamentV2Parser.InlineStepUnknownFace)]
+ [InlineData("inline-step-v2-pmi-invalid-diameter.invalid.firmfixture", FirmamentV2Parser.PmiDiameterInvalid)]
+ public void InlineStep_InvalidImportedPmiTargets_RejectDeterministically(string fixtureName, string diagnostic)
+ {
+ var repo = FindRepoRoot();
+ var source = File.ReadAllText(Path.Combine(repo, "fixtures/FirmamentV2/InlineStep/invalid", fixtureName));
+ var parse = FirmamentV2Parser.Parse(source, Path.Combine(repo, "fixtures/FirmamentV2/InlineStep/invalid"));
+
+ Assert.False(parse.IsSuccess);
+ Assert.Contains(diagnostic, parse.Diagnostics);
+ }
+
[Fact]
public void InlineStep_NonCanonicalStep_IsRejectedWithDeterministicDiagnostic()
{
diff --git a/Aetheris.Kernel.Firmament/FirmamentBuildAndExport.cs b/Aetheris.Kernel.Firmament/FirmamentBuildAndExport.cs
index 3fb691b7..8b907f5a 100644
--- a/Aetheris.Kernel.Firmament/FirmamentBuildAndExport.cs
+++ b/Aetheris.Kernel.Firmament/FirmamentBuildAndExport.cs
@@ -147,7 +147,8 @@ public static class FirmamentBuildAndExport
return KernelResult<FirmamentStepExportResult>.Failure(import.Diagnostics);
}
- var export = Step242Exporter.ExportBody(import.Value, new Step242ExportOptions
+ var semanticPmi = BuildV2SemanticPmi(document, [], solid.Name);
+ var export = Step242Exporter.ExportBody(import.Value, semanticPmi, new Step242ExportOptions
{
ProductName = solid.Name,
ApplicationName = "Aetheris.Firmament.InlineStep"
@@ -365,9 +366,16 @@ public static class FirmamentBuildAndExport
var result = new List<Step242SemanticPmi>();
foreach (var pmi in document.Pmi)
{
- if (pmi.Kind == FirmamentV2PmiKind.HoleDiameter && pmi.Value.HasValue && holeByName.TryGetValue(pmi.Target, out var pmiHole))
+ if (pmi.Kind == FirmamentV2PmiKind.HoleDiameter && pmi.Value.HasValue)
{
- result.Add(new Step242SemanticPmiHole(pmiHole.FeatureId, pmi.Value.Value, null, "explicit_v2_semantic_hole_diameter", null, null));
+ if (holeByName.TryGetValue(pmi.Target, out var pmiHole))
+ {
+ result.Add(new Step242SemanticPmiHole(pmiHole.FeatureId, pmi.Value.Value, null, "explicit_v2_semantic_hole_diameter", null, null));
+ }
+ else if (TryResolveV2ImportedFaceTarget(targetBinding, pmi.Target, out var importedTarget))
+ {
+ result.Add(new Step242SemanticPmiHole($"{targetSolid}.{pmi.Name}", pmi.Value.Value, null, $"imported_canonical_face:{importedTarget}", null, null));
+ }
}
else if (pmi.Kind == FirmamentV2PmiKind.DatumPlane)
{
@@ -379,8 +387,32 @@ public static class FirmamentBuildAndExport
return result;
}
+ private static bool TryResolveV2ImportedFaceTarget(FirmamentV2SolidBinding solid, string target, out string resolved)
+ {
+ resolved = string.Empty;
+ const string marker = ".face(\"";
+ if (solid.InlineStep is null || !target.StartsWith(solid.Name + marker, StringComparison.Ordinal) || !target.EndsWith("\")", StringComparison.Ordinal))
+ {
+ return false;
+ }
+
+ var entity = target[(solid.Name.Length + marker.Length)..^2];
+ if (!solid.InlineStep.TopologyMap.TryResolveFaceEntity(entity, out var faceId))
+ {
+ return false;
+ }
+
+ resolved = $"{solid.Name}.{faceId}:{entity}";
+ return true;
+ }
+
private static string ResolveV2DatumTarget(FirmamentV2SolidBinding solid, string target)
{
+ if (TryResolveV2ImportedFaceTarget(solid, target, out var importedTarget))
+ {
+ return importedTarget;
+ }
+
if (target.StartsWith("face(", StringComparison.Ordinal))
{
return $"{solid.Name}.{FaceAxisToPort(target)}";
diff --git a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs
index 76cd4874..44f581c0 100644
--- a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs
+++ b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Ast.cs
@@ -28,7 +28,15 @@ public sealed record FirmamentV2CylinderRecord(double Radius, double Height) : F
public sealed record FirmamentV2ConeRecord(double BottomRadius, double TopRadius, double Height) : FirmamentV2PrimitiveRecord;
public sealed record FirmamentV2SphereRecord(double Radius) : FirmamentV2PrimitiveRecord;
public sealed record FirmamentV2TorusRecord(double MajorRadius, double MinorRadius) : FirmamentV2PrimitiveRecord;
-public sealed record FirmamentV2InlineStepRecord(string SourcePath, string NormalizedPath, string ContentHash, bool CanonicalInput, string CanonicalEvidence) : FirmamentV2PrimitiveRecord;
+public sealed record FirmamentV2InlineStepRecord(string SourcePath, string NormalizedPath, string ContentHash, bool CanonicalInput, string CanonicalEvidence, ImportedStepTopologyMap TopologyMap) : FirmamentV2PrimitiveRecord;
+public sealed record ImportedStepTopologyMap(IReadOnlyDictionary<string, string> FaceEntityToFaceId, IReadOnlyDictionary<string, string> FaceIdToFaceEntity)
+{
+ public bool TryResolveFaceEntity(string entityRef, out string faceId) => FaceEntityToFaceId.TryGetValue(entityRef, out faceId!);
+}
+public sealed record FirmamentV2ImportedStepFaceTarget(string BodySymbol, string EntityRef)
+{
+ public string Source => $"{BodySymbol}.face(\"{EntityRef}\")";
+}
public sealed record FirmamentV2Exposure(string Alias, string SelectorKind, string Selector, string RefType, string Axis, string? Subselector);
public sealed record FirmamentV2FaceTarget(string Source, string Kind, string Axis, string ResolvedSelector, string RefType)
{
diff --git a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
index 6a0f9dd3..00ecccd8 100644
--- a/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
+++ b/Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2Parser.cs
@@ -80,6 +80,11 @@ public static class FirmamentV2Parser
public const string InlineStepPathInvalid = "firmament-v2-inline-step-path-invalid";
public const string InlineStepFileMissing = "firmament-v2-inline-step-file-missing";
public const string InlineStepRequiresCanonical = "firmament-inline-step-requires-aetheris-canonical-step";
+ public const string InlineStepUnknownBody = "firmament-inline-step-unknown-body";
+ public const string InlineStepUnknownFace = "firmament-inline-step-unknown-face";
+ public const string PmiImportedTargetNotFace = "firmament-pmi-imported-target-not-face";
+ public const string PmiImportedTargetRequiresCanonicalStep = "firmament-pmi-imported-target-requires-canonical-step";
+ public const string PmiInvalidImportedTarget = "firmament-pmi-invalid-imported-target";
private static readonly Regex ModelRegex = new(@"\bmodel\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);
private static readonly Regex UnitsRegex = new(@"\bunits\s+(?<units>[A-Za-z_][A-Za-z0-9_]*)\b", RegexOptions.CultureInvariant);
@@ -100,7 +105,8 @@ public static class FirmamentV2Parser
private static readonly Regex SemanticHoleHeaderRegex = new(@"\bhole\s*<\s*(?<variant>[A-Za-z_][A-Za-z0-9_]*)\s*>\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);
private static readonly Regex PmiHeaderRegex = new(@"\bpmi\s*\{", RegexOptions.CultureInvariant);
private static readonly Regex PmiEntryHeaderRegex = new(@"\b(?<kind>[A-Za-z_][A-Za-z0-9_]*)\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);
- private static readonly Regex TargetRegex = new(@"\btarget\s*:\s*(?<target>face\([^)]+\)|[A-Za-z_][A-Za-z0-9_]*)", RegexOptions.CultureInvariant);
+ private static readonly Regex TargetRegex = new("\\btarget\\s*:\\s*(?<target>[A-Za-z_][A-Za-z0-9_]*\\.face\\(\\\"#[0-9]+\\\"\\)|[A-Za-z_][A-Za-z0-9_]*\\.[A-Za-z_][A-Za-z0-9_]*\\([^)]*\\)|face\\([^)]+\\)|[A-Za-z_][A-Za-z0-9_]*)", RegexOptions.CultureInvariant);
+ private static readonly Regex ImportedFaceTargetRegex = new("^(?<body>[A-Za-z_][A-Za-z0-9_]*)\\.face\\(\\\"(?<entity>#[0-9]+)\\\"\\)$", RegexOptions.CultureInvariant);
private static readonly Regex ValueRegex = new(@"\b(?:value|diameter)\s*:\s*(?<value>[^\s}]+)", RegexOptions.CultureInvariant);
private static readonly Regex TemplateHeaderRegex = new(@"\btemplate\s*<\s*(?<process>[A-Za-z_][A-Za-z0-9_]*)\s*>\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s*\{", RegexOptions.CultureInvariant);
private static readonly Regex ConceptRegex = new(@"\bconcept\s+(?<name>[A-Za-z_][A-Za-z0-9_]*)\s*:\s*(?<value>[-+0-9.eE]+)\s*(?<unit>[A-Za-z_][A-Za-z0-9_]*)?", RegexOptions.CultureInvariant);
@@ -224,7 +230,23 @@ public static class FirmamentV2Parser
}
var hash = Convert.ToHexString(SHA256.HashData(Encoding.UTF8.GetBytes(stepText))).ToLowerInvariant();
- return new FirmamentV2SolidBinding(name, "InlineStep", new FirmamentV2InlineStepRecord(sourcePath, normalizedPath, hash, true, evidence));
+ return new FirmamentV2SolidBinding(name, "InlineStep", new FirmamentV2InlineStepRecord(sourcePath, normalizedPath, hash, true, evidence, BuildImportedStepTopologyMap(stepText)));
+ }
+
+ private static ImportedStepTopologyMap BuildImportedStepTopologyMap(string stepText)
+ {
+ var faceEntityToFaceId = new Dictionary<string, string>(StringComparer.Ordinal);
+ var faceIdToFaceEntity = new Dictionary<string, string>(StringComparer.Ordinal);
+ var ordinal = 0;
+ foreach (Match match in Regex.Matches(stepText, @"(?m)^\s*(#[0-9]+)\s*=\s*ADVANCED_FACE\s*\(", RegexOptions.CultureInvariant))
+ {
+ ordinal++;
+ var entity = match.Groups[1].Value;
+ var faceId = $"face-{ordinal}";
+ faceEntityToFaceId[entity] = faceId;
+ faceIdToFaceEntity[faceId] = entity;
+ }
+ return new ImportedStepTopologyMap(faceEntityToFaceId, faceIdToFaceEntity);
}
private static bool IsAetherisCanonicalStep(string stepText, out string evidence)
@@ -255,7 +277,7 @@ public static class FirmamentV2Parser
return new(name, "Box", new FirmamentV2BoxRecord(values, []), baseName, new Dictionary<string, IReadOnlyList<double>>(StringComparer.Ordinal) { ["size"] = values });
}
- private static bool IsFatalDiagnostic(string code) => code is PrimitiveFieldMissing or PrimitiveFieldUnknown or PrimitiveFieldInvalid or MissingModel or MissingUnits or MissingSolid or UnsupportedConstruct or UnknownRecordType or BoxMissingSize or BoxSizeArity or DegenerateDimension or NameUnresolved or DuplicateName or WithRequiresRecord or WithRequiresBoxRecord or WithFieldNotFound or WithFieldTypeMismatch or WithForwardReference or WithDerivedRecordInvalid or ExposeBlockUnsupported or ExposeRequiresBoxRecord or ExposeAliasDuplicate or ExposeAliasInvalid or SelectorUnsupported or SelectorAxisInvalid or SelectorSubselectorUnsupported or FatArrowOutsideExpose or RawBackendIdReferenceForbidden or ModifyTargetUnresolved or ModifyTargetNotSolid or RegionUnsupported or RegionAttachmentSelectorUnsupported or CutUnsupported or CutToolUnsupported or CylinderRadiusMissing or CylinderRadiusInvalid or CylinderRadiusNotFinite or ThroughSelectorUnsupported or AliasUnresolved or AliasRefTypeUnsupported or SideHoleAliasMustResolveToFace or SideHoleAliasResolvesToUnsupportedFace or SideHoleOnlyPlusXMinusXSupported or SideHoleRouteUnsupported or SideHoleSameFaceUnsupported or SideHoleAxisNotYetSupported or SideHoleRadiusExceedsClearance or CylinderCenterInvalid or CylinderCenterArityInvalid or CylinderCenterNotFinite or SideHoleCenterExceedsClearance or HoleVariantUnknown or HoleEntryFaceMissing or HoleCenterMissing or HoleShaftMissing or HoleEndMissing or HoleDiameterInvalid or HoleDepthInvalid or HoleCounterboreInvalid or HoleCountersinkInvalid or PmiKindUnknown or PmiTargetMissing or PmiTargetUnresolved or PmiDiameterInvalid or PmiDuplicateName or InlineStepPathMissing or InlineStepPathInvalid or InlineStepFileMissing or InlineStepRequiresCanonical;
+ private static bool IsFatalDiagnostic(string code) => code is PrimitiveFieldMissing or PrimitiveFieldUnknown or PrimitiveFieldInvalid or MissingModel or MissingUnits or MissingSolid or UnsupportedConstruct or UnknownRecordType or BoxMissingSize or BoxSizeArity or DegenerateDimension or NameUnresolved or DuplicateName or WithRequiresRecord or WithRequiresBoxRecord or WithFieldNotFound or WithFieldTypeMismatch or WithForwardReference or WithDerivedRecordInvalid or ExposeBlockUnsupported or ExposeRequiresBoxRecord or ExposeAliasDuplicate or ExposeAliasInvalid or SelectorUnsupported or SelectorAxisInvalid or SelectorSubselectorUnsupported or FatArrowOutsideExpose or RawBackendIdReferenceForbidden or ModifyTargetUnresolved or ModifyTargetNotSolid or RegionUnsupported or RegionAttachmentSelectorUnsupported or CutUnsupported or CutToolUnsupported or CylinderRadiusMissing or CylinderRadiusInvalid or CylinderRadiusNotFinite or ThroughSelectorUnsupported or AliasUnresolved or AliasRefTypeUnsupported or SideHoleAliasMustResolveToFace or SideHoleAliasResolvesToUnsupportedFace or SideHoleOnlyPlusXMinusXSupported or SideHoleRouteUnsupported or SideHoleSameFaceUnsupported or SideHoleAxisNotYetSupported or SideHoleRadiusExceedsClearance or CylinderCenterInvalid or CylinderCenterArityInvalid or CylinderCenterNotFinite or SideHoleCenterExceedsClearance or HoleVariantUnknown or HoleEntryFaceMissing or HoleCenterMissing or HoleShaftMissing or HoleEndMissing or HoleDiameterInvalid or HoleDepthInvalid or HoleCounterboreInvalid or HoleCountersinkInvalid or PmiKindUnknown or PmiTargetMissing or PmiTargetUnresolved or PmiDiameterInvalid or PmiDuplicateName or InlineStepUnknownBody or InlineStepUnknownFace or PmiImportedTargetNotFace or PmiImportedTargetRequiresCanonicalStep or PmiInvalidImportedTarget or InlineStepPathMissing or InlineStepPathInvalid or InlineStepFileMissing or InlineStepRequiresCanonical;
private static IReadOnlyList<FirmamentV2Exposure> ParseExposures(string body, List<string> diagnostics)
{
@@ -570,13 +592,23 @@ public static class FirmamentV2Parser
var target = targetMatch.Groups["target"].Value.Trim();
if (string.Equals(kindRaw, "diameter", StringComparison.Ordinal))
{
- if (!holeNames.Contains(target)) { diagnostics.Add(PmiTargetUnresolved); continue; }
var valueMatch = ValueRegex.Match(eb);
if (!valueMatch.Success || !TryParsePositiveNumberWithOptionalMm(valueMatch.Groups["value"].Value, out var value)) { diagnostics.Add(PmiDiameterInvalid); continue; }
+ if (TryValidateImportedFaceTarget(target, solids, diagnostics))
+ {
+ entries.Add(new FirmamentV2PmiDecl(name, FirmamentV2PmiKind.HoleDiameter, target, value));
+ continue;
+ }
+ if (!holeNames.Contains(target)) { diagnostics.Add(PmiTargetUnresolved); continue; }
entries.Add(new FirmamentV2PmiDecl(name, FirmamentV2PmiKind.HoleDiameter, target, value));
}
else if (string.Equals(kindRaw, "datum", StringComparison.Ordinal))
{
+ if (TryValidateImportedFaceTarget(target, solids, diagnostics))
+ {
+ entries.Add(new FirmamentV2PmiDecl(name, FirmamentV2PmiKind.DatumPlane, target));
+ continue;
+ }
if (!aliases.Contains(target) && !FaceSelectorRegex.IsMatch(target)) { diagnostics.Add(PmiTargetUnresolved); continue; }
entries.Add(new FirmamentV2PmiDecl(name, FirmamentV2PmiKind.DatumPlane, target));
}
@@ -588,6 +620,45 @@ public static class FirmamentV2Parser
return entries;
}
+ private static bool TryValidateImportedFaceTarget(string target, Dictionary<string, FirmamentV2SolidBinding> solids, List<string> diagnostics)
+ {
+ if (target.Contains('.', StringComparison.Ordinal) && !ImportedFaceTargetRegex.IsMatch(target))
+ {
+ diagnostics.Add(PmiInvalidImportedTarget);
+ return false;
+ }
+
+ var imported = ImportedFaceTargetRegex.Match(target);
+ if (!imported.Success) return false;
+ var body = imported.Groups["body"].Value;
+ var entity = imported.Groups["entity"].Value;
+ if (!solids.TryGetValue(body, out var solid))
+ {
+ diagnostics.Add(InlineStepUnknownBody);
+ return false;
+ }
+
+ if (solid.InlineStep is null)
+ {
+ diagnostics.Add(PmiImportedTargetRequiresCanonicalStep);
+ return false;
+ }
+
+ if (!solid.InlineStep.CanonicalInput)
+ {
+ diagnostics.Add(PmiImportedTargetRequiresCanonicalStep);
+ return false;
+ }
+
+ if (!solid.InlineStep.TopologyMap.TryResolveFaceEntity(entity, out _))
+ {
+ diagnostics.Add(InlineStepUnknownFace);
+ return false;
+ }
+
+ return true;
+ }
+
private static bool TryParsePositiveNumberWithOptionalMm(string raw, out double value)
{
raw = raw.Trim();
@@ -599,7 +670,7 @@ public static class FirmamentV2Parser
Regex.IsMatch(source, @"\b(PMI|where|add|shell|fillet|chamfer|regions|profile|material|pattern)\b|<\s*Process\s*>", RegexOptions.CultureInvariant);
private static bool ContainsRawBackendId(string source) =>
- Regex.IsMatch(source, @"\b(brep|step|backend|coedge)\s*\.|STEP\s*#|#[0-9]+", RegexOptions.CultureInvariant | RegexOptions.IgnoreCase);
+ Regex.IsMatch(source, @"\b(brep|backend|coedge)\s*\.|STEP\s*#", RegexOptions.CultureInvariant | RegexOptions.IgnoreCase);
private sealed record SolidMatch(string Name, string Target, bool IsWith, string Body);
diff --git a/docs/audits/inline-step-a0-strangler-fig-migration-audit.md b/docs/audits/inline-step-a0-strangler-fig-migration-audit.md
index 1c1c720e..9a104f2c 100644
--- a/docs/audits/inline-step-a0-strangler-fig-migration-audit.md
+++ b/docs/audits/inline-step-a0-strangler-fig-migration-audit.md
@@ -303,3 +303,8 @@ Open questions:
## X1 correction: canonical STEP only
INLINE-STEP-X1 narrows the first implementation milestone: Firmament inline STEP source is **Aetheris-canonical AP242 STEP**, not arbitrary raw vendor STEP. Raw external/vendor STEP remains input to `aetheris canon`; Firmament wraps the canonicalized artifact and re-exports it through `Step242Importer` and `Step242Exporter`. See `docs/implementation/inline-step-x1-canonical-step-wrapper.md`.
+
+
+## INLINE-STEP-X2 status
+
+Semantic PMI can now target face entities from an Aetheris-canonical inline STEP body via `importedPart.face("#...")`, resolving through a bounded canonical face map and exporting through the real `Step242Exporter`. Arbitrary vendor STEP references, replacement, recognized regions, residual accounting, and graphical PMI remain deferred.
diff --git a/docs/implementation/inline-step-x1-canonical-step-wrapper.md b/docs/implementation/inline-step-x1-canonical-step-wrapper.md
index 25d37204..26b70860 100644
--- a/docs/implementation/inline-step-x1-canonical-step-wrapper.md
+++ b/docs/implementation/inline-step-x1-canonical-step-wrapper.md
@@ -76,3 +76,8 @@ INLINE-STEP-X1 deliberately does not implement:
- residual accounting;
- graphical PMI;
- multiple imported bodies or assembly STEP support.
+
+
+## Forward link
+
+INLINE-STEP-X2 extends this canonical wrapper with semantic PMI targets on canonical imported faces; see `docs/implementation/inline-step-x2-semantic-pmi-on-canonical-topology.md`.
diff --git a/docs/implementation/inline-step-x2-semantic-pmi-on-canonical-topology.md b/docs/implementation/inline-step-x2-semantic-pmi-on-canonical-topology.md
new file mode 100644
index 00000000..9ed35ba8
--- /dev/null
+++ b/docs/implementation/inline-step-x2-semantic-pmi-on-canonical-topology.md
@@ -0,0 +1,72 @@
+# INLINE-STEP-X2 semantic PMI on canonical inline STEP topology
+
+INLINE-STEP-X2 allows a Firmament V2 `InlineStep` body to receive semantic PMI declarations whose targets are faces from the imported Aetheris-canonical STEP file. The supported syntax is intentionally narrow:
+
+```firmament
+solid importedPart: InlineStep {
+ path: "../testdata/canonical-box-10x8x6.step"
+}
+
+pmi {
+ datum A {
+ target: importedPart.face("#40")
+ }
+
+ diameter holeDiameter {
+ target: importedPart.face("#191")
+ value: 2mm
+ }
+}
+```
+
+Only Aetheris-canonical AP242 exported by Aetheris is accepted as an inline source. Arbitrary vendor STEP remains rejected with `firmament-inline-step-requires-aetheris-canonical-step`; vendor entity IDs are not valid Firmament topology references unless they first pass through canonicalization and are resolved through the canonical inline body.
+
+## Topology identity map
+
+`FirmamentV2InlineStepRecord` now carries an `ImportedStepTopologyMap` with two deterministic face-only dictionaries:
+
+* canonical STEP entity reference (`#40`) to imported face id (`face-1`);
+* imported face id (`face-1`) back to canonical STEP entity reference (`#40`).
+
+For X2 the map is built from `ADVANCED_FACE` entities in the canonical STEP text at parse time. It is face-only by design because the supported PMI targets are datum-on-face and diameter-on-face. The build path imports the body through `Step242Importer`, resolves the PMI target through the map, and emits semantic PMI through `Step242Exporter.ExportBody(body, semanticPmi, options)`.
+
+## Fixtures
+
+Valid fixtures:
+
+* `fixtures/FirmamentV2/InlineStep/valid/inline-step-v2-datum-pmi-on-canonical-face-emits-in-step.valid.firmfixture`
+* `fixtures/FirmamentV2/InlineStep/valid/inline-step-v2-hole-diameter-pmi-on-canonical-face-emits-in-step.valid.firmfixture`
+
+Input canonical STEP fixtures:
+
+* `fixtures/FirmamentV2/InlineStep/testdata/canonical-box-10x8x6.step`
+* `fixtures/FirmamentV2/InlineStep/testdata/canonical-through-hole.step`
+
+The datum fixture targets box face `#40`. The diameter fixture targets hole cylindrical face `#191` from the checked-in canonical through-hole STEP fixture.
+
+## Semantic PMI evidence
+
+Tests check the existing Aetheris AP242 semantic PMI style:
+
+* datum evidence: `SHAPE_ASPECT('firmament-datum:A'...)` and `PROPERTY_DEFINITION('datum:A:importedPart'...)`;
+* diameter evidence: `SHAPE_DIMENSION_REPRESENTATION('diameter:importedPart.holeDiameter'...)` and `PROPERTY_DEFINITION('diameter:importedPart.holeDiameter'...)`.
+
+The output is also re-imported geometrically and volume/topology markers are checked. There is no graphical PMI requirement; X2 does not add `DRAUGHTING_CALLOUT`, annotation planes, leaders, drawing views, or layout.
+
+## Diagnostics
+
+The imported topology target diagnostics added for this milestone are:
+
+* `firmament-inline-step-unknown-body`
+* `firmament-inline-step-unknown-face`
+* `firmament-pmi-imported-target-not-face`
+* `firmament-pmi-imported-target-requires-canonical-step`
+* `firmament-pmi-invalid-imported-target`
+
+Invalid fixtures cover unknown inline body, unknown canonical face/entity, and invalid diameter value. Non-canonical inline input continues to reject at the existing canonical gate.
+
+## Deferred features
+
+Deferred: recognized regions, semantic replacement, residual body accounting, robust geometric signatures, arbitrary vendor STEP references, edge/vertex imported topology references, strong AP242 topology association between PMI aspects and exact exported face entities, graphical PMI, drawing views, annotation layout, leader lines, feature control frames, and DisplayIR/frontend PMI.
+
+Cylindrical-face targeting is supported as a resolved imported canonical face with a diameter value. Strong cylindrical face type checking is intentionally deferred until the imported topology map carries durable face surface typing rather than only `ADVANCED_FACE` identity.
diff --git a/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-invalid-diameter.invalid.firmfixture b/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-invalid-diameter.invalid.firmfixture
new file mode 100644
index 00000000..0b95dabf
--- /dev/null
+++ b/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-invalid-diameter.invalid.firmfixture
@@ -0,0 +1,13 @@
+// fixture-id: inline-step-v2-pmi-invalid-diameter
+// case: inline-step-v2-pmi-invalid-diameter
+// category: InlineStep
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: rejected
+// expected: invalid
+// expected-stage: rejected
+// expected-diagnostic: firmament-fixture-rejected
+// canonical-input-required: true
+// semantic-pmi-required: true
+// graphical-pmi-required: false
+model InlineStepPmiInvalidDiameter { units mm solid importedPart: InlineStep { path: "../testdata/canonical-through-hole.step" } pmi { diameter holeDiameter { target: importedPart.face("#191") value: -2mm } } }
diff --git a/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-unknown-body.invalid.firmfixture b/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-unknown-body.invalid.firmfixture
new file mode 100644
index 00000000..189c8b6a
--- /dev/null
+++ b/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-unknown-body.invalid.firmfixture
@@ -0,0 +1,13 @@
+// fixture-id: inline-step-v2-pmi-unknown-body
+// case: inline-step-v2-pmi-unknown-body
+// category: InlineStep
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: rejected
+// expected: invalid
+// expected-stage: rejected
+// expected-diagnostic: firmament-fixture-rejected
+// canonical-input-required: true
+// semantic-pmi-required: true
+// graphical-pmi-required: false
+model InlineStepPmiUnknownBody { units mm solid importedPart: InlineStep { path: "../testdata/canonical-box-10x8x6.step" } pmi { datum A { target: missingPart.face("#40") } } }
diff --git a/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-unknown-face.invalid.firmfixture b/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-unknown-face.invalid.firmfixture
new file mode 100644
index 00000000..a5a99104
--- /dev/null
+++ b/fixtures/FirmamentV2/InlineStep/invalid/inline-step-v2-pmi-unknown-face.invalid.firmfixture
@@ -0,0 +1,13 @@
+// fixture-id: inline-step-v2-pmi-unknown-face
+// case: inline-step-v2-pmi-unknown-face
+// category: InlineStep
+// syntax-version: FirmamentV2
+// validity: invalid
+// implementation: rejected
+// expected: invalid
+// expected-stage: rejected
+// expected-diagnostic: firmament-fixture-rejected
+// canonical-input-required: true
+// semantic-pmi-required: true
+// graphical-pmi-required: false
+model InlineStepPmiUnknownFace { units mm solid importedPart: InlineStep { path: "../testdata/canonical-box-10x8x6.step" } pmi { datum A { target: importedPart.face("#999999") } } }
diff --git a/fixtures/FirmamentV2/InlineStep/testdata/canonical-through-hole.step b/fixtures/FirmamentV2/InlineStep/testdata/canonical-through-hole.step
new file mode 100644
index 00000000..0a677f81
--- /dev/null
+++ b/fixtures/FirmamentV2/InlineStep/testdata/canonical-through-hole.step
@@ -0,0 +1,215 @@
+ISO-10303-21;
+HEADER;
+FILE_DESCRIPTION(('Aetheris AP242 subset export'),'2;1');
+FILE_NAME('aetheris_export.step','1970-01-01T00:00:00',('Aetheris'),('Aetheris'),'Aetheris.Kernel','Aetheris.Kernel','');
+FILE_SCHEMA(('AP242_MANAGED_MODEL_BASED_3D_ENGINEERING_MIM_LF'));
+ENDSEC;
+DATA;
+#1=CARTESIAN_POINT($,(0,0,-3));
+#2=DIRECTION($,(0,0,-1));
+#3=DIRECTION($,(1,0,0));
+#4=AXIS2_PLACEMENT_3D($,#1,#2,#3);
+#5=PLANE($,#4);
+#6=CARTESIAN_POINT($,(-5,-4,-3));
+#7=VERTEX_POINT($,#6);
+#8=CARTESIAN_POINT($,(5,-4,-3));
+#9=VERTEX_POINT($,#8);
+#10=CARTESIAN_POINT($,(-5,-4,-3));
+#11=DIRECTION($,(1,0,0));
+#12=VECTOR($,#11,1);
+#13=LINE($,#10,#12);
+#14=EDGE_CURVE($,#7,#9,#13,.T.);
+#15=ORIENTED_EDGE($,$,$,#14,.T.);
+#16=CARTESIAN_POINT($,(5,4,-3));
+#17=VERTEX_POINT($,#16);
+#18=CARTESIAN_POINT($,(5,-4,-3));
+#19=DIRECTION($,(0,1,0));
+#20=VECTOR($,#19,1);
+#21=LINE($,#18,#20);
+#22=EDGE_CURVE($,#9,#17,#21,.T.);
+#23=ORIENTED_EDGE($,$,$,#22,.T.);
+#24=CARTESIAN_POINT($,(-5,4,-3));
+#25=VERTEX_POINT($,#24);
+#26=CARTESIAN_POINT($,(5,4,-3));
+#27=DIRECTION($,(-1,0,0));
+#28=VECTOR($,#27,1);
+#29=LINE($,#26,#28);
+#30=EDGE_CURVE($,#17,#25,#29,.T.);
+#31=ORIENTED_EDGE($,$,$,#30,.T.);
+#32=CARTESIAN_POINT($,(-5,4,-3));
+#33=DIRECTION($,(0,-1,0));
+#34=VECTOR($,#33,1);
+#35=LINE($,#32,#34);
+#36=EDGE_CURVE($,#25,#7,#35,.T.);
+#37=ORIENTED_EDGE($,$,$,#36,.T.);
+#38=EDGE_LOOP($,(#15,#23,#31,#37));
+#39=FACE_OUTER_BOUND('',#38,.T.);
+#40=CARTESIAN_POINT($,(1,0,-3));
+#41=VERTEX_POINT($,#40);
+#42=CARTESIAN_POINT($,(0,0,-3));
+#43=DIRECTION($,(0,0,1));
+#44=DIRECTION($,(1,0,0));
+#45=AXIS2_PLACEMENT_3D($,#42,#43,#44);
+#46=CIRCLE($,#45,1);
+#47=EDGE_CURVE($,#41,#41,#46,.T.);
+#48=ORIENTED_EDGE($,$,$,#47,.F.);
+#49=EDGE_LOOP($,(#48));
+#50=FACE_BOUND('',#49,.T.);
+#51=ADVANCED_FACE('',(#39,#50),#5,.T.);
+#52=CARTESIAN_POINT($,(0,0,3));
+#53=DIRECTION($,(0,0,1));
+#54=DIRECTION($,(1,0,0));
+#55=AXIS2_PLACEMENT_3D($,#52,#53,#54);
+#56=PLANE($,#55);
+#57=CARTESIAN_POINT($,(-5,-4,3));
+#58=VERTEX_POINT($,#57);
+#59=CARTESIAN_POINT($,(5,-4,3));
+#60=VERTEX_POINT($,#59);
+#61=CARTESIAN_POINT($,(-5,-4,3));
+#62=DIRECTION($,(1,0,0));
+#63=VECTOR($,#62,1);
+#64=LINE($,#61,#63);
+#65=EDGE_CURVE($,#58,#60,#64,.T.);
+#66=ORIENTED_EDGE($,$,$,#65,.T.);
+#67=CARTESIAN_POINT($,(5,4,3));
+#68=VERTEX_POINT($,#67);
+#69=CARTESIAN_POINT($,(5,-4,3));
+#70=DIRECTION($,(0,1,0));
+#71=VECTOR($,#70,1);
+#72=LINE($,#69,#71);
+#73=EDGE_CURVE($,#60,#68,#72,.T.);
+#74=ORIENTED_EDGE($,$,$,#73,.T.);
+#75=CARTESIAN_POINT($,(-5,4,3));
+#76=VERTEX_POINT($,#75);
+#77=CARTESIAN_POINT($,(5,4,3));
+#78=DIRECTION($,(-1,0,0));
+#79=VECTOR($,#78,1);
+#80=LINE($,#77,#79);
+#81=EDGE_CURVE($,#68,#76,#80,.T.);
+#82=ORIENTED_EDGE($,$,$,#81,.T.);
+#83=CARTESIAN_POINT($,(-5,4,3));
+#84=DIRECTION($,(0,-1,0));
+#85=VECTOR($,#84,1);
+#86=LINE($,#83,#85);
+#87=EDGE_CURVE($,#76,#58,#86,.T.);
+#88=ORIENTED_EDGE($,$,$,#87,.T.);
+#89=EDGE_LOOP($,(#66,#74,#82,#88));
+#90=FACE_OUTER_BOUND('',#89,.T.);
+#91=CARTESIAN_POINT($,(1,0,3));
+#92=VERTEX_POINT($,#91);
+#93=CARTESIAN_POINT($,(0,0,3));
+#94=DIRECTION($,(0,0,1));
+#95=DIRECTION($,(1,0,0));
+#96=AXIS2_PLACEMENT_3D($,#93,#94,#95);
+#97=CIRCLE($,#96,1);
+#98=EDGE_CURVE($,#92,#92,#97,.T.);
+#99=ORIENTED_EDGE($,$,$,#98,.T.);
+#100=EDGE_LOOP($,(#99));
+#101=FACE_BOUND('',#100,.T.);
+#102=ADVANCED_FACE('',(#90,#101),#56,.T.);
+#103=CARTESIAN_POINT($,(0,-4,0));
+#104=DIRECTION($,(0,-1,0));
+#105=DIRECTION($,(1,0,0));
+#106=AXIS2_PLACEMENT_3D($,#103,#104,#105);
+#107=PLANE($,#106);
+#108=ORIENTED_EDGE($,$,$,#14,.T.);
+#109=CARTESIAN_POINT($,(5,-4,-3));
+#110=DIRECTION($,(0,0,1));
+#111=VECTOR($,#110,1);
+#112=LINE($,#109,#111);
+#113=EDGE_CURVE($,#9,#60,#112,.T.);
+#114=ORIENTED_EDGE($,$,$,#113,.T.);
+#115=ORIENTED_EDGE($,$,$,#65,.F.);
+#116=CARTESIAN_POINT($,(-5,-4,-3));
+#117=DIRECTION($,(0,0,1));
+#118=VECTOR($,#117,1);
+#119=LINE($,#116,#118);
+#120=EDGE_CURVE($,#7,#58,#119,.T.);
+#121=ORIENTED_EDGE($,$,$,#120,.F.);
+#122=EDGE_LOOP($,(#108,#114,#115,#121));
+#123=FACE_OUTER_BOUND('',#122,.T.);
+#124=ADVANCED_FACE('',(#123),#107,.T.);
+#125=CARTESIAN_POINT($,(5,0,0));
+#126=DIRECTION($,(1,0,0));
+#127=DIRECTION($,(0,1,0));
+#128=AXIS2_PLACEMENT_3D($,#125,#126,#127);
+#129=PLANE($,#128);
+#130=ORIENTED_EDGE($,$,$,#22,.T.);
+#131=CARTESIAN_POINT($,(5,4,-3));
+#132=DIRECTION($,(0,0,1));
+#133=VECTOR($,#132,1);
+#134=LINE($,#131,#133);
+#135=EDGE_CURVE($,#17,#68,#134,.T.);
+#136=ORIENTED_EDGE($,$,$,#135,.T.);
+#137=ORIENTED_EDGE($,$,$,#73,.F.);
+#138=ORIENTED_EDGE($,$,$,#113,.F.);
+#139=EDGE_LOOP($,(#130,#136,#137,#138));
+#140=FACE_OUTER_BOUND('',#139,.T.);
+#141=ADVANCED_FACE('',(#140),#129,.T.);
+#142=CARTESIAN_POINT($,(0,4,0));
+#143=DIRECTION($,(0,1,0));
+#144=DIRECTION($,(-1,0,0));
+#145=AXIS2_PLACEMENT_3D($,#142,#143,#144);
+#146=PLANE($,#145);
+#147=ORIENTED_EDGE($,$,$,#30,.T.);
+#148=CARTESIAN_POINT($,(-5,4,-3));
+#149=DIRECTION($,(0,0,1));
+#150=VECTOR($,#149,1);
+#151=LINE($,#148,#150);
+#152=EDGE_CURVE($,#25,#76,#151,.T.);
+#153=ORIENTED_EDGE($,$,$,#152,.T.);
+#154=ORIENTED_EDGE($,$,$,#81,.F.);
+#155=ORIENTED_EDGE($,$,$,#135,.F.);
+#156=EDGE_LOOP($,(#147,#153,#154,#155));
+#157=FACE_OUTER_BOUND('',#156,.T.);
+#158=ADVANCED_FACE('',(#157),#146,.T.);
+#159=CARTESIAN_POINT($,(-5,0,0));
+#160=DIRECTION($,(-1,0,0));
+#161=DIRECTION($,(0,1,0));
+#162=AXIS2_PLACEMENT_3D($,#159,#160,#161);
+#163=PLANE($,#162);
+#164=ORIENTED_EDGE($,$,$,#36,.T.);
+#165=ORIENTED_EDGE($,$,$,#120,.T.);
+#166=ORIENTED_EDGE($,$,$,#87,.F.);
+#167=ORIENTED_EDGE($,$,$,#152,.F.);
+#168=EDGE_LOOP($,(#164,#165,#166,#167));
+#169=FACE_OUTER_BOUND('',#168,.T.);
+#170=ADVANCED_FACE('',(#169),#163,.T.);
+#171=CARTESIAN_POINT($,(0,0,-3));
+#172=DIRECTION($,(0,0,1));
+#173=DIRECTION($,(1,0,0));
+#174=AXIS2_PLACEMENT_3D($,#171,#172,#173);
+#175=CYLINDRICAL_SURFACE($,#174,1);
+#176=CARTESIAN_POINT($,(1,0,3));
+#177=VERTEX_POINT($,#176);
+#178=CARTESIAN_POINT($,(1,0,-3));
+#179=VERTEX_POINT($,#178);
+#180=CARTESIAN_POINT($,(1,0,3));
+#181=DIRECTION($,(0,0,-1));
+#182=VECTOR($,#181,1);
+#183=LINE($,#180,#182);
+#184=EDGE_CURVE($,#177,#179,#183,.T.);
+#185=ORIENTED_EDGE($,$,$,#184,.T.);
+#186=ORIENTED_EDGE($,$,$,#98,.F.);
+#187=ORIENTED_EDGE($,$,$,#184,.F.);
+#188=ORIENTED_EDGE($,$,$,#47,.T.);
+#189=EDGE_LOOP($,(#185,#186,#187,#188));
+#190=FACE_OUTER_BOUND('',#189,.T.);
+#191=ADVANCED_FACE('',(#190),#175,.T.);
+#192=CLOSED_SHELL($,(#51,#102,#124,#141,#158,#170,#191));
+#193=MANIFOLD_SOLID_BREP('AetherisBody',#192);
+#194=APPLICATION_CONTEXT('mechanical design');
+#195=PRODUCT_CONTEXT('',#194,'mechanical');
+#196=PRODUCT('AETHERIS','AetherisBody','',(#195));
+#197=PRODUCT_DEFINITION_FORMATION('','',#196);
+#198=PRODUCT_DEFINITION_CONTEXT('design',#194,'design');
+#199=PRODUCT_DEFINITION('','',#197,#198);
+#200=PRODUCT_DEFINITION_SHAPE('','',#199);
+#201=(LENGTH_UNIT()NAMED_UNIT(*)SI_UNIT(.MILLI.,.METRE.));
+#202=(NAMED_UNIT(*)PLANE_ANGLE_UNIT()SI_UNIT($,.RADIAN.));
+#203=(NAMED_UNIT(*)SI_UNIT($,.STERADIAN.)SOLID_ANGLE_UNIT());
+#204=(GEOMETRIC_REPRESENTATION_CONTEXT(3)GLOBAL_UNIT_ASSIGNED_CONTEXT((#201,#202,#203))REPRESENTATION_CONTEXT('3','3D'));
+#205=SHAPE_REPRESENTATION('AetherisBody',(#193),#204);
+#206=SHAPE_DEFINITION_REPRESENTATION(#200,#205);
+ENDSEC;
+END-ISO-10303-21;
diff --git a/fixtures/FirmamentV2/InlineStep/valid/inline-step-v2-datum-pmi-on-canonical-face-emits-in-step.valid.firmfixture b/fixtures/FirmamentV2/InlineStep/valid/inline-step-v2-datum-pmi-on-canonical-face-emits-in-step.valid.firmfixture
new file mode 100644
index 00000000..c1d0dae5
--- /dev/null
+++ b/fixtures/FirmamentV2/InlineStep/valid/inline-step-v2-datum-pmi-on-canonical-face-emits-in-step.valid.firmfixture
@@ -0,0 +1,34 @@
+// fixture-id: inline-step-v2-datum-pmi-on-canonical-face-emits-in-step
+// case: inline-step-v2-datum-pmi-on-canonical-face-emits-in-step
+// category: InlineStep
+// syntax-version: FirmamentV2
+// validity: valid
+// implementation: parser-backed
+// expected: valid
+// tier: inline-step
+// expected-stage: step-verified
+// current-stage: step-verified
+// feature-area: inline-step-semantic-pmi
+// build-command: aetheris build
+// roundtrip-required: true
+// expected-volume: 480
+// expected-topology: faces=6, vertices=8, edges=12
+// canonical-input-required: true
+// semantic-pmi-required: true
+// graphical-pmi-required: false
+// input-step: ../testdata/canonical-box-10x8x6.step
+// semantic-pmi-evidence: SHAPE_ASPECT('firmament-datum:A'), PROPERTY_DEFINITION('datum:A:importedPart')
+// notes: INLINE-STEP-X2 attaches semantic datum PMI to canonical imported face #40 through Step242Exporter; no graphical PMI.
+model InlineStepDatumPmiOnCanonicalFace {
+ units mm
+
+ solid importedPart: InlineStep {
+ path: "../testdata/canonical-box-10x8x6.step"
+ }
+
+ pmi {
+ datum A {
+ target: importedPart.face("#40")
+ }
+ }
+}
diff --git a/fixtures/FirmamentV2/InlineStep/valid/inline-step-v2-hole-diameter-pmi-on-canonical-face-emits-in-step.valid.firmfixture b/fixtures/FirmamentV2/InlineStep/valid/inline-step-v2-hole-diameter-pmi-on-canonical-face-emits-in-step.valid.firmfixture
new file mode 100644
index 00000000..15e2eee5
--- /dev/null
+++ b/fixtures/FirmamentV2/InlineStep/valid/inline-step-v2-hole-diameter-pmi-on-canonical-face-emits-in-step.valid.firmfixture
@@ -0,0 +1,35 @@
+// fixture-id: inline-step-v2-hole-diameter-pmi-on-canonical-face-emits-in-step
+// case: inline-step-v2-hole-diameter-pmi-on-canonical-face-emits-in-step
+// category: InlineStep
+// syntax-version: FirmamentV2
+// validity: valid
+// implementation: parser-backed
+// expected: valid
+// tier: inline-step
+// expected-stage: step-verified
+// current-stage: step-verified
+// feature-area: inline-step-semantic-pmi
+// build-command: aetheris build
+// roundtrip-required: true
+// expected-volume: 461.15044407846124
+// expected-topology: advanced_face>0, vertex_point>0
+// canonical-input-required: true
+// semantic-pmi-required: true
+// graphical-pmi-required: false
+// input-step: ../testdata/canonical-through-hole.step
+// semantic-pmi-evidence: SHAPE_DIMENSION_REPRESENTATION('diameter:importedPart.holeDiameter'), PROPERTY_DEFINITION('diameter:importedPart.holeDiameter')
+// notes: INLINE-STEP-X2 attaches semantic diameter PMI to canonical imported cylindrical face #191; cylindrical face type checking is deferred to stronger topology typing.
+model InlineStepHoleDiameterPmiOnCanonicalFace {
+ units mm
+
+ solid importedPart: InlineStep {
+ path: "../testdata/canonical-through-hole.step"
+ }
+
+ pmi {
+ diameter holeDiameter {
+ target: importedPart.face("#191")
+ value: 2mm
+ }
+ }
+}