Next Gen STEP AP242 Native-ish BREP Geometric Modeling Kernel
Refine cylinder seam periodic path and validate with dotnet 8 tests
Yuechen Li2cb36a8bc33c
diff --git a/Aetheris.Kernel.Core.Tests/Step242/Step242ImporterTests.cs b/Aetheris.Kernel.Core.Tests/Step242/Step242ImporterTests.csindex 3ae2ef15..b9027f92 100644--- a/Aetheris.Kernel.Core.Tests/Step242/Step242ImporterTests.cs+++ b/Aetheris.Kernel.Core.Tests/Step242/Step242ImporterTests.cs@@ -464,6 +464,82 @@ public sealed class Step242ImporterTests}++ [Fact]+ public void Step242_HandcraftedCylinderFixture_TessellatesSideAsPeriodicClosedGrid()+ {+ var text = LoadFixture("testdata/step242/handcrafted/baseline/cylinder.step");++ var import = Step242Importer.ImportBody(text);+ Assert.True(import.IsSuccess);++ var options = DisplayTessellationOptions.Create(double.Pi / 6d, 10d, minimumSegments: 12, maximumSegments: 12).Value;+ var tessellation = BrepDisplayTessellator.Tessellate(import.Value, options);+ Assert.True(tessellation.IsSuccess);++ var cylinderFace = Assert.Single(import.Value.Topology.Faces, face =>+ {+ Assert.True(import.Value.Bindings.TryGetFaceBinding(face.Id, out var binding));+ Assert.True(import.Value.Geometry.TryGetSurface(binding.SurfaceGeometryId, out var surface));+ return surface!.Kind == SurfaceGeometryKind.Cylinder;+ });++ var patch = Assert.Single(tessellation.Value.FacePatches, p => p.FaceId == cylinderFace.Id);+ Assert.Equal(26, patch.Positions.Count);+ Assert.Equal(26, patch.Normals.Count);+ Assert.Equal(72, patch.TriangleIndices.Count);++ const int rowWidth = 13;+ const int axialRows = 2;+ for (var row = 0; row < axialRows; row++)+ {+ var seamStart = patch.Positions[row * rowWidth];+ var seamEnd = patch.Positions[(row * rowWidth) + (rowWidth - 1)];+ Assert.True((seamStart - seamEnd).Length <= 1e-8d);+ }++ Assert.All(patch.TriangleIndices, index => Assert.InRange(index, 0, patch.Positions.Count - 1));++ for (var i = 0; i < patch.TriangleIndices.Count; i += 3)+ {+ var p0 = patch.Positions[patch.TriangleIndices[i]];+ var p1 = patch.Positions[patch.TriangleIndices[i + 1]];+ var p2 = patch.Positions[patch.TriangleIndices[i + 2]];+ var area2 = (p1 - p0).Cross(p2 - p0).Length;+ Assert.True(area2 > 1e-9d);+ }+ }++ [Fact]+ public void Step242_HandcraftedCylinderFixture_Tessellation_IsDeterministic()+ {+ var text = LoadFixture("testdata/step242/handcrafted/baseline/cylinder.step");++ var import = Step242Importer.ImportBody(text);+ Assert.True(import.IsSuccess);++ var options = DisplayTessellationOptions.Create(double.Pi / 6d, 10d, minimumSegments: 12, maximumSegments: 12).Value;+ var tessellationA = BrepDisplayTessellator.Tessellate(import.Value, options);+ var tessellationB = BrepDisplayTessellator.Tessellate(import.Value, options);++ Assert.True(tessellationA.IsSuccess);+ Assert.True(tessellationB.IsSuccess);++ var cylinderFace = Assert.Single(import.Value.Topology.Faces, face =>+ {+ Assert.True(import.Value.Bindings.TryGetFaceBinding(face.Id, out var binding));+ Assert.True(import.Value.Geometry.TryGetSurface(binding.SurfaceGeometryId, out var surface));+ return surface!.Kind == SurfaceGeometryKind.Cylinder;+ });++ var patchA = Assert.Single(tessellationA.Value.FacePatches, p => p.FaceId == cylinderFace.Id);+ var patchB = Assert.Single(tessellationB.Value.FacePatches, p => p.FaceId == cylinderFace.Id);++ Assert.True(patchA.Positions.SequenceEqual(patchB.Positions));+ Assert.True(patchA.Normals.SequenceEqual(patchB.Normals));+ Assert.True(patchA.TriangleIndices.SequenceEqual(patchB.TriangleIndices));+ }+[Fact]public void Step242_HandcraftedConeFixture_UsesThreeCoedgeSeamTopology_AndTessellates(){diff --git a/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs b/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.csindex 8a4918cd..bb99b171 100644--- a/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs+++ b/Aetheris.Kernel.Core/Brep/Tessellation/BrepDisplayTessellator.cs@@ -236,6 +236,29 @@ public static class BrepDisplayTessellatorvar angularSpan = trimPatch.Value.UEnd - trimPatch.Value.UStart;var axialSpan = trimPatch.Value.VEnd - trimPatch.Value.VStart;+ var nearFullPeriodicSpan = (2d * double.Pi) - 0.25d;+ if (angularSpan >= nearFullPeriodicSpan)+ {+ var periodicParameters = GetRevolvedFaceParameters(+ body,+ faceId,+ options,+ radiusHint: cylinder.Radius,+ allowThreeCoedgeConeTopology: false);+ if (periodicParameters.IsSuccess)+ {+ return KernelResult<DisplayFaceMeshPatch>.Success(CreatePeriodicGridPatch(+ faceId,+ periodicParameters.Value.AngularSegments,+ periodicParameters.Value.AxialSegments,+ (u, v) => cylinder.Evaluate(u, v),+ (u, _) => cylinder.Normal(u).ToVector(),+ periodicParameters.Value.VStart,+ periodicParameters.Value.VEnd),+ periodicParameters.Diagnostics);+ }+ }+var angularSegments = CalculateSegmentCount(angularSpan, System.Math.Max(1e-6d, cylinder.Radius), options);var axialSegments = System.Math.Max(1, System.Math.Clamp((int)double.Ceiling(axialSpan / options.ChordTolerance), 1, options.MaximumSegments));